[libcxx-commits] [clang] [libcxx] [Clang] Implement resolution for CWG1835 (PR #92957)
Krystian Stasiowski via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jul 9 07:00:50 PDT 2024
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/92957
>From bbc8e9b3c9a1ce4b3c3b783dc3dccfd6dd69dbad Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 21 May 2024 13:15:24 -0400
Subject: [PATCH 01/26] [WIP][Clang] Implement resolution for CWG1835
---
clang/include/clang/Sema/DeclSpec.h | 8 +++
clang/include/clang/Sema/Sema.h | 2 +-
clang/lib/Parse/ParseDeclCXX.cpp | 2 +-
clang/lib/Parse/ParseExpr.cpp | 9 +--
clang/lib/Sema/SemaCXXScopeSpec.cpp | 60 +++++++++++++------
clang/lib/Sema/SemaExprMember.cpp | 10 +---
clang/lib/Sema/SemaPseudoObject.cpp | 16 ++---
clang/lib/Sema/SemaTemplate.cpp | 22 ++++---
clang/lib/Sema/TreeTransform.h | 15 +++++
.../basic.lookup.classref/p1-cxx11.cpp | 16 +++--
.../basic.lookup/basic.lookup.classref/p1.cpp | 16 +++--
.../class.derived/class.member.lookup/p8.cpp | 4 +-
clang/test/CXX/drs/cwg1xx.cpp | 7 ++-
clang/test/SemaCXX/static-assert-cxx17.cpp | 2 +-
.../SemaTemplate/temp_arg_nontype_cxx20.cpp | 2 +-
15 files changed, 127 insertions(+), 64 deletions(-)
diff --git a/clang/include/clang/Sema/DeclSpec.h b/clang/include/clang/Sema/DeclSpec.h
index 23bc780e04979..c6d87ca1683a8 100644
--- a/clang/include/clang/Sema/DeclSpec.h
+++ b/clang/include/clang/Sema/DeclSpec.h
@@ -75,6 +75,7 @@ class CXXScopeSpec {
SourceRange Range;
NestedNameSpecifierLocBuilder Builder;
ArrayRef<TemplateParameterList *> TemplateParamLists;
+ NamedDecl *FoundFirstQualifierInScope;
public:
SourceRange getRange() const { return Range; }
@@ -91,6 +92,13 @@ class CXXScopeSpec {
return TemplateParamLists;
}
+ void setFoundFirstQualifierInScope(NamedDecl *Found) {
+ FoundFirstQualifierInScope = Found;
+ }
+ NamedDecl *getFirstQualifierFoundInScope() const {
+ return FoundFirstQualifierInScope;
+ }
+
/// Retrieve the representation of the nested-name-specifier.
NestedNameSpecifier *getScopeRep() const {
return Builder.getRepresentation();
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index 75a80540dbcbf..efcf3ce1a4df1 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -8584,7 +8584,7 @@ class Sema final : public SemaBase {
/// decl; this is an ugly hack around the fact that Objective-C
/// \@implementations aren't properly put in the context chain
ExprResult ActOnMemberAccessExpr(Scope *S, Expr *Base, SourceLocation OpLoc,
- tok::TokenKind OpKind, CXXScopeSpec &SS,
+ bool IsArrow, CXXScopeSpec &SS,
SourceLocation TemplateKWLoc,
UnqualifiedId &Member, Decl *ObjCImpDecl);
diff --git a/clang/lib/Parse/ParseDeclCXX.cpp b/clang/lib/Parse/ParseDeclCXX.cpp
index ce827c689beb7..7ade92069c6ba 100644
--- a/clang/lib/Parse/ParseDeclCXX.cpp
+++ b/clang/lib/Parse/ParseDeclCXX.cpp
@@ -728,7 +728,7 @@ Parser::DeclGroupPtrTy Parser::ParseUsingDeclaration(
return nullptr;
}
CXXScopeSpec SS;
- if (ParseOptionalCXXScopeSpecifier(SS, /*ParsedType=*/nullptr,
+ if (ParseOptionalCXXScopeSpecifier(SS, /*ObjectType=*/nullptr,
/*ObectHasErrors=*/false,
/*EnteringConttext=*/false,
/*MayBePseudoDestructor=*/nullptr,
diff --git a/clang/lib/Parse/ParseExpr.cpp b/clang/lib/Parse/ParseExpr.cpp
index 2dd2e1b83548b..1cbc9779ada60 100644
--- a/clang/lib/Parse/ParseExpr.cpp
+++ b/clang/lib/Parse/ParseExpr.cpp
@@ -2269,6 +2269,7 @@ Parser::ParsePostfixExpressionSuffix(ExprResult LHS) {
}
break;
}
+
ParseOptionalCXXScopeSpecifier(
SS, ObjectType, LHS.get() && LHS.get()->containsErrors(),
/*EnteringContext=*/false, &MayBePseudoDestructor);
@@ -2343,10 +2344,10 @@ Parser::ParsePostfixExpressionSuffix(ExprResult LHS) {
}
if (!LHS.isInvalid())
- LHS = Actions.ActOnMemberAccessExpr(getCurScope(), LHS.get(), OpLoc,
- OpKind, SS, TemplateKWLoc, Name,
- CurParsedObjCImpl ? CurParsedObjCImpl->Dcl
- : nullptr);
+ LHS = Actions.ActOnMemberAccessExpr(
+ getCurScope(), LHS.get(), OpLoc, OpKind == tok::arrow, SS,
+ TemplateKWLoc, Name,
+ CurParsedObjCImpl ? CurParsedObjCImpl->Dcl : nullptr);
if (!LHS.isInvalid()) {
if (Tok.is(tok::less))
checkPotentialAngleBracket(LHS);
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index 5b2d65247e72e..3966f16fd516f 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -363,11 +363,19 @@ NamedDecl *Sema::FindFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS) {
while (NNS->getPrefix())
NNS = NNS->getPrefix();
- if (NNS->getKind() != NestedNameSpecifier::Identifier)
- return nullptr;
-
- LookupResult Found(*this, NNS->getAsIdentifier(), SourceLocation(),
- LookupNestedNameSpecifierName);
+ const IdentifierInfo *II = NNS->getAsIdentifier();
+ if (!II) {
+ if (const auto *DTST =
+ dyn_cast_if_present<DependentTemplateSpecializationType>(
+ NNS->getAsType()))
+ II = DTST->getIdentifier();
+ else
+ return nullptr;
+ }
+ assert(II && "Missing first qualifier in scope");
+ LookupResult Found(*this, II, SourceLocation(),
+ NNS->getAsIdentifier() ? LookupNestedNameSpecifierName
+ : LookupOrdinaryName);
LookupName(Found, S);
assert(!Found.isAmbiguous() && "Cannot handle ambiguities here yet");
@@ -375,10 +383,10 @@ NamedDecl *Sema::FindFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS) {
return nullptr;
NamedDecl *Result = Found.getFoundDecl();
- if (isAcceptableNestedNameSpecifier(Result))
- return Result;
+ // if (isAcceptableNestedNameSpecifier(Result))
+ return Result;
- return nullptr;
+ // return nullptr;
}
namespace {
@@ -428,12 +436,15 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
// x->B::f, and we are looking into the type of the object.
assert(!SS.isSet() && "ObjectType and scope specifier cannot coexist");
LookupCtx = computeDeclContext(ObjectType);
- isDependent = ObjectType->isDependentType();
- } else if (SS.isSet()) {
+ isDependent = !LookupCtx && ObjectType->isDependentType();
+ } else if (SS.isNotEmpty()) {
// This nested-name-specifier occurs after another nested-name-specifier,
// so look into the context associated with the prior nested-name-specifier.
LookupCtx = computeDeclContext(SS, EnteringContext);
- isDependent = isDependentScopeSpecifier(SS);
+ isDependent = !LookupCtx && isDependentScopeSpecifier(SS);
+ // The declaration context must be complete.
+ if (LookupCtx && RequireCompleteDeclContext(SS, LookupCtx))
+ return true;
Found.setContextRange(SS.getRange());
}
@@ -444,14 +455,28 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
// expression or the declaration context associated with a prior
// nested-name-specifier.
- // The declaration context must be complete.
- if (!LookupCtx->isDependentContext() &&
- RequireCompleteDeclContext(SS, LookupCtx))
- return true;
-
LookupQualifiedName(Found, LookupCtx);
- if (!ObjectType.isNull() && Found.empty()) {
+ isDependent |= Found.wasNotFoundInCurrentInstantiation();
+ }
+
+ bool LookupFirstQualifierInScope =
+ Found.empty() && !ObjectType.isNull() && !isDependent;
+
+ // FIXME: We should still do the lookup if the object expression is dependent,
+ // but instead of using them we should store them via
+ // setFirstQualifierFoundInScope and pretend we found nothing.
+ if (SS.isEmpty() && (ObjectType.isNull() || LookupFirstQualifierInScope)) {
+ if (S)
+ LookupName(Found, S);
+ else if (LookupFirstQualifierInScope && SS.getFirstQualifierFoundInScope())
+ Found.addDecl(SS.getFirstQualifierFoundInScope());
+
+ if (!ObjectType.isNull())
+ ObjectTypeSearchedInScope = true;
+ }
+#if 0
+ if (!ObjectType.isNull() && Found.empty() && !isDependent) {
// C++ [basic.lookup.classref]p4:
// If the id-expression in a class member access is a qualified-id of
// the form
@@ -483,6 +508,7 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
// Perform unqualified name lookup in the current scope.
LookupName(Found, S);
}
+#endif
if (Found.isAmbiguous())
return true;
diff --git a/clang/lib/Sema/SemaExprMember.cpp b/clang/lib/Sema/SemaExprMember.cpp
index b7ea24790d361..0eaabfaec8b65 100644
--- a/clang/lib/Sema/SemaExprMember.cpp
+++ b/clang/lib/Sema/SemaExprMember.cpp
@@ -1041,7 +1041,7 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
if (RetryExpr.isUsable() && !Trap.hasErrorOccurred()) {
CXXScopeSpec TempSS(SS);
RetryExpr = ActOnMemberAccessExpr(
- ExtraArgs->S, RetryExpr.get(), OpLoc, tok::arrow, TempSS,
+ ExtraArgs->S, RetryExpr.get(), OpLoc, /*IsArrow=*/true, TempSS,
TemplateKWLoc, ExtraArgs->Id, ExtraArgs->ObjCImpDecl);
}
if (Trap.hasErrorOccurred())
@@ -1744,12 +1744,10 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult &R,
}
ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
- SourceLocation OpLoc,
- tok::TokenKind OpKind,
+ SourceLocation OpLoc, bool IsArrow,
CXXScopeSpec &SS,
SourceLocation TemplateKWLoc,
- UnqualifiedId &Id,
- Decl *ObjCImpDecl) {
+ UnqualifiedId &Id, Decl *ObjCImpDecl) {
if (SS.isSet() && SS.isInvalid())
return ExprError();
@@ -1767,8 +1765,6 @@ ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
DecomposeUnqualifiedId(Id, TemplateArgsBuffer,
NameInfo, TemplateArgs);
- bool IsArrow = (OpKind == tok::arrow);
-
if (getLangOpts().HLSL && IsArrow)
return ExprError(Diag(OpLoc, diag::err_hlsl_operator_unsupported) << 2);
diff --git a/clang/lib/Sema/SemaPseudoObject.cpp b/clang/lib/Sema/SemaPseudoObject.cpp
index fdb584ceb8105..86c303e67bc1d 100644
--- a/clang/lib/Sema/SemaPseudoObject.cpp
+++ b/clang/lib/Sema/SemaPseudoObject.cpp
@@ -1395,10 +1395,10 @@ ExprResult MSPropertyOpBuilder::buildGet() {
GetterName.setIdentifier(II, RefExpr->getMemberLoc());
CXXScopeSpec SS;
SS.Adopt(RefExpr->getQualifierLoc());
- ExprResult GetterExpr =
- S.ActOnMemberAccessExpr(S.getCurScope(), InstanceBase, SourceLocation(),
- RefExpr->isArrow() ? tok::arrow : tok::period, SS,
- SourceLocation(), GetterName, nullptr);
+ ExprResult GetterExpr = S.ActOnMemberAccessExpr(
+ S.getCurScope(), InstanceBase, /*OpLoc=*/SourceLocation(),
+ RefExpr->isArrow(), SS, /*TemplateKWLoc=*/SourceLocation(), GetterName,
+ /*ObjCImpDecl=*/nullptr);
if (GetterExpr.isInvalid()) {
S.Diag(RefExpr->getMemberLoc(),
diag::err_cannot_find_suitable_accessor) << 0 /* getter */
@@ -1424,10 +1424,10 @@ ExprResult MSPropertyOpBuilder::buildSet(Expr *op, SourceLocation sl,
SetterName.setIdentifier(II, RefExpr->getMemberLoc());
CXXScopeSpec SS;
SS.Adopt(RefExpr->getQualifierLoc());
- ExprResult SetterExpr =
- S.ActOnMemberAccessExpr(S.getCurScope(), InstanceBase, SourceLocation(),
- RefExpr->isArrow() ? tok::arrow : tok::period, SS,
- SourceLocation(), SetterName, nullptr);
+ ExprResult SetterExpr = S.ActOnMemberAccessExpr(
+ S.getCurScope(), InstanceBase, /*OpLoc=*/SourceLocation(),
+ RefExpr->isArrow(), SS, /*TemplateKWLoc=*/SourceLocation(), SetterName,
+ /*ObjCImpDecl=*/nullptr);
if (SetterExpr.isInvalid()) {
S.Diag(RefExpr->getMemberLoc(),
diag::err_cannot_find_suitable_accessor) << 1 /* setter */
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index 07b3f793b3a29..b9b93f2071d4b 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -214,6 +214,7 @@ TemplateNameKind Sema::isTemplateName(Scope *S,
&AssumedTemplate,
/*AllowTypoCorrection=*/!Disambiguation))
return TNK_Non_template;
+
MemberOfUnknownSpecialization = R.wasNotFoundInCurrentInstantiation();
if (AssumedTemplate != AssumedTemplateKind::None) {
@@ -433,7 +434,6 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
}
bool ObjectTypeSearchedInScope = false;
- bool AllowFunctionTemplatesInLookup = true;
if (LookupCtx) {
// Perform "qualified" name lookup into the declaration context we
// computed, which is either the type of the base of a member access
@@ -452,7 +452,14 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
IsDependent |= Found.wasNotFoundInCurrentInstantiation();
}
- if (SS.isEmpty() && (ObjectType.isNull() || Found.empty())) {
+ bool LookupFirstQualifierInScope =
+ Found.getLookupKind() != LookupMemberName && Found.empty() &&
+ !ObjectType.isNull() && !IsDependent;
+
+ // FIXME: We should still do the lookup if the object expression is dependent,
+ // but instead of using them we should store them via
+ // setFirstQualifierFoundInScope and pretend we found nothing.
+ if (SS.isEmpty() && (ObjectType.isNull() || LookupFirstQualifierInScope)) {
// C++ [basic.lookup.classref]p1:
// In a class member access expression (5.2.5), if the . or -> token is
// immediately followed by an identifier followed by a <, the
@@ -464,14 +471,11 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
// template.
if (S)
LookupName(Found, S);
+ else if (LookupFirstQualifierInScope && SS.getFirstQualifierFoundInScope())
+ Found.addDecl(SS.getFirstQualifierFoundInScope());
- if (!ObjectType.isNull()) {
- // FIXME: We should filter out all non-type templates here, particularly
- // variable templates and concepts. But the exclusion of alias templates
- // and template template parameters is a wording defect.
- AllowFunctionTemplatesInLookup = false;
+ if (!ObjectType.isNull())
ObjectTypeSearchedInScope = true;
- }
IsDependent |= Found.wasNotFoundInCurrentInstantiation();
}
@@ -542,7 +546,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
NamedDecl *ExampleLookupResult =
Found.empty() ? nullptr : Found.getRepresentativeDecl();
- FilterAcceptableTemplateNames(Found, AllowFunctionTemplatesInLookup);
+ FilterAcceptableTemplateNames(Found);
if (Found.empty()) {
if (IsDependent) {
Found.setNotFoundInCurrentInstantiation();
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index 4450ebaf615cd..9a0098b4b480a 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -2894,6 +2894,8 @@ class TreeTransform {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
+ if (FirstQualifierInScope)
+ SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
Base = BaseResult.get();
QualType BaseType = Base->getType();
@@ -3582,6 +3584,9 @@ class TreeTransform {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
+ if (FirstQualifierInScope)
+ SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
+
return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType,
OperatorLoc, IsArrow,
SS, TemplateKWLoc,
@@ -3605,6 +3610,9 @@ class TreeTransform {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
+ if (FirstQualifierInScope)
+ SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
+
return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType,
OperatorLoc, IsArrow,
SS, TemplateKWLoc,
@@ -4392,6 +4400,8 @@ NestedNameSpecifierLoc TreeTransform<Derived>::TransformNestedNameSpecifierLoc(
insertNNS(NNS);
CXXScopeSpec SS;
+ if (FirstQualifierInScope)
+ SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
while (!Qualifiers.empty()) {
NestedNameSpecifierLoc Q = Qualifiers.pop_back_val();
NestedNameSpecifier *QNNS = Q.getNestedNameSpecifier();
@@ -5189,6 +5199,9 @@ TypeSourceInfo *TreeTransform<Derived>::TransformTSIInObjectScope(
TypeLocBuilder TLB;
QualType Result;
+ if (UnqualLookup)
+ SS.setFoundFirstQualifierInScope(UnqualLookup);
+
if (isa<TemplateSpecializationType>(T)) {
TemplateSpecializationTypeLoc SpecTL =
TL.castAs<TemplateSpecializationTypeLoc>();
@@ -16285,6 +16298,8 @@ TreeTransform<Derived>::RebuildTemplateName(CXXScopeSpec &SS,
UnqualifiedId TemplateName;
TemplateName.setIdentifier(&Name, NameLoc);
Sema::TemplateTy Template;
+ if (FirstQualifierInScope)
+ SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
getSema().ActOnTemplateName(/*Scope=*/nullptr, SS, TemplateKWLoc,
TemplateName, ParsedType::make(ObjectType),
/*EnteringContext=*/false, Template,
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp
index 1afea99e8895c..476745537f691 100644
--- a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp
@@ -55,15 +55,21 @@ namespace PR11856 {
template<typename T> T *end(T*);
- class X { };
+ struct X { };
+ struct Y {
+ int end;
+ };
template <typename T>
void Foo2() {
T it1;
- if (it1->end < it1->end) {
- }
+ if (it1->end < it1->end) { }
X *x;
- if (x->end < 7) { // expected-error{{no member named 'end' in 'PR11856::X'}}
- }
+ if (x->end < 7) { } // expected-error{{expected '>'}}
+ // expected-note at -1{{to match this '<'}}
+ // expected-error at -2{{expected unqualified-id}}
+
+ Y *y;
+ if (y->end < 7) { }
}
}
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp
index e3599db18350b..cabf3f73830bc 100644
--- a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp
@@ -86,15 +86,21 @@ namespace PR11856 {
template<typename T> T *end(T*);
- class X { };
+ struct X { };
+ struct Y {
+ int end;
+ };
template <typename T>
void Foo2() {
T it1;
- if (it1->end < it1->end) {
- }
+ if (it1->end < it1->end) { }
X *x;
- if (x->end < 7) { // expected-error{{no member named 'end' in 'PR11856::X'}}
- }
+ if (x->end < 7) { } // expected-error{{expected '>'}}
+ // expected-note at -1{{to match this '<'}}
+ // expected-error at -2{{expected unqualified-id}}
+
+ Y *y;
+ if (y->end < 7) { }
}
}
diff --git a/clang/test/CXX/class.derived/class.member.lookup/p8.cpp b/clang/test/CXX/class.derived/class.member.lookup/p8.cpp
index 78e83c0ab4566..e9a57f739cc35 100644
--- a/clang/test/CXX/class.derived/class.member.lookup/p8.cpp
+++ b/clang/test/CXX/class.derived/class.member.lookup/p8.cpp
@@ -47,8 +47,8 @@ template<typename T>
void DerivedT<T>::Inner() {
Derived1T<T>::Foo();
Derived2T<T>::Member = 42;
- this->Derived1T<T>::Foo();
- this->Derived2T<T>::Member = 42;
+ this->Derived1T<T>::Foo(); // expected-error{{use 'template' keyword to treat 'Derived1T' as a dependent template name}}
+ this->Derived2T<T>::Member = 42; // expected-error{{use 'template' keyword to treat 'Derived2T' as a dependent template name}}
this->Foo(); // expected-error{{non-static member 'Foo' found in multiple base-class subobjects of type 'BaseT<int>'}}
}
diff --git a/clang/test/CXX/drs/cwg1xx.cpp b/clang/test/CXX/drs/cwg1xx.cpp
index e7dddd1ea9278..3831b42e87b00 100644
--- a/clang/test/CXX/drs/cwg1xx.cpp
+++ b/clang/test/CXX/drs/cwg1xx.cpp
@@ -618,7 +618,6 @@ namespace cwg141 { // cwg141: 3.1
// FIXME: we issue a useful diagnostic first, then some bogus ones.
b.f<int>();
// expected-error at -1 {{no member named 'f' in 'cwg141::B'}}
- // expected-error at -2 +{{}}
(void)b.S<int>::n;
}
template<typename T> struct C {
@@ -628,10 +627,12 @@ namespace cwg141 { // cwg141: 3.1
// expected-error at -1 {{use 'template' keyword to treat 'f' as a dependent template name}}
}
void h() {
- (void)t.S<int>::n; // ok
+ (void)t.S<int>::n;
+ // expected-error at -1 {{use 'template' keyword to treat 'S' as a dependent template name}}
}
void i() {
- (void)t.S<int>(); // ok!
+ (void)t.S<int>();
+ // expected-error at -1 {{use 'template' keyword to treat 'S' as a dependent template name}}
}
};
void h() { C<B>().h(); } // ok
diff --git a/clang/test/SemaCXX/static-assert-cxx17.cpp b/clang/test/SemaCXX/static-assert-cxx17.cpp
index 41a7b025d0eb7..754f4ae5f1d38 100644
--- a/clang/test/SemaCXX/static-assert-cxx17.cpp
+++ b/clang/test/SemaCXX/static-assert-cxx17.cpp
@@ -96,7 +96,7 @@ void foo6() {
// expected-error at -1{{static assertion failed due to requirement 'static_cast<const X<int> *>(nullptr)'}}
static_assert((const X<typename T::T>[]){} == nullptr);
// expected-error at -1{{static assertion failed due to requirement '(const X<int>[0]){} == nullptr'}}
- static_assert(sizeof(X<decltype(X<typename T::T>().X<typename T::T>::~X())>) == 0);
+ static_assert(sizeof(X<decltype(X<typename T::T>().template X<typename T::T>::~X())>) == 0);
// expected-error at -1{{static assertion failed due to requirement 'sizeof(X<void>) == 0'}} \
// expected-note at -1 {{evaluates to '8 == 0'}}
static_assert(constexpr_return_false<typename T::T, typename T::U>());
diff --git a/clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp b/clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
index ad73daa8e214c..7768d2f03ac5b 100644
--- a/clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
+++ b/clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
@@ -115,7 +115,7 @@ namespace CopyCounting {
static_assert(f(X<A{}>()) == 0);
template<A a> struct Y { void f(); };
- template<A a> void g(Y<a> y) { y.Y<a>::f(); }
+ template<A a> void g(Y<a> y) { y.template Y<a>::f(); }
void h() { constexpr A a; g<a>(Y<a>{}); }
template<A a> struct Z {
>From 8b1e415fd08bad00b02e3374b6c8e587ebcfe3b3 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 21 May 2024 15:57:06 -0400
Subject: [PATCH 02/26] [FOLD] add comment
---
clang/lib/Sema/SemaCXXScopeSpec.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index 3966f16fd516f..b8de9309c5c71 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -363,6 +363,8 @@ NamedDecl *Sema::FindFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS) {
while (NNS->getPrefix())
NNS = NNS->getPrefix();
+ // FIXME: This is a rather nasty hack! Ideally we should get the results
+ // from LookupTemplateName/BuildCXXNestedNameSpecifier.
const IdentifierInfo *II = NNS->getAsIdentifier();
if (!II) {
if (const auto *DTST =
>From ca2a03dd5ad2f42689df189dbb1f43f4fa625dfe Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Fri, 31 May 2024 12:59:34 -0400
Subject: [PATCH 03/26] [FOLD] store all results found by unqualified lookup
for the first component name of a member-qualified nested-name-specifier
---
clang/include/clang/AST/ExprCXX.h | 83 +++++++++----
clang/include/clang/AST/Stmt.h | 13 +-
clang/include/clang/AST/UnresolvedSet.h | 4 +
clang/include/clang/Sema/DeclSpec.h | 10 +-
clang/include/clang/Sema/Lookup.h | 8 +-
clang/include/clang/Sema/Sema.h | 10 +-
clang/lib/AST/ASTImporter.cpp | 13 +-
clang/lib/AST/ExprCXX.cpp | 65 ++++++----
clang/lib/AST/ItaniumMangle.cpp | 10 +-
clang/lib/Sema/SemaCXXScopeSpec.cpp | 41 ++++---
clang/lib/Sema/SemaCoroutine.cpp | 2 +-
clang/lib/Sema/SemaDeclCXX.cpp | 22 ++--
clang/lib/Sema/SemaExpr.cpp | 2 +-
clang/lib/Sema/SemaExprMember.cpp | 37 +++---
clang/lib/Sema/SemaOverload.cpp | 3 +-
clang/lib/Sema/SemaStmtAsm.cpp | 7 +-
clang/lib/Sema/SemaTemplate.cpp | 11 +-
clang/lib/Sema/SemaTemplateInstantiate.cpp | 5 +-
clang/lib/Sema/TreeTransform.h | 132 +++++++++------------
clang/lib/Serialization/ASTReaderStmt.cpp | 51 +++++++-
clang/lib/Serialization/ASTWriterStmt.cpp | 38 ++++++
clang/test/SemaCXX/pseudo-destructors.cpp | 18 +--
22 files changed, 359 insertions(+), 226 deletions(-)
diff --git a/clang/include/clang/AST/ExprCXX.h b/clang/include/clang/AST/ExprCXX.h
index c2feac525c1ea..ce0004d0e0479 100644
--- a/clang/include/clang/AST/ExprCXX.h
+++ b/clang/include/clang/AST/ExprCXX.h
@@ -3677,8 +3677,10 @@ class CXXUnresolvedConstructExpr final
class CXXDependentScopeMemberExpr final
: public Expr,
private llvm::TrailingObjects<CXXDependentScopeMemberExpr,
+ NestedNameSpecifierLoc,
+ DeclAccessPair,
ASTTemplateKWAndArgsInfo,
- TemplateArgumentLoc, NamedDecl *> {
+ TemplateArgumentLoc> {
friend class ASTStmtReader;
friend class ASTStmtWriter;
friend TrailingObjects;
@@ -3691,17 +3693,15 @@ class CXXDependentScopeMemberExpr final
/// implicit accesses.
QualType BaseType;
- /// The nested-name-specifier that precedes the member name, if any.
- /// FIXME: This could be in principle store as a trailing object.
- /// However the performance impact of doing so should be investigated first.
- NestedNameSpecifierLoc QualifierLoc;
-
/// The member to which this member expression refers, which
/// can be name, overloaded operator, or destructor.
///
/// FIXME: could also be a template-id
DeclarationNameInfo MemberNameInfo;
+ /// The location of the '->' or '.' operator.
+ SourceLocation OperatorLoc;
+
// CXXDependentScopeMemberExpr is followed by several trailing objects,
// some of which optional. They are in order:
//
@@ -3721,8 +3721,16 @@ class CXXDependentScopeMemberExpr final
return CXXDependentScopeMemberExprBits.HasTemplateKWAndArgsInfo;
}
- bool hasFirstQualifierFoundInScope() const {
- return CXXDependentScopeMemberExprBits.HasFirstQualifierFoundInScope;
+ unsigned getNumUnqualifiedLookups() const {
+ return CXXDependentScopeMemberExprBits.NumUnqualifiedLookups;
+ }
+
+ unsigned numTrailingObjects(OverloadToken<NestedNameSpecifierLoc>) const {
+ return hasQualifier();
+ }
+
+ unsigned numTrailingObjects(OverloadToken<DeclAccessPair>) const {
+ return getNumUnqualifiedLookups();
}
unsigned numTrailingObjects(OverloadToken<ASTTemplateKWAndArgsInfo>) const {
@@ -3733,33 +3741,35 @@ class CXXDependentScopeMemberExpr final
return getNumTemplateArgs();
}
- unsigned numTrailingObjects(OverloadToken<NamedDecl *>) const {
- return hasFirstQualifierFoundInScope();
- }
-
CXXDependentScopeMemberExpr(const ASTContext &Ctx, Expr *Base,
QualType BaseType, bool IsArrow,
SourceLocation OperatorLoc,
NestedNameSpecifierLoc QualifierLoc,
SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierFoundInScope,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationNameInfo MemberNameInfo,
const TemplateArgumentListInfo *TemplateArgs);
- CXXDependentScopeMemberExpr(EmptyShell Empty, bool HasTemplateKWAndArgsInfo,
- bool HasFirstQualifierFoundInScope);
+ CXXDependentScopeMemberExpr(EmptyShell Empty, bool HasQualifier,
+ unsigned NumUnqualifiedLookups,
+ bool HasTemplateKWAndArgsInfo);
public:
static CXXDependentScopeMemberExpr *
- Create(const ASTContext &Ctx, Expr *Base, QualType BaseType, bool IsArrow,
- SourceLocation OperatorLoc, NestedNameSpecifierLoc QualifierLoc,
- SourceLocation TemplateKWLoc, NamedDecl *FirstQualifierFoundInScope,
+ Create(const ASTContext &Ctx, Expr *Base,
+ QualType BaseType, bool IsArrow,
+ SourceLocation OperatorLoc,
+ NestedNameSpecifierLoc QualifierLoc,
+ SourceLocation TemplateKWLoc,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationNameInfo MemberNameInfo,
const TemplateArgumentListInfo *TemplateArgs);
static CXXDependentScopeMemberExpr *
- CreateEmpty(const ASTContext &Ctx, bool HasTemplateKWAndArgsInfo,
- unsigned NumTemplateArgs, bool HasFirstQualifierFoundInScope);
+ CreateEmpty(const ASTContext &Ctx, bool HasQualifier,
+ unsigned NumUnqualifiedLookups,
+ bool HasTemplateKWAndArgsInfo,
+ unsigned NumTemplateArgs);
/// True if this is an implicit access, i.e. one in which the
/// member being accessed was not written in the source. The source
@@ -3785,18 +3795,32 @@ class CXXDependentScopeMemberExpr final
/// Retrieve the location of the '->' or '.' operator.
SourceLocation getOperatorLoc() const {
- return CXXDependentScopeMemberExprBits.OperatorLoc;
+ return OperatorLoc;
+ }
+
+ /// Determines whether this member expression had a nested-name-specifier
+ /// prior to the name of the member, e.g., x->Base::foo.
+ bool hasQualifier() const {
+ return CXXDependentScopeMemberExprBits.HasQualifier;
}
- /// Retrieve the nested-name-specifier that qualifies the member name.
+ /// If the member name was qualified, retrieves the nested-name-specifier
+ /// that precedes the member name, with source-location information.
+ NestedNameSpecifierLoc getQualifierLoc() const {
+ if (!hasQualifier())
+ return NestedNameSpecifierLoc();
+ return *getTrailingObjects<NestedNameSpecifierLoc>();
+ }
+
+ /// If the member name was qualified, retrieves the
+ /// nested-name-specifier that precedes the member name. Otherwise, returns
+ /// NULL.
NestedNameSpecifier *getQualifier() const {
- return QualifierLoc.getNestedNameSpecifier();
+ return getQualifierLoc().getNestedNameSpecifier();
}
- /// Retrieve the nested-name-specifier that qualifies the member
- /// name, with source location information.
- NestedNameSpecifierLoc getQualifierLoc() const { return QualifierLoc; }
+ #if 0
/// Retrieve the first part of the nested-name-specifier that was
/// found in the scope of the member access expression when the member access
/// was initially parsed.
@@ -3813,6 +3837,13 @@ class CXXDependentScopeMemberExpr final
return nullptr;
return *getTrailingObjects<NamedDecl *>();
}
+ #endif
+
+ ArrayRef<DeclAccessPair> unqualified_lookups() const {
+ if (!getNumUnqualifiedLookups())
+ return std::nullopt;
+ return {getTrailingObjects<DeclAccessPair>(), getNumUnqualifiedLookups()};
+ }
/// Retrieve the name of the member that this expression refers to.
const DeclarationNameInfo &getMemberNameInfo() const {
diff --git a/clang/include/clang/AST/Stmt.h b/clang/include/clang/AST/Stmt.h
index 9cd7a364cd3f1..e0e5c8fb99dc3 100644
--- a/clang/include/clang/AST/Stmt.h
+++ b/clang/include/clang/AST/Stmt.h
@@ -1020,18 +1020,25 @@ class alignas(void *) Stmt {
LLVM_PREFERRED_TYPE(bool)
unsigned IsArrow : 1;
+ /// True if this member expression used a nested-name-specifier to
+ /// refer to the member, e.g., "x->Base::f".
+ LLVM_PREFERRED_TYPE(bool)
+ unsigned HasQualifier : 1;
+
/// Whether this member expression has info for explicit template
/// keyword and arguments.
LLVM_PREFERRED_TYPE(bool)
unsigned HasTemplateKWAndArgsInfo : 1;
+ #if 0
/// See getFirstQualifierFoundInScope() and the comment listing
/// the trailing objects.
LLVM_PREFERRED_TYPE(bool)
unsigned HasFirstQualifierFoundInScope : 1;
-
- /// The location of the '->' or '.' operator.
- SourceLocation OperatorLoc;
+ #endif
+ /// Number of declarations found by unqualified lookup for the
+ /// first component name of the nested-name-specifier.
+ unsigned NumUnqualifiedLookups;
};
class OverloadExprBitfields {
diff --git a/clang/include/clang/AST/UnresolvedSet.h b/clang/include/clang/AST/UnresolvedSet.h
index 1369725ab4e96..ef44499ce5926 100644
--- a/clang/include/clang/AST/UnresolvedSet.h
+++ b/clang/include/clang/AST/UnresolvedSet.h
@@ -97,6 +97,10 @@ class UnresolvedSetImpl {
decls().push_back(DeclAccessPair::make(D, AS));
}
+ void addAllDecls(ArrayRef<DeclAccessPair> Other) {
+ append(iterator(Other.begin()), iterator(Other.end()));
+ }
+
/// Replaces the given declaration with the new one, once.
///
/// \return true if the set changed
diff --git a/clang/include/clang/Sema/DeclSpec.h b/clang/include/clang/Sema/DeclSpec.h
index c6d87ca1683a8..231f3fc6fec83 100644
--- a/clang/include/clang/Sema/DeclSpec.h
+++ b/clang/include/clang/Sema/DeclSpec.h
@@ -75,7 +75,7 @@ class CXXScopeSpec {
SourceRange Range;
NestedNameSpecifierLocBuilder Builder;
ArrayRef<TemplateParameterList *> TemplateParamLists;
- NamedDecl *FoundFirstQualifierInScope;
+ ArrayRef<DeclAccessPair> UnqualifiedLookups;
public:
SourceRange getRange() const { return Range; }
@@ -92,11 +92,11 @@ class CXXScopeSpec {
return TemplateParamLists;
}
- void setFoundFirstQualifierInScope(NamedDecl *Found) {
- FoundFirstQualifierInScope = Found;
+ void setUnqualifiedLookups(ArrayRef<DeclAccessPair> Found) {
+ UnqualifiedLookups = Found;
}
- NamedDecl *getFirstQualifierFoundInScope() const {
- return FoundFirstQualifierInScope;
+ ArrayRef<DeclAccessPair> getUnqualifiedLookups() const {
+ return UnqualifiedLookups;
}
/// Retrieve the representation of the nested-name-specifier.
diff --git a/clang/include/clang/Sema/Lookup.h b/clang/include/clang/Sema/Lookup.h
index b0a08a05ac6a0..6b765ef3c980f 100644
--- a/clang/include/clang/Sema/Lookup.h
+++ b/clang/include/clang/Sema/Lookup.h
@@ -483,11 +483,15 @@ class LookupResult {
ResultKind = Found;
}
+ void addAllDecls(ArrayRef<DeclAccessPair> Other) {
+ Decls.addAllDecls(Other);
+ ResultKind = Found;
+ }
+
/// Add all the declarations from another set of lookup
/// results.
void addAllDecls(const LookupResult &Other) {
- Decls.append(Other.Decls.begin(), Other.Decls.end());
- ResultKind = Found;
+ addAllDecls(Other.Decls.pairs());
}
/// Determine whether no result was found because we could not
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index efcf3ce1a4df1..e16b9bdff549e 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -2802,7 +2802,7 @@ class Sema final : public SemaBase {
/// (e.g., Base::), perform name lookup for that identifier as a
/// nested-name-specifier within the given scope, and return the result of
/// that name lookup.
- NamedDecl *FindFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS);
+ bool LookupFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS, UnresolvedSetImpl &R);
/// Keeps information about an identifier in a nested-name-spec.
///
@@ -2866,7 +2866,6 @@ class Sema final : public SemaBase {
/// specifier.
bool BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
bool EnteringContext, CXXScopeSpec &SS,
- NamedDecl *ScopeLookupResult,
bool ErrorRecoveryLookup,
bool *IsCorrectedToColon = nullptr,
bool OnlyNamespace = false);
@@ -8570,7 +8569,7 @@ class Sema final : public SemaBase {
ExprResult ActOnDependentMemberExpr(
Expr *Base, QualType BaseType, bool IsArrow, SourceLocation OpLoc,
const CXXScopeSpec &SS, SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope, const DeclarationNameInfo &NameInfo,
+ const DeclarationNameInfo &NameInfo,
const TemplateArgumentListInfo *TemplateArgs);
/// The main callback when the parser finds something like
@@ -8627,15 +8626,14 @@ class Sema final : public SemaBase {
ExprResult BuildMemberReferenceExpr(
Expr *Base, QualType BaseType, SourceLocation OpLoc, bool IsArrow,
CXXScopeSpec &SS, SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope, const DeclarationNameInfo &NameInfo,
+ const DeclarationNameInfo &NameInfo,
const TemplateArgumentListInfo *TemplateArgs, const Scope *S,
ActOnMemberAccessExtraArgs *ExtraArgs = nullptr);
ExprResult
BuildMemberReferenceExpr(Expr *Base, QualType BaseType, SourceLocation OpLoc,
bool IsArrow, const CXXScopeSpec &SS,
- SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope, LookupResult &R,
+ SourceLocation TemplateKWLoc, LookupResult &R,
const TemplateArgumentListInfo *TemplateArgs,
const Scope *S, bool SuppressQualifierCheck = false,
ActOnMemberAccessExtraArgs *ExtraArgs = nullptr);
diff --git a/clang/lib/AST/ASTImporter.cpp b/clang/lib/AST/ASTImporter.cpp
index 4e1b3a5a94de7..a5a0f8cb022c8 100644
--- a/clang/lib/AST/ASTImporter.cpp
+++ b/clang/lib/AST/ASTImporter.cpp
@@ -8439,8 +8439,15 @@ ExpectedStmt ASTNodeImporter::VisitCXXDependentScopeMemberExpr(
auto ToOperatorLoc = importChecked(Err, E->getOperatorLoc());
auto ToQualifierLoc = importChecked(Err, E->getQualifierLoc());
auto ToTemplateKeywordLoc = importChecked(Err, E->getTemplateKeywordLoc());
- auto ToFirstQualifierFoundInScope =
- importChecked(Err, E->getFirstQualifierFoundInScope());
+
+
+ UnresolvedSet<8> ToUnqualifiedLookups;
+ for (auto D : E->unqualified_lookups())
+ if (auto ToDOrErr = import(D.getDecl()))
+ ToUnqualifiedLookups.addDecl(*ToDOrErr);
+ else
+ return ToDOrErr.takeError();
+
if (Err)
return std::move(Err);
@@ -8474,7 +8481,7 @@ ExpectedStmt ASTNodeImporter::VisitCXXDependentScopeMemberExpr(
return CXXDependentScopeMemberExpr::Create(
Importer.getToContext(), ToBase, ToType, E->isArrow(), ToOperatorLoc,
- ToQualifierLoc, ToTemplateKeywordLoc, ToFirstQualifierFoundInScope,
+ ToQualifierLoc, ToTemplateKeywordLoc, ToUnqualifiedLookups.pairs(),
ToMemberNameInfo, ResInfo);
}
diff --git a/clang/lib/AST/ExprCXX.cpp b/clang/lib/AST/ExprCXX.cpp
index 8d2a1b5611ccc..6fc59693bf69e 100644
--- a/clang/lib/AST/ExprCXX.cpp
+++ b/clang/lib/AST/ExprCXX.cpp
@@ -1489,19 +1489,27 @@ SourceLocation CXXUnresolvedConstructExpr::getBeginLoc() const {
CXXDependentScopeMemberExpr::CXXDependentScopeMemberExpr(
const ASTContext &Ctx, Expr *Base, QualType BaseType, bool IsArrow,
SourceLocation OperatorLoc, NestedNameSpecifierLoc QualifierLoc,
- SourceLocation TemplateKWLoc, NamedDecl *FirstQualifierFoundInScope,
+ SourceLocation TemplateKWLoc, ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationNameInfo MemberNameInfo,
const TemplateArgumentListInfo *TemplateArgs)
: Expr(CXXDependentScopeMemberExprClass, Ctx.DependentTy, VK_LValue,
OK_Ordinary),
- Base(Base), BaseType(BaseType), QualifierLoc(QualifierLoc),
+ Base(Base), BaseType(BaseType), OperatorLoc(OperatorLoc),
MemberNameInfo(MemberNameInfo) {
CXXDependentScopeMemberExprBits.IsArrow = IsArrow;
+ CXXDependentScopeMemberExprBits.HasQualifier =
+ QualifierLoc.hasQualifier();
+ CXXDependentScopeMemberExprBits.NumUnqualifiedLookups =
+ UnqualifiedLookups.size();
CXXDependentScopeMemberExprBits.HasTemplateKWAndArgsInfo =
(TemplateArgs != nullptr) || TemplateKWLoc.isValid();
- CXXDependentScopeMemberExprBits.HasFirstQualifierFoundInScope =
- FirstQualifierFoundInScope != nullptr;
- CXXDependentScopeMemberExprBits.OperatorLoc = OperatorLoc;
+
+ if (hasQualifier())
+ new (getTrailingObjects<NestedNameSpecifierLoc>())
+ NestedNameSpecifierLoc(QualifierLoc);
+
+ std::uninitialized_copy_n(UnqualifiedLookups.data(),
+ UnqualifiedLookups.size(), getTrailingObjects<DeclAccessPair>());
if (TemplateArgs) {
auto Deps = TemplateArgumentDependence::None;
@@ -1513,54 +1521,61 @@ CXXDependentScopeMemberExpr::CXXDependentScopeMemberExpr(
TemplateKWLoc);
}
- if (hasFirstQualifierFoundInScope())
- *getTrailingObjects<NamedDecl *>() = FirstQualifierFoundInScope;
setDependence(computeDependence(this));
}
CXXDependentScopeMemberExpr::CXXDependentScopeMemberExpr(
- EmptyShell Empty, bool HasTemplateKWAndArgsInfo,
- bool HasFirstQualifierFoundInScope)
+ EmptyShell Empty, bool HasQualifier, unsigned NumUnqualifiedLookups,
+ bool HasTemplateKWAndArgsInfo)
: Expr(CXXDependentScopeMemberExprClass, Empty) {
+ CXXDependentScopeMemberExprBits.HasQualifier = HasQualifier;
+ CXXDependentScopeMemberExprBits.NumUnqualifiedLookups =
+ NumUnqualifiedLookups;
CXXDependentScopeMemberExprBits.HasTemplateKWAndArgsInfo =
HasTemplateKWAndArgsInfo;
- CXXDependentScopeMemberExprBits.HasFirstQualifierFoundInScope =
- HasFirstQualifierFoundInScope;
}
CXXDependentScopeMemberExpr *CXXDependentScopeMemberExpr::Create(
const ASTContext &Ctx, Expr *Base, QualType BaseType, bool IsArrow,
SourceLocation OperatorLoc, NestedNameSpecifierLoc QualifierLoc,
- SourceLocation TemplateKWLoc, NamedDecl *FirstQualifierFoundInScope,
+ SourceLocation TemplateKWLoc, ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationNameInfo MemberNameInfo,
const TemplateArgumentListInfo *TemplateArgs) {
+ bool HasQualifier = QualifierLoc.hasQualifier();
+ unsigned NumUnqualifiedLookups = UnqualifiedLookups.size();
+ assert(!NumUnqualifiedLookups || HasQualifier);
bool HasTemplateKWAndArgsInfo =
(TemplateArgs != nullptr) || TemplateKWLoc.isValid();
unsigned NumTemplateArgs = TemplateArgs ? TemplateArgs->size() : 0;
- bool HasFirstQualifierFoundInScope = FirstQualifierFoundInScope != nullptr;
-
- unsigned Size = totalSizeToAlloc<ASTTemplateKWAndArgsInfo,
- TemplateArgumentLoc, NamedDecl *>(
- HasTemplateKWAndArgsInfo, NumTemplateArgs, HasFirstQualifierFoundInScope);
+ unsigned Size = totalSizeToAlloc<NestedNameSpecifierLoc,
+ DeclAccessPair,
+ ASTTemplateKWAndArgsInfo,
+ TemplateArgumentLoc>(
+ HasQualifier, NumUnqualifiedLookups,
+ HasTemplateKWAndArgsInfo, NumTemplateArgs);
void *Mem = Ctx.Allocate(Size, alignof(CXXDependentScopeMemberExpr));
return new (Mem) CXXDependentScopeMemberExpr(
Ctx, Base, BaseType, IsArrow, OperatorLoc, QualifierLoc, TemplateKWLoc,
- FirstQualifierFoundInScope, MemberNameInfo, TemplateArgs);
+ UnqualifiedLookups, MemberNameInfo, TemplateArgs);
}
CXXDependentScopeMemberExpr *CXXDependentScopeMemberExpr::CreateEmpty(
- const ASTContext &Ctx, bool HasTemplateKWAndArgsInfo,
- unsigned NumTemplateArgs, bool HasFirstQualifierFoundInScope) {
- assert(NumTemplateArgs == 0 || HasTemplateKWAndArgsInfo);
+ const ASTContext &Ctx, bool HasQualifier, unsigned NumUnqualifiedLookups,
+ bool HasTemplateKWAndArgsInfo, unsigned NumTemplateArgs) {
+ assert(!NumTemplateArgs || HasTemplateKWAndArgsInfo);
+ assert(!NumUnqualifiedLookups || HasQualifier);
- unsigned Size = totalSizeToAlloc<ASTTemplateKWAndArgsInfo,
- TemplateArgumentLoc, NamedDecl *>(
- HasTemplateKWAndArgsInfo, NumTemplateArgs, HasFirstQualifierFoundInScope);
+ unsigned Size = totalSizeToAlloc<NestedNameSpecifierLoc,
+ DeclAccessPair,
+ ASTTemplateKWAndArgsInfo,
+ TemplateArgumentLoc>(
+ HasQualifier, NumUnqualifiedLookups,
+ HasTemplateKWAndArgsInfo, NumTemplateArgs);
void *Mem = Ctx.Allocate(Size, alignof(CXXDependentScopeMemberExpr));
return new (Mem) CXXDependentScopeMemberExpr(
- EmptyShell(), HasTemplateKWAndArgsInfo, HasFirstQualifierFoundInScope);
+ EmptyShell(), HasQualifier, NumUnqualifiedLookups, HasTemplateKWAndArgsInfo);
}
CXXThisExpr *CXXThisExpr::Create(const ASTContext &Ctx, SourceLocation L,
diff --git a/clang/lib/AST/ItaniumMangle.cpp b/clang/lib/AST/ItaniumMangle.cpp
index 5444dcf027fe2..a15fc9cba309b 100644
--- a/clang/lib/AST/ItaniumMangle.cpp
+++ b/clang/lib/AST/ItaniumMangle.cpp
@@ -594,7 +594,7 @@ class CXXNameMangler {
void mangleMemberExprBase(const Expr *base, bool isArrow);
void mangleMemberExpr(const Expr *base, bool isArrow,
NestedNameSpecifier *qualifier,
- NamedDecl *firstQualifierLookup,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationName name,
const TemplateArgumentLoc *TemplateArgs,
unsigned NumTemplateArgs,
@@ -4499,7 +4499,7 @@ void CXXNameMangler::mangleMemberExprBase(const Expr *Base, bool IsArrow) {
void CXXNameMangler::mangleMemberExpr(const Expr *base,
bool isArrow,
NestedNameSpecifier *qualifier,
- NamedDecl *firstQualifierLookup,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationName member,
const TemplateArgumentLoc *TemplateArgs,
unsigned NumTemplateArgs,
@@ -4986,7 +4986,7 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity,
NotPrimaryExpr();
const MemberExpr *ME = cast<MemberExpr>(E);
mangleMemberExpr(ME->getBase(), ME->isArrow(),
- ME->getQualifier(), nullptr,
+ ME->getQualifier(), std::nullopt,
ME->getMemberDecl()->getDeclName(),
ME->getTemplateArgs(), ME->getNumTemplateArgs(),
Arity);
@@ -4997,7 +4997,7 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity,
NotPrimaryExpr();
const UnresolvedMemberExpr *ME = cast<UnresolvedMemberExpr>(E);
mangleMemberExpr(ME->isImplicitAccess() ? nullptr : ME->getBase(),
- ME->isArrow(), ME->getQualifier(), nullptr,
+ ME->isArrow(), ME->getQualifier(), std::nullopt,
ME->getMemberName(),
ME->getTemplateArgs(), ME->getNumTemplateArgs(),
Arity);
@@ -5010,7 +5010,7 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity,
= cast<CXXDependentScopeMemberExpr>(E);
mangleMemberExpr(ME->isImplicitAccess() ? nullptr : ME->getBase(),
ME->isArrow(), ME->getQualifier(),
- ME->getFirstQualifierFoundInScope(),
+ ME->unqualified_lookups(),
ME->getMember(),
ME->getTemplateArgs(), ME->getNumTemplateArgs(),
Arity);
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index b8de9309c5c71..b0b5a02ee0bdf 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -356,9 +356,9 @@ bool Sema::isAcceptableNestedNameSpecifier(const NamedDecl *SD,
return false;
}
-NamedDecl *Sema::FindFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS) {
- if (!S || !NNS)
- return nullptr;
+bool Sema::LookupFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS, UnresolvedSetImpl &R) {
+ if (!S)
+ return false;
while (NNS->getPrefix())
NNS = NNS->getPrefix();
@@ -372,23 +372,20 @@ NamedDecl *Sema::FindFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS) {
NNS->getAsType()))
II = DTST->getIdentifier();
else
- return nullptr;
+ return false;
}
assert(II && "Missing first qualifier in scope");
LookupResult Found(*this, II, SourceLocation(),
NNS->getAsIdentifier() ? LookupNestedNameSpecifierName
: LookupOrdinaryName);
LookupName(Found, S);
- assert(!Found.isAmbiguous() && "Cannot handle ambiguities here yet");
-
- if (!Found.isSingleResult())
- return nullptr;
- NamedDecl *Result = Found.getFoundDecl();
- // if (isAcceptableNestedNameSpecifier(Result))
- return Result;
+ if (Found.empty())
+ return false;
- // return nullptr;
+ R.addAllDecls(Found.asUnresolvedSet().pairs());
+ Found.suppressDiagnostics();
+ return true;
}
namespace {
@@ -417,7 +414,6 @@ class NestedNameSpecifierValidatorCCC final
bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
bool EnteringContext, CXXScopeSpec &SS,
- NamedDecl *ScopeLookupResult,
bool ErrorRecoveryLookup,
bool *IsCorrectedToColon,
bool OnlyNamespace) {
@@ -469,10 +465,13 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
// but instead of using them we should store them via
// setFirstQualifierFoundInScope and pretend we found nothing.
if (SS.isEmpty() && (ObjectType.isNull() || LookupFirstQualifierInScope)) {
- if (S)
+ if (S) {
LookupName(Found, S);
- else if (LookupFirstQualifierInScope && SS.getFirstQualifierFoundInScope())
- Found.addDecl(SS.getFirstQualifierFoundInScope());
+ } else if (LookupFirstQualifierInScope &&
+ !SS.getUnqualifiedLookups().empty()) {
+ Found.addAllDecls(SS.getUnqualifiedLookups());
+ Found.resolveKind();
+ }
if (!ObjectType.isNull())
ObjectTypeSearchedInScope = true;
@@ -622,14 +621,14 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
// scope, reconstruct the result from the template instantiation itself.
//
// Note that C++11 does *not* perform this redundant lookup.
- NamedDecl *OuterDecl;
+ NamedDecl *OuterDecl = nullptr;
if (S) {
LookupResult FoundOuter(*this, IdInfo.Identifier, IdInfo.IdentifierLoc,
LookupNestedNameSpecifierName);
LookupName(FoundOuter, S);
OuterDecl = FoundOuter.getAsSingle<NamedDecl>();
- } else
- OuterDecl = ScopeLookupResult;
+ } else if (!SS.getUnqualifiedLookups().empty())
+ OuterDecl = SS.getUnqualifiedLookups().front().getDecl();
if (isAcceptableNestedNameSpecifier(OuterDecl) &&
OuterDecl->getCanonicalDecl() != SD->getCanonicalDecl() &&
@@ -807,7 +806,7 @@ bool Sema::ActOnCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
return true;
return BuildCXXNestedNameSpecifier(S, IdInfo, EnteringContext, SS,
- /*ScopeLookupResult=*/nullptr, false,
+ /*ErrorRecoveryLookup=*/false,
IsCorrectedToColon, OnlyNamespace);
}
@@ -868,7 +867,7 @@ bool Sema::IsInvalidUnlessNestedName(Scope *S, CXXScopeSpec &SS,
return false;
return !BuildCXXNestedNameSpecifier(S, IdInfo, EnteringContext, SS,
- /*ScopeLookupResult=*/nullptr, true);
+ /*ErrorRecoveryLookup=*/true);
}
bool Sema::ActOnCXXNestedNameSpecifier(Scope *S,
diff --git a/clang/lib/Sema/SemaCoroutine.cpp b/clang/lib/Sema/SemaCoroutine.cpp
index 81334c817b2af..dbe0f0cf11b90 100644
--- a/clang/lib/Sema/SemaCoroutine.cpp
+++ b/clang/lib/Sema/SemaCoroutine.cpp
@@ -307,7 +307,7 @@ static ExprResult buildMemberCall(Sema &S, Expr *Base, SourceLocation Loc,
CXXScopeSpec SS;
ExprResult Result = S.BuildMemberReferenceExpr(
Base, Base->getType(), Loc, /*IsPtr=*/false, SS,
- SourceLocation(), nullptr, NameInfo, /*TemplateArgs=*/nullptr,
+ SourceLocation(), NameInfo, /*TemplateArgs=*/nullptr,
/*Scope=*/nullptr);
if (Result.isInvalid())
return ExprError();
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index 59487bf57baa9..5763d9c03ef35 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -1275,9 +1275,11 @@ static bool checkTupleLikeDecomposition(Sema &S,
if (UseMemberGet) {
// if [lookup of member get] finds at least one declaration, the
// initializer is e.get<i-1>().
- E = S.BuildMemberReferenceExpr(E.get(), DecompType, Loc, false,
- CXXScopeSpec(), SourceLocation(), nullptr,
- MemberGet, &Args, nullptr);
+ E = S.BuildMemberReferenceExpr(E.get(), DecompType, Loc,
+ /*IsArrow=*/false,
+ /*SS=*/CXXScopeSpec(),
+ /*TemplateKWLoc=*/SourceLocation(),
+ MemberGet, &Args, /*S=*/nullptr);
if (E.isInvalid())
return true;
@@ -4907,10 +4909,9 @@ BuildImplicitMemberInitializer(Sema &SemaRef, CXXConstructorDecl *Constructor,
/*IsArrow=*/false,
SS,
/*TemplateKWLoc=*/SourceLocation(),
- /*FirstQualifierInScope=*/nullptr,
MemberLookup,
/*TemplateArgs=*/nullptr,
- /*S*/nullptr);
+ /*S=*/nullptr);
if (CtorArg.isInvalid())
return true;
@@ -14336,8 +14337,9 @@ class MemberBuilder: public ExprBuilder {
public:
Expr *build(Sema &S, SourceLocation Loc) const override {
return assertNotNull(S.BuildMemberReferenceExpr(
- Builder.build(S, Loc), Type, Loc, IsArrow, SS, SourceLocation(),
- nullptr, MemberLookup, nullptr, nullptr).get());
+ Builder.build(S, Loc), Type, Loc, IsArrow, SS,
+ /*TemplateKwLoc=*/SourceLocation(), MemberLookup,
+ /*TemplateArgs=*/nullptr, /*S=*/nullptr).get());
}
MemberBuilder(const ExprBuilder &Builder, QualType Type, bool IsArrow,
@@ -14546,7 +14548,6 @@ buildSingleCopyAssignRecursively(Sema &S, SourceLocation Loc, QualType T,
ExprResult OpEqualRef
= S.BuildMemberReferenceExpr(To.build(S, Loc), T, Loc, /*IsArrow=*/false,
SS, /*TemplateKWLoc=*/SourceLocation(),
- /*FirstQualifierInScope=*/nullptr,
OpLookup,
/*TemplateArgs=*/nullptr, /*S*/nullptr,
/*SuppressQualifierCheck=*/true);
@@ -17155,8 +17156,9 @@ bool Sema::EvaluateStaticAssertMessageAsString(Expr *Message,
auto BuildExpr = [&](LookupResult &LR) {
ExprResult Res = BuildMemberReferenceExpr(
- Message, Message->getType(), Message->getBeginLoc(), false,
- CXXScopeSpec(), SourceLocation(), nullptr, LR, nullptr, nullptr);
+ Message, Message->getType(), Message->getBeginLoc(), /*IsArrow=*/false,
+ /*SS=*/CXXScopeSpec(), /*TemplateKWLoc=*/SourceLocation(), LR,
+ /*TemplateArgs=*/nullptr, /*S=*/nullptr);
if (Res.isInvalid())
return ExprError();
Res = BuildCallExpr(nullptr, Res.get(), Loc, std::nullopt, Loc, nullptr,
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp
index 852344d895ffd..2b3c11e6783f6 100644
--- a/clang/lib/Sema/SemaExpr.cpp
+++ b/clang/lib/Sema/SemaExpr.cpp
@@ -2624,7 +2624,7 @@ recoverFromMSUnqualifiedLookup(Sema &S, ASTContext &Context,
return CXXDependentScopeMemberExpr::Create(
Context, /*This=*/nullptr, ThisType, /*IsArrow=*/true,
/*Op=*/SourceLocation(), NestedNameSpecifierLoc(), TemplateKWLoc,
- /*FirstQualifierFoundInScope=*/nullptr, NameInfo, TemplateArgs);
+ /*UnqualifiedLookups=*/std::nullopt, NameInfo, TemplateArgs);
}
// Synthesize a fake NNS that points to the derived class. This will
diff --git a/clang/lib/Sema/SemaExprMember.cpp b/clang/lib/Sema/SemaExprMember.cpp
index 0eaabfaec8b65..7eddcbb231d60 100644
--- a/clang/lib/Sema/SemaExprMember.cpp
+++ b/clang/lib/Sema/SemaExprMember.cpp
@@ -556,7 +556,6 @@ Sema::ActOnDependentMemberExpr(Expr *BaseExpr, QualType BaseType,
bool IsArrow, SourceLocation OpLoc,
const CXXScopeSpec &SS,
SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope,
const DeclarationNameInfo &NameInfo,
const TemplateArgumentListInfo *TemplateArgs) {
// Even in dependent contexts, try to diagnose base expressions with
@@ -590,8 +589,8 @@ Sema::ActOnDependentMemberExpr(Expr *BaseExpr, QualType BaseType,
// must have pointer type, and the accessed type is the pointee.
return CXXDependentScopeMemberExpr::Create(
Context, BaseExpr, BaseType, IsArrow, OpLoc,
- SS.getWithLocInContext(Context), TemplateKWLoc, FirstQualifierInScope,
- NameInfo, TemplateArgs);
+ SS.getWithLocInContext(Context), TemplateKWLoc,
+ SS.getUnqualifiedLookups(), NameInfo, TemplateArgs);
}
/// We know that the given qualified member reference points only to
@@ -767,8 +766,9 @@ static bool LookupMemberExprInRecord(Sema &SemaRef, LookupResult &R,
R.addDecl(ND);
R.resolveKind();
return SemaRef.BuildMemberReferenceExpr(
- BaseExpr, BaseExpr->getType(), OpLoc, IsArrow, SS, SourceLocation(),
- nullptr, R, nullptr, nullptr);
+ BaseExpr, BaseExpr->getType(), OpLoc, IsArrow, SS,
+ /*TemplateKWLoc=*/SourceLocation(), R, /*TemplateArgs=*/nullptr,
+ /*S=*/nullptr);
},
Sema::CTK_ErrorRecovery, DC);
@@ -784,7 +784,7 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult &R,
ExprResult Sema::BuildMemberReferenceExpr(
Expr *Base, QualType BaseType, SourceLocation OpLoc, bool IsArrow,
CXXScopeSpec &SS, SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope, const DeclarationNameInfo &NameInfo,
+ const DeclarationNameInfo &NameInfo,
const TemplateArgumentListInfo *TemplateArgs, const Scope *S,
ActOnMemberAccessExtraArgs *ExtraArgs) {
LookupResult R(*this, NameInfo, LookupMemberName);
@@ -828,8 +828,9 @@ ExprResult Sema::BuildMemberReferenceExpr(
return BuildMemberReferenceExpr(Base, BaseType,
OpLoc, IsArrow, SS, TemplateKWLoc,
- FirstQualifierInScope, R, TemplateArgs, S,
- false, ExtraArgs);
+ R, TemplateArgs, S,
+ /*SuppressQualifierCheck=*/false,
+ ExtraArgs);
}
ExprResult
@@ -972,7 +973,6 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
SourceLocation OpLoc, bool IsArrow,
const CXXScopeSpec &SS,
SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope,
LookupResult &R,
const TemplateArgumentListInfo *TemplateArgs,
const Scope *S,
@@ -987,8 +987,8 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
(SS.isSet() ? SS.getScopeRep()->isDependent()
: BaseExprType->isDependentType())))
return ActOnDependentMemberExpr(BaseExpr, BaseExprType, IsArrow, OpLoc, SS,
- TemplateKWLoc, FirstQualifierInScope,
- R.getLookupNameInfo(), TemplateArgs);
+ TemplateKWLoc, R.getLookupNameInfo(),
+ TemplateArgs);
QualType BaseType = BaseExprType;
if (IsArrow) {
@@ -1195,7 +1195,7 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
if (!VDecl.get())
return ActOnDependentMemberExpr(
BaseExpr, BaseExpr->getType(), IsArrow, OpLoc, SS, TemplateKWLoc,
- FirstQualifierInScope, MemberNameInfo, TemplateArgs);
+ MemberNameInfo, TemplateArgs);
VarDecl *Var = cast<VarDecl>(VDecl.get());
if (!Var->getTemplateSpecializationKind())
@@ -1768,9 +1768,10 @@ ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
if (getLangOpts().HLSL && IsArrow)
return ExprError(Diag(OpLoc, diag::err_hlsl_operator_unsupported) << 2);
- NamedDecl *FirstQualifierInScope
- = (!SS.isSet() ? nullptr : FindFirstQualifierInScope(S, SS.getScopeRep()));
-
+ UnresolvedSet<4> UnqualifiedLookups;
+ if (SS.isValid() && LookupFirstQualifierInScope(S, SS.getScopeRep(), UnqualifiedLookups)) {
+ SS.setUnqualifiedLookups(UnqualifiedLookups.pairs());
+ }
// This is a postfix expression, so get rid of ParenListExprs.
ExprResult Result = MaybeConvertParenListExprToParenExpr(S, Base);
if (Result.isInvalid()) return ExprError();
@@ -1779,7 +1780,7 @@ ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
ActOnMemberAccessExtraArgs ExtraArgs = {S, Id, ObjCImpDecl};
ExprResult Res = BuildMemberReferenceExpr(
Base, Base->getType(), OpLoc, IsArrow, SS, TemplateKWLoc,
- FirstQualifierInScope, NameInfo, TemplateArgs, S, &ExtraArgs);
+ NameInfo, TemplateArgs, S, &ExtraArgs);
if (!Res.isInvalid() && isa<MemberExpr>(Res.get()))
CheckMemberAccessOfNoDeref(cast<MemberExpr>(Res.get()));
@@ -1926,6 +1927,6 @@ Sema::BuildImplicitMemberExpr(const CXXScopeSpec &SS,
return BuildMemberReferenceExpr(
baseExpr, ThisTy,
/*OpLoc=*/SourceLocation(),
- /*IsArrow=*/!getLangOpts().HLSL, SS, TemplateKWLoc,
- /*FirstQualifierInScope=*/nullptr, R, TemplateArgs, S);
+ /*IsArrow=*/!getLangOpts().HLSL, SS,
+ TemplateKWLoc, R, TemplateArgs, S);
}
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index 5ea6b06121c7c..c82980b94d3e7 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -16045,9 +16045,8 @@ Sema::BuildForRangeBeginEndCall(SourceLocation Loc,
if (!MemberLookup.empty()) {
ExprResult MemberRef =
BuildMemberReferenceExpr(Range, Range->getType(), Loc,
- /*IsPtr=*/false, CXXScopeSpec(),
+ /*IsPtr=*/false, /*SS=*/CXXScopeSpec(),
/*TemplateKWLoc=*/SourceLocation(),
- /*FirstQualifierInScope=*/nullptr,
MemberLookup,
/*TemplateArgs=*/nullptr, S);
if (MemberRef.isInvalid()) {
diff --git a/clang/lib/Sema/SemaStmtAsm.cpp b/clang/lib/Sema/SemaStmtAsm.cpp
index 32d42f3c3f3bb..9b1e49620173d 100644
--- a/clang/lib/Sema/SemaStmtAsm.cpp
+++ b/clang/lib/Sema/SemaStmtAsm.cpp
@@ -900,7 +900,7 @@ Sema::LookupInlineAsmVarDeclField(Expr *E, StringRef Member,
return CXXDependentScopeMemberExpr::Create(
Context, E, T, /*IsArrow=*/false, AsmLoc, NestedNameSpecifierLoc(),
SourceLocation(),
- /*FirstQualifierFoundInScope=*/nullptr, NameInfo, /*TemplateArgs=*/nullptr);
+ /*UnqualifiedLookups=*/std::nullopt, NameInfo, /*TemplateArgs=*/nullptr);
}
const RecordType *RT = T->getAs<RecordType>();
@@ -923,8 +923,9 @@ Sema::LookupInlineAsmVarDeclField(Expr *E, StringRef Member,
// Make an Expr to thread through OpDecl.
ExprResult Result = BuildMemberReferenceExpr(
- E, E->getType(), AsmLoc, /*IsArrow=*/false, CXXScopeSpec(),
- SourceLocation(), nullptr, FieldResult, nullptr, nullptr);
+ E, E->getType(), AsmLoc, /*IsArrow=*/false, /*SS=*/CXXScopeSpec(),
+ /*TemplateKWLoc*/SourceLocation(), FieldResult,
+ /*TemplateArgs=*/nullptr, /*S=*/nullptr);
return Result;
}
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index b9b93f2071d4b..7c8dc59306071 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -469,10 +469,13 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
// expression. If the identifier is not found, it is then looked up in
// the context of the entire postfix-expression and shall name a class
// template.
- if (S)
+ if (S) {
LookupName(Found, S);
- else if (LookupFirstQualifierInScope && SS.getFirstQualifierFoundInScope())
- Found.addDecl(SS.getFirstQualifierFoundInScope());
+ } else if (LookupFirstQualifierInScope &&
+ !SS.getUnqualifiedLookups().empty()) {
+ Found.addAllDecls(SS.getUnqualifiedLookups());
+ Found.resolveKind();
+ }
if (!ObjectType.isNull())
ObjectTypeSearchedInScope = true;
@@ -744,7 +747,7 @@ Sema::ActOnDependentIdExpression(const CXXScopeSpec &SS,
/*IsArrow=*/!Context.getLangOpts().HLSL,
/*OperatorLoc=*/SourceLocation(),
/*QualifierLoc=*/NestedNameSpecifierLoc(), TemplateKWLoc,
- /*FirstQualifierFoundInScope=*/nullptr, NameInfo, TemplateArgs);
+ /*UnqualifiedLookups=*/std::nullopt, NameInfo, TemplateArgs);
}
return BuildDependentDeclRefExpr(SS, TemplateKWLoc, NameInfo, TemplateArgs);
}
diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp
index a7bc6749c5852..c12a56bf4a7fe 100644
--- a/clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -1519,7 +1519,6 @@ namespace {
TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
SourceLocation NameLoc,
QualType ObjectType = QualType(),
- NamedDecl *FirstQualifierInScope = nullptr,
bool AllowInjectedClassName = false);
const CXXAssumeAttr *TransformCXXAssumeAttr(const CXXAssumeAttr *AA);
@@ -1952,8 +1951,7 @@ TemplateInstantiator::RebuildElaboratedType(SourceLocation KeywordLoc,
TemplateName TemplateInstantiator::TransformTemplateName(
CXXScopeSpec &SS, TemplateName Name, SourceLocation NameLoc,
- QualType ObjectType, NamedDecl *FirstQualifierInScope,
- bool AllowInjectedClassName) {
+ QualType ObjectType, bool AllowInjectedClassName) {
if (TemplateTemplateParmDecl *TTP
= dyn_cast_or_null<TemplateTemplateParmDecl>(Name.getAsTemplateDecl())) {
if (TTP->getDepth() < TemplateArgs.getNumLevels()) {
@@ -2025,7 +2023,6 @@ TemplateName TemplateInstantiator::TransformTemplateName(
}
return inherited::TransformTemplateName(SS, Name, NameLoc, ObjectType,
- FirstQualifierInScope,
AllowInjectedClassName);
}
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index 9a0098b4b480a..a24debd6d9fad 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -544,7 +544,7 @@ class TreeTransform {
NestedNameSpecifierLoc
TransformNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS,
QualType ObjectType = QualType(),
- NamedDecl *FirstQualifierInScope = nullptr);
+ ArrayRef<DeclAccessPair> UnqualifiedLookups = std::nullopt);
/// Transform the given declaration name.
///
@@ -589,7 +589,6 @@ class TreeTransform {
TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
SourceLocation NameLoc,
QualType ObjectType = QualType(),
- NamedDecl *FirstQualifierInScope = nullptr,
bool AllowInjectedClassName = false);
/// Transform the given template argument.
@@ -1140,7 +1139,7 @@ class TreeTransform {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
TemplateName InstName = getDerived().RebuildTemplateName(
- SS, TemplateKWLoc, *Name, NameLoc, QualType(), nullptr,
+ SS, TemplateKWLoc, *Name, NameLoc, QualType(),
AllowInjectedClassName);
if (InstName.isNull())
@@ -1312,7 +1311,6 @@ class TreeTransform {
SourceLocation TemplateKWLoc,
const IdentifierInfo &Name,
SourceLocation NameLoc, QualType ObjectType,
- NamedDecl *FirstQualifierInScope,
bool AllowInjectedClassName);
/// Build a new template name given a nested name specifier and the
@@ -2857,7 +2855,7 @@ class TreeTransform {
ValueDecl *Member,
NamedDecl *FoundDecl,
const TemplateArgumentListInfo *ExplicitTemplateArgs,
- NamedDecl *FirstQualifierInScope) {
+ ArrayRef<DeclAccessPair> UnqualifiedLookups) {
ExprResult BaseResult = getSema().PerformMemberExprBaseConversion(Base,
isArrow);
if (!Member->getDeclName()) {
@@ -2894,8 +2892,7 @@ class TreeTransform {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
- if (FirstQualifierInScope)
- SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
+ SS.setUnqualifiedLookups(UnqualifiedLookups);
Base = BaseResult.get();
QualType BaseType = Base->getType();
@@ -2926,7 +2923,6 @@ class TreeTransform {
return getSema().BuildMemberReferenceExpr(Base, BaseType, OpLoc, isArrow,
SS, TemplateKWLoc,
- FirstQualifierInScope,
R, ExplicitTemplateArgs,
/*S*/nullptr);
}
@@ -3001,10 +2997,9 @@ class TreeTransform {
CXXScopeSpec SS;
DeclarationNameInfo NameInfo(&Accessor, AccessorLoc);
return getSema().BuildMemberReferenceExpr(
- Base, Base->getType(), OpLoc, IsArrow, SS, SourceLocation(),
- /*FirstQualifierInScope*/ nullptr, NameInfo,
- /* TemplateArgs */ nullptr,
- /*S*/ nullptr);
+ Base, Base->getType(), OpLoc, IsArrow, SS,
+ /*TemplateKWLoc=*/SourceLocation(), NameInfo,
+ /*TemplateArgs=*/ nullptr, /*S=*/nullptr);
}
/// Build a new initializer list expression.
@@ -3578,21 +3573,18 @@ class TreeTransform {
SourceLocation OperatorLoc,
NestedNameSpecifierLoc QualifierLoc,
SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups,
const DeclarationNameInfo &MemberNameInfo,
const TemplateArgumentListInfo *TemplateArgs) {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
-
- if (FirstQualifierInScope)
- SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
+ SS.setUnqualifiedLookups(UnqualifiedLookups);
return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType,
OperatorLoc, IsArrow,
SS, TemplateKWLoc,
- FirstQualifierInScope,
MemberNameInfo,
- TemplateArgs, /*S*/nullptr);
+ TemplateArgs, /*S=*/nullptr);
}
/// Build a new member reference expression.
@@ -3604,20 +3596,17 @@ class TreeTransform {
bool IsArrow,
NestedNameSpecifierLoc QualifierLoc,
SourceLocation TemplateKWLoc,
- NamedDecl *FirstQualifierInScope,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups,
LookupResult &R,
const TemplateArgumentListInfo *TemplateArgs) {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
-
- if (FirstQualifierInScope)
- SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
+ SS.setUnqualifiedLookups(UnqualifiedLookups);
return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType,
OperatorLoc, IsArrow,
SS, TemplateKWLoc,
- FirstQualifierInScope,
- R, TemplateArgs, /*S*/nullptr);
+ R, TemplateArgs, /*S=*/nullptr);
}
/// Build a new noexcept expression.
@@ -3836,10 +3825,8 @@ class TreeTransform {
DeclarationNameInfo NameInfo(Ivar->getDeclName(), IvarLoc);
ExprResult Result = getSema().BuildMemberReferenceExpr(
BaseArg, BaseArg->getType(),
- /*FIXME:*/ IvarLoc, IsArrow, SS, SourceLocation(),
- /*FirstQualifierInScope=*/nullptr, NameInfo,
- /*TemplateArgs=*/nullptr,
- /*S=*/nullptr);
+ /*FIXME:*/ IvarLoc, IsArrow, SS, /*TemplateKWLoc=*/SourceLocation(),
+ NameInfo, /*TemplateArgs=*/nullptr, /*S=*/nullptr);
if (IsFreeIvar && Result.isUsable())
cast<ObjCIvarRefExpr>(Result.get())->setIsFreeIvar(IsFreeIvar);
return Result;
@@ -3857,8 +3844,7 @@ class TreeTransform {
return getSema().BuildMemberReferenceExpr(BaseArg, BaseArg->getType(),
/*FIXME:*/PropertyLoc,
/*IsArrow=*/false,
- SS, SourceLocation(),
- /*FirstQualifierInScope=*/nullptr,
+ SS, /*TemplateKWLoc=*/SourceLocation(),
NameInfo,
/*TemplateArgs=*/nullptr,
/*S=*/nullptr);
@@ -3890,8 +3876,7 @@ class TreeTransform {
DeclarationNameInfo NameInfo(&getSema().Context.Idents.get("isa"), IsaLoc);
return getSema().BuildMemberReferenceExpr(BaseArg, BaseArg->getType(),
OpLoc, IsArrow,
- SS, SourceLocation(),
- /*FirstQualifierInScope=*/nullptr,
+ SS, /*TemplateKWLoc=*/SourceLocation(),
NameInfo,
/*TemplateArgs=*/nullptr,
/*S=*/nullptr);
@@ -4061,16 +4046,14 @@ class TreeTransform {
private:
TypeLoc TransformTypeInObjectScope(TypeLoc TL,
QualType ObjectType,
- NamedDecl *FirstQualifierInScope,
CXXScopeSpec &SS);
TypeSourceInfo *TransformTypeInObjectScope(TypeSourceInfo *TSInfo,
QualType ObjectType,
- NamedDecl *FirstQualifierInScope,
CXXScopeSpec &SS);
- TypeSourceInfo *TransformTSIInObjectScope(TypeLoc TL, QualType ObjectType,
- NamedDecl *FirstQualifierInScope,
+ TypeSourceInfo *TransformTSIInObjectScope(TypeLoc TL,
+ QualType ObjectType,
CXXScopeSpec &SS);
QualType TransformDependentNameType(TypeLocBuilder &TLB,
@@ -4389,7 +4372,7 @@ Sema::ConditionResult TreeTransform<Derived>::TransformCondition(
template <typename Derived>
NestedNameSpecifierLoc TreeTransform<Derived>::TransformNestedNameSpecifierLoc(
NestedNameSpecifierLoc NNS, QualType ObjectType,
- NamedDecl *FirstQualifierInScope) {
+ ArrayRef<DeclAccessPair> UnqualifiedLookups) {
SmallVector<NestedNameSpecifierLoc, 4> Qualifiers;
auto insertNNS = [&Qualifiers](NestedNameSpecifierLoc NNS) {
@@ -4400,8 +4383,8 @@ NestedNameSpecifierLoc TreeTransform<Derived>::TransformNestedNameSpecifierLoc(
insertNNS(NNS);
CXXScopeSpec SS;
- if (FirstQualifierInScope)
- SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
+ SS.setUnqualifiedLookups(UnqualifiedLookups);
+
while (!Qualifiers.empty()) {
NestedNameSpecifierLoc Q = Qualifiers.pop_back_val();
NestedNameSpecifier *QNNS = Q.getNestedNameSpecifier();
@@ -4411,8 +4394,9 @@ NestedNameSpecifierLoc TreeTransform<Derived>::TransformNestedNameSpecifierLoc(
Sema::NestedNameSpecInfo IdInfo(QNNS->getAsIdentifier(),
Q.getLocalBeginLoc(), Q.getLocalEndLoc(),
ObjectType);
- if (SemaRef.BuildCXXNestedNameSpecifier(/*Scope=*/nullptr, IdInfo, false,
- SS, FirstQualifierInScope, false))
+ if (SemaRef.BuildCXXNestedNameSpecifier(/*Scope=*/nullptr, IdInfo,
+ /*EnteringContext=*/false,
+ SS, /*ErrorRecoveryLookup=*/false))
return NestedNameSpecifierLoc();
break;
}
@@ -4450,8 +4434,7 @@ NestedNameSpecifierLoc TreeTransform<Derived>::TransformNestedNameSpecifierLoc(
case NestedNameSpecifier::TypeSpecWithTemplate:
case NestedNameSpecifier::TypeSpec: {
- TypeLoc TL = TransformTypeInObjectScope(Q.getTypeLoc(), ObjectType,
- FirstQualifierInScope, SS);
+ TypeLoc TL = TransformTypeInObjectScope(Q.getTypeLoc(), ObjectType, SS);
if (!TL)
return NestedNameSpecifierLoc();
@@ -4484,7 +4467,7 @@ NestedNameSpecifierLoc TreeTransform<Derived>::TransformNestedNameSpecifierLoc(
}
// The qualifier-in-scope and object type only apply to the leftmost entity.
- FirstQualifierInScope = nullptr;
+ SS.setUnqualifiedLookups(std::nullopt);
ObjectType = QualType();
}
@@ -4573,7 +4556,6 @@ TreeTransform<Derived>::TransformTemplateName(CXXScopeSpec &SS,
TemplateName Name,
SourceLocation NameLoc,
QualType ObjectType,
- NamedDecl *FirstQualifierInScope,
bool AllowInjectedClassName) {
if (QualifiedTemplateName *QTN = Name.getAsQualifiedTemplateName()) {
TemplateDecl *Template = QTN->getUnderlyingTemplate().getAsTemplateDecl();
@@ -4598,7 +4580,7 @@ TreeTransform<Derived>::TransformTemplateName(CXXScopeSpec &SS,
if (SS.getScopeRep()) {
// These apply to the scope specifier, not the template.
ObjectType = QualType();
- FirstQualifierInScope = nullptr;
+ SS.setUnqualifiedLookups(std::nullopt);
}
if (!getDerived().AlwaysRebuild() &&
@@ -4615,7 +4597,6 @@ TreeTransform<Derived>::TransformTemplateName(CXXScopeSpec &SS,
*DTN->getIdentifier(),
NameLoc,
ObjectType,
- FirstQualifierInScope,
AllowInjectedClassName);
}
@@ -5164,13 +5145,12 @@ template<typename Derived>
TypeLoc
TreeTransform<Derived>::TransformTypeInObjectScope(TypeLoc TL,
QualType ObjectType,
- NamedDecl *UnqualLookup,
CXXScopeSpec &SS) {
if (getDerived().AlreadyTransformed(TL.getType()))
return TL;
TypeSourceInfo *TSI =
- TransformTSIInObjectScope(TL, ObjectType, UnqualLookup, SS);
+ TransformTSIInObjectScope(TL, ObjectType, SS);
if (TSI)
return TSI->getTypeLoc();
return TypeLoc();
@@ -5180,35 +5160,29 @@ template<typename Derived>
TypeSourceInfo *
TreeTransform<Derived>::TransformTypeInObjectScope(TypeSourceInfo *TSInfo,
QualType ObjectType,
- NamedDecl *UnqualLookup,
CXXScopeSpec &SS) {
if (getDerived().AlreadyTransformed(TSInfo->getType()))
return TSInfo;
- return TransformTSIInObjectScope(TSInfo->getTypeLoc(), ObjectType,
- UnqualLookup, SS);
+ return TransformTSIInObjectScope(TSInfo->getTypeLoc(), ObjectType, SS);
}
template <typename Derived>
TypeSourceInfo *TreeTransform<Derived>::TransformTSIInObjectScope(
- TypeLoc TL, QualType ObjectType, NamedDecl *UnqualLookup,
- CXXScopeSpec &SS) {
+ TypeLoc TL, QualType ObjectType, CXXScopeSpec &SS) {
QualType T = TL.getType();
assert(!getDerived().AlreadyTransformed(T));
TypeLocBuilder TLB;
QualType Result;
- if (UnqualLookup)
- SS.setFoundFirstQualifierInScope(UnqualLookup);
-
if (isa<TemplateSpecializationType>(T)) {
TemplateSpecializationTypeLoc SpecTL =
TL.castAs<TemplateSpecializationTypeLoc>();
TemplateName Template = getDerived().TransformTemplateName(
SS, SpecTL.getTypePtr()->getTemplateName(), SpecTL.getTemplateNameLoc(),
- ObjectType, UnqualLookup, /*AllowInjectedClassName*/true);
+ ObjectType, /*AllowInjectedClassName=*/true);
if (Template.isNull())
return nullptr;
@@ -5223,8 +5197,8 @@ TypeSourceInfo *TreeTransform<Derived>::TransformTSIInObjectScope(
SpecTL.getTemplateKeywordLoc(),
*SpecTL.getTypePtr()->getIdentifier(),
SpecTL.getTemplateNameLoc(),
- ObjectType, UnqualLookup,
- /*AllowInjectedClassName*/true);
+ ObjectType,
+ /*AllowInjectedClassName=*/true);
if (Template.isNull())
return nullptr;
@@ -12367,7 +12341,8 @@ TreeTransform<Derived>::TransformMemberExpr(MemberExpr *E) {
// first-qualifier-in-scope here, just in case we had a dependent
// base (and therefore couldn't do the check) and a
// nested-name-qualifier (and therefore could do the lookup).
- NamedDecl *FirstQualifierInScope = nullptr;
+ ArrayRef<DeclAccessPair> UnqualifiedLookups;
+
DeclarationNameInfo MemberNameInfo = E->getMemberNameInfo();
if (MemberNameInfo.getName()) {
MemberNameInfo = getDerived().TransformDeclarationNameInfo(MemberNameInfo);
@@ -12384,7 +12359,7 @@ TreeTransform<Derived>::TransformMemberExpr(MemberExpr *E) {
FoundDecl,
(E->hasExplicitTemplateArgs()
? &TransArgs : nullptr),
- FirstQualifierInScope);
+ UnqualifiedLookups);
}
template<typename Derived>
@@ -13513,7 +13488,7 @@ TreeTransform<Derived>::TransformCXXPseudoDestructorExpr(
if (E->getDestroyedTypeInfo()) {
TypeSourceInfo *DestroyedTypeInfo
= getDerived().TransformTypeInObjectScope(E->getDestroyedTypeInfo(),
- ObjectType, nullptr, SS);
+ ObjectType, SS);
if (!DestroyedTypeInfo)
return ExprError();
Destroyed = DestroyedTypeInfo;
@@ -13539,7 +13514,7 @@ TreeTransform<Derived>::TransformCXXPseudoDestructorExpr(
if (E->getScopeTypeInfo()) {
CXXScopeSpec EmptySS;
ScopeTypeInfo = getDerived().TransformTypeInObjectScope(
- E->getScopeTypeInfo(), ObjectType, nullptr, EmptySS);
+ E->getScopeTypeInfo(), ObjectType, EmptySS);
if (!ScopeTypeInfo)
return ExprError();
}
@@ -14800,19 +14775,28 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
ObjectType = BaseType->castAs<PointerType>()->getPointeeType();
}
+ #if 0
// Transform the first part of the nested-name-specifier that qualifies
// the member name.
NamedDecl *FirstQualifierInScope
= getDerived().TransformFirstQualifierInScope(
E->getFirstQualifierFoundInScope(),
E->getQualifierLoc().getBeginLoc());
+ #endif
+
+ UnresolvedSet<4> UnqualifiedLookups;
+ for (auto D : E->unqualified_lookups()) {
+ if (NamedDecl *InstD = getDerived().TransformFirstQualifierInScope(
+ D.getDecl(), E->getQualifierLoc().getBeginLoc()))
+ UnqualifiedLookups.addDecl(InstD);
+ }
NestedNameSpecifierLoc QualifierLoc;
if (E->getQualifier()) {
QualifierLoc
= getDerived().TransformNestedNameSpecifierLoc(E->getQualifierLoc(),
ObjectType,
- FirstQualifierInScope);
+ UnqualifiedLookups.pairs());
if (!QualifierLoc)
return ExprError();
}
@@ -14836,7 +14820,7 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
BaseType == E->getBaseType() &&
QualifierLoc == E->getQualifierLoc() &&
NameInfo.getName() == E->getMember() &&
- FirstQualifierInScope == E->getFirstQualifierFoundInScope())
+ UnqualifiedLookups.pairs() == E->unqualified_lookups())
return E;
return getDerived().RebuildCXXDependentScopeMemberExpr(Base.get(),
@@ -14845,7 +14829,7 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
E->getOperatorLoc(),
QualifierLoc,
TemplateKWLoc,
- FirstQualifierInScope,
+ UnqualifiedLookups.pairs(),
NameInfo,
/*TemplateArgs*/nullptr);
}
@@ -14862,7 +14846,7 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
E->getOperatorLoc(),
QualifierLoc,
TemplateKWLoc,
- FirstQualifierInScope,
+ UnqualifiedLookups.pairs(),
NameInfo,
&TransArgs);
}
@@ -14925,11 +14909,11 @@ ExprResult TreeTransform<Derived>::TransformUnresolvedMemberExpr(
// first-qualifier-in-scope here, just in case we had a dependent
// base (and therefore couldn't do the check) and a
// nested-name-qualifier (and therefore could do the lookup).
- NamedDecl *FirstQualifierInScope = nullptr;
+ ArrayRef<DeclAccessPair> UnqualifiedLookups;
return getDerived().RebuildUnresolvedMemberExpr(
Base.get(), BaseType, Old->getOperatorLoc(), Old->isArrow(), QualifierLoc,
- TemplateKWLoc, FirstQualifierInScope, R,
+ TemplateKWLoc, UnqualifiedLookups, R,
(Old->hasExplicitTemplateArgs() ? &TransArgs : nullptr));
}
@@ -16293,13 +16277,10 @@ TreeTransform<Derived>::RebuildTemplateName(CXXScopeSpec &SS,
const IdentifierInfo &Name,
SourceLocation NameLoc,
QualType ObjectType,
- NamedDecl *FirstQualifierInScope,
bool AllowInjectedClassName) {
UnqualifiedId TemplateName;
TemplateName.setIdentifier(&Name, NameLoc);
Sema::TemplateTy Template;
- if (FirstQualifierInScope)
- SS.setFoundFirstQualifierInScope(FirstQualifierInScope);
getSema().ActOnTemplateName(/*Scope=*/nullptr, SS, TemplateKWLoc,
TemplateName, ParsedType::make(ObjectType),
/*EnteringContext=*/false, Template,
@@ -16454,10 +16435,9 @@ TreeTransform<Derived>::RebuildCXXPseudoDestructorExpr(Expr *Base,
return getSema().BuildMemberReferenceExpr(Base, BaseType,
OperatorLoc, isArrow,
SS, TemplateKWLoc,
- /*FIXME: FirstQualifier*/ nullptr,
NameInfo,
- /*TemplateArgs*/ nullptr,
- /*S*/nullptr);
+ /*TemplateArgs=*/nullptr,
+ /*S=*/nullptr);
}
template<typename Derived>
diff --git a/clang/lib/Serialization/ASTReaderStmt.cpp b/clang/lib/Serialization/ASTReaderStmt.cpp
index e23ceffb10bfe..901f8fb5fc071 100644
--- a/clang/lib/Serialization/ASTReaderStmt.cpp
+++ b/clang/lib/Serialization/ASTReaderStmt.cpp
@@ -1993,6 +1993,43 @@ void ASTStmtReader::VisitCXXDependentScopeMemberExpr(
CXXDependentScopeMemberExpr *E) {
VisitExpr(E);
+ CurrentUnpackingBits.emplace(Record.readInt());
+ bool HasQualifier = CurrentUnpackingBits->getNextBit();
+ bool HasTemplateInfo = CurrentUnpackingBits->getNextBit();
+ unsigned NumUnqualifiedLookups = Record.readInt();
+ unsigned NumTemplateArgs = Record.readInt();
+ E->CXXDependentScopeMemberExprBits.HasQualifier = HasQualifier;
+ E->CXXDependentScopeMemberExprBits.NumUnqualifiedLookups = NumUnqualifiedLookups;
+ E->CXXDependentScopeMemberExprBits.HasTemplateKWAndArgsInfo = HasTemplateInfo;
+
+ E->BaseType = Record.readType();
+ E->CXXDependentScopeMemberExprBits.IsArrow = CurrentUnpackingBits->getNextBit();
+
+ if (CurrentUnpackingBits->getNextBit())
+ E->Base = Record.readSubExpr();
+ else
+ E->Base = nullptr;
+
+ E->OperatorLoc = Record.readSourceLocation();
+ E->MemberNameInfo = Record.readDeclarationNameInfo();
+
+ if (HasQualifier)
+ new (E->getTrailingObjects<NestedNameSpecifierLoc>())
+ NestedNameSpecifierLoc(Record.readNestedNameSpecifierLoc());
+
+ for (unsigned I = 0; I != NumUnqualifiedLookups; ++I) {
+ auto *FoundD = Record.readDeclAs<NamedDecl>();
+ auto AS = (AccessSpecifier)Record.readInt();
+ E->getTrailingObjects<DeclAccessPair>()[I] = DeclAccessPair::make(FoundD, AS);;
+ }
+
+ if (HasTemplateInfo)
+ ReadTemplateKWAndArgsInfo(
+ *E->getTrailingObjects<ASTTemplateKWAndArgsInfo>(),
+ E->getTrailingObjects<TemplateArgumentLoc>(), NumTemplateArgs);
+
+
+ #if 0
unsigned NumTemplateArgs = Record.readInt();
CurrentUnpackingBits.emplace(Record.readInt());
bool HasTemplateKWAndArgsInfo = CurrentUnpackingBits->getNextBit();
@@ -2029,6 +2066,7 @@ void ASTStmtReader::VisitCXXDependentScopeMemberExpr(
*E->getTrailingObjects<NamedDecl *>() = readDeclAs<NamedDecl>();
E->MemberNameInfo = Record.readDeclarationNameInfo();
+ #endif
}
void
@@ -4075,6 +4113,8 @@ Stmt *ASTReader::ReadStmtFromStream(ModuleFile &F) {
break;
case EXPR_CXX_DEPENDENT_SCOPE_MEMBER: {
+
+ #if 0
unsigned NumTemplateArgs = Record[ASTStmtReader::NumExprFields];
BitsUnpacker DependentScopeMemberBits(
Record[ASTStmtReader::NumExprFields + 1]);
@@ -4082,9 +4122,16 @@ Stmt *ASTReader::ReadStmtFromStream(ModuleFile &F) {
bool HasFirstQualifierFoundInScope =
DependentScopeMemberBits.getNextBit();
+ #endif
+ BitsUnpacker DependentScopeMemberBits(Record[ASTStmtReader::NumExprFields]);
+ bool HasQualifier = DependentScopeMemberBits.getNextBit();
+ bool HasTemplateInfo = DependentScopeMemberBits.getNextBit();
+ unsigned NumUnqualifiedLookups = Record[ASTStmtReader::NumExprFields + 1];
+ unsigned NumTemplateArgs = Record[ASTStmtReader::NumExprFields + 2];
+
S = CXXDependentScopeMemberExpr::CreateEmpty(
- Context, HasTemplateKWAndArgsInfo, NumTemplateArgs,
- HasFirstQualifierFoundInScope);
+ Context, HasQualifier, NumUnqualifiedLookups,
+ HasTemplateInfo, NumTemplateArgs);
break;
}
diff --git a/clang/lib/Serialization/ASTWriterStmt.cpp b/clang/lib/Serialization/ASTWriterStmt.cpp
index ea499019c9d16..e16a8135368d5 100644
--- a/clang/lib/Serialization/ASTWriterStmt.cpp
+++ b/clang/lib/Serialization/ASTWriterStmt.cpp
@@ -1988,6 +1988,42 @@ void ASTStmtWriter::VisitCXXDependentScopeMemberExpr(
CXXDependentScopeMemberExpr *E) {
VisitExpr(E);
+ bool HasQualifier = E->hasQualifier();
+ unsigned NumUnqualifiedLookups = E->getNumUnqualifiedLookups();
+ bool HasTemplateInfo = E->hasTemplateKWAndArgsInfo();
+ unsigned NumTemplateArgs = E->getNumTemplateArgs();
+
+ // Write these first for easy access when deserializing, as they affect the
+ // size of the CXXDependentScopeMemberExpr.
+ CurrentPackingBits.updateBits();
+ CurrentPackingBits.addBit(HasQualifier);
+ CurrentPackingBits.addBit(HasTemplateInfo);
+ Record.push_back(NumUnqualifiedLookups);
+ Record.push_back(NumTemplateArgs);
+
+ Record.AddTypeRef(E->getBaseType());
+ CurrentPackingBits.addBit(E->isArrow());
+ CurrentPackingBits.addBit(!E->isImplicitAccess());
+ if (!E->isImplicitAccess())
+ Record.AddStmt(E->getBase());
+
+ Record.AddSourceLocation(E->getOperatorLoc());
+
+ Record.AddDeclarationNameInfo(E->MemberNameInfo);
+
+ if (HasQualifier)
+ Record.AddNestedNameSpecifierLoc(E->getQualifierLoc());
+
+ for (DeclAccessPair D : E->unqualified_lookups()) {
+ Record.AddDeclRef(D.getDecl());
+ Record.push_back(D.getAccess());
+ }
+
+ if (HasTemplateInfo)
+ AddTemplateKWAndArgsInfo(*E->getTrailingObjects<ASTTemplateKWAndArgsInfo>(),
+ E->getTrailingObjects<TemplateArgumentLoc>());
+
+ #if 0
// Don't emit anything here (or if you do you will have to update
// the corresponding deserialization function).
Record.push_back(E->getNumTemplateArgs());
@@ -2016,6 +2052,8 @@ void ASTStmtWriter::VisitCXXDependentScopeMemberExpr(
Record.AddDeclRef(E->getFirstQualifierFoundInScope());
Record.AddDeclarationNameInfo(E->MemberNameInfo);
+ #endif
+
Code = serialization::EXPR_CXX_DEPENDENT_SCOPE_MEMBER;
}
diff --git a/clang/test/SemaCXX/pseudo-destructors.cpp b/clang/test/SemaCXX/pseudo-destructors.cpp
index 55a96002be2ab..44dc9ce8b1520 100644
--- a/clang/test/SemaCXX/pseudo-destructors.cpp
+++ b/clang/test/SemaCXX/pseudo-destructors.cpp
@@ -22,21 +22,21 @@ void cv_test(const volatile T* cvt) {
void f(A* a, Foo *f, int *i, double *d, int ii) {
a->~A();
a->A::~A();
-
+
a->~foo(); // expected-error{{undeclared identifier 'foo' in destructor name}}
-
+
a->~Bar(); // expected-error{{destructor type 'Bar' (aka 'Foo') in object destruction expression does not match the type 'A' of the object being destroyed}}
-
+
f->~Bar();
f->~Foo();
i->~Bar(); // expected-error{{does not match}}
-
+
g().~Bar(); // expected-error{{non-scalar}}
-
+
f->::~Bar(); // expected-error {{not a structure or union}}
f->::Bar::~Bar();
f->N::~Wibble(); // expected-error{{'N' does not refer to a type}} expected-error{{'Wibble' does not refer to a type}}
-
+
f->Bar::~Bar(17, 42); // expected-error{{cannot have any arguments}}
i->~Integer();
@@ -148,12 +148,12 @@ namespace TwoPhaseLookup {
namespace Template {
template<typename T> struct Y {};
template<class U> using G = Y<U>;
- template<typename T> void f(T *p) { p->~G<int>(); } // expected-error {{no member named '~Y'}}
+ template<typename T> void f(T *p) { p->~G<int>(); } // expected-error {{no member named 'G'}}
void h1(Y<int> *p) { p->~G<int>(); }
- void h2(Y<int> *p) { f(p); }
+ void h2(Y<int> *p) { f(p); } // expected-note {{instantiation of}}
namespace N { template<typename T> struct G {}; }
void h3(N::G<int> *p) { p->~G<int>(); }
- void h4(N::G<int> *p) { f(p); } // expected-note {{instantiation of}}
+ void h4(N::G<int> *p) { f(p); }
}
namespace TemplateUndeclared {
>From 6d53c6b1b19c72fc438a16acb99609147746e489 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Fri, 31 May 2024 13:13:40 -0400
Subject: [PATCH 04/26] [FOLD] format
---
clang/include/clang/AST/ExprCXX.h | 26 +--
clang/include/clang/AST/Stmt.h | 4 +-
clang/include/clang/Sema/Sema.h | 14 +-
clang/lib/AST/ASTImporter.cpp | 1 -
clang/lib/AST/ExprCXX.cpp | 36 ++-
clang/lib/AST/ItaniumMangle.cpp | 35 ++-
clang/lib/Sema/SemaCXXScopeSpec.cpp | 9 +-
clang/lib/Sema/SemaCoroutine.cpp | 4 +-
clang/lib/Sema/SemaDeclCXX.cpp | 33 ++-
clang/lib/Sema/SemaExprMember.cpp | 50 ++--
clang/lib/Sema/SemaOverload.cpp | 11 +-
clang/lib/Sema/SemaStmtAsm.cpp | 5 +-
clang/lib/Sema/SemaTemplate.cpp | 2 +-
clang/lib/Sema/SemaTemplateInstantiate.cpp | 9 +-
clang/lib/Sema/TreeTransform.h | 260 ++++++++-------------
clang/lib/Serialization/ASTReaderStmt.cpp | 26 ++-
clang/lib/Serialization/ASTWriterStmt.cpp | 4 +-
17 files changed, 226 insertions(+), 303 deletions(-)
diff --git a/clang/include/clang/AST/ExprCXX.h b/clang/include/clang/AST/ExprCXX.h
index ce0004d0e0479..cb82b37aa6e49 100644
--- a/clang/include/clang/AST/ExprCXX.h
+++ b/clang/include/clang/AST/ExprCXX.h
@@ -3676,11 +3676,9 @@ class CXXUnresolvedConstructExpr final
/// an implicit access if a qualifier is provided.
class CXXDependentScopeMemberExpr final
: public Expr,
- private llvm::TrailingObjects<CXXDependentScopeMemberExpr,
- NestedNameSpecifierLoc,
- DeclAccessPair,
- ASTTemplateKWAndArgsInfo,
- TemplateArgumentLoc> {
+ private llvm::TrailingObjects<
+ CXXDependentScopeMemberExpr, NestedNameSpecifierLoc, DeclAccessPair,
+ ASTTemplateKWAndArgsInfo, TemplateArgumentLoc> {
friend class ASTStmtReader;
friend class ASTStmtWriter;
friend TrailingObjects;
@@ -3756,10 +3754,8 @@ class CXXDependentScopeMemberExpr final
public:
static CXXDependentScopeMemberExpr *
- Create(const ASTContext &Ctx, Expr *Base,
- QualType BaseType, bool IsArrow,
- SourceLocation OperatorLoc,
- NestedNameSpecifierLoc QualifierLoc,
+ Create(const ASTContext &Ctx, Expr *Base, QualType BaseType, bool IsArrow,
+ SourceLocation OperatorLoc, NestedNameSpecifierLoc QualifierLoc,
SourceLocation TemplateKWLoc,
ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationNameInfo MemberNameInfo,
@@ -3767,8 +3763,7 @@ class CXXDependentScopeMemberExpr final
static CXXDependentScopeMemberExpr *
CreateEmpty(const ASTContext &Ctx, bool HasQualifier,
- unsigned NumUnqualifiedLookups,
- bool HasTemplateKWAndArgsInfo,
+ unsigned NumUnqualifiedLookups, bool HasTemplateKWAndArgsInfo,
unsigned NumTemplateArgs);
/// True if this is an implicit access, i.e. one in which the
@@ -3794,9 +3789,7 @@ class CXXDependentScopeMemberExpr final
bool isArrow() const { return CXXDependentScopeMemberExprBits.IsArrow; }
/// Retrieve the location of the '->' or '.' operator.
- SourceLocation getOperatorLoc() const {
- return OperatorLoc;
- }
+ SourceLocation getOperatorLoc() const { return OperatorLoc; }
/// Determines whether this member expression had a nested-name-specifier
/// prior to the name of the member, e.g., x->Base::foo.
@@ -3819,8 +3812,7 @@ class CXXDependentScopeMemberExpr final
return getQualifierLoc().getNestedNameSpecifier();
}
-
- #if 0
+#if 0
/// Retrieve the first part of the nested-name-specifier that was
/// found in the scope of the member access expression when the member access
/// was initially parsed.
@@ -3837,7 +3829,7 @@ class CXXDependentScopeMemberExpr final
return nullptr;
return *getTrailingObjects<NamedDecl *>();
}
- #endif
+#endif
ArrayRef<DeclAccessPair> unqualified_lookups() const {
if (!getNumUnqualifiedLookups())
diff --git a/clang/include/clang/AST/Stmt.h b/clang/include/clang/AST/Stmt.h
index e0e5c8fb99dc3..6e6221ec15fdb 100644
--- a/clang/include/clang/AST/Stmt.h
+++ b/clang/include/clang/AST/Stmt.h
@@ -1030,12 +1030,12 @@ class alignas(void *) Stmt {
LLVM_PREFERRED_TYPE(bool)
unsigned HasTemplateKWAndArgsInfo : 1;
- #if 0
+#if 0
/// See getFirstQualifierFoundInScope() and the comment listing
/// the trailing objects.
LLVM_PREFERRED_TYPE(bool)
unsigned HasFirstQualifierFoundInScope : 1;
- #endif
+#endif
/// Number of declarations found by unqualified lookup for the
/// first component name of the nested-name-specifier.
unsigned NumUnqualifiedLookups;
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index e16b9bdff549e..a5e3f9bcf4f70 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -2802,7 +2802,8 @@ class Sema final : public SemaBase {
/// (e.g., Base::), perform name lookup for that identifier as a
/// nested-name-specifier within the given scope, and return the result of
/// that name lookup.
- bool LookupFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS, UnresolvedSetImpl &R);
+ bool LookupFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS,
+ UnresolvedSetImpl &R);
/// Keeps information about an identifier in a nested-name-spec.
///
@@ -8566,11 +8567,12 @@ class Sema final : public SemaBase {
const TemplateArgumentListInfo *TemplateArgs,
bool IsDefiniteInstance, const Scope *S);
- ExprResult ActOnDependentMemberExpr(
- Expr *Base, QualType BaseType, bool IsArrow, SourceLocation OpLoc,
- const CXXScopeSpec &SS, SourceLocation TemplateKWLoc,
- const DeclarationNameInfo &NameInfo,
- const TemplateArgumentListInfo *TemplateArgs);
+ ExprResult
+ ActOnDependentMemberExpr(Expr *Base, QualType BaseType, bool IsArrow,
+ SourceLocation OpLoc, const CXXScopeSpec &SS,
+ SourceLocation TemplateKWLoc,
+ const DeclarationNameInfo &NameInfo,
+ const TemplateArgumentListInfo *TemplateArgs);
/// The main callback when the parser finds something like
/// expression . [nested-name-specifier] identifier
diff --git a/clang/lib/AST/ASTImporter.cpp b/clang/lib/AST/ASTImporter.cpp
index a5a0f8cb022c8..9bb035c07b8ae 100644
--- a/clang/lib/AST/ASTImporter.cpp
+++ b/clang/lib/AST/ASTImporter.cpp
@@ -8440,7 +8440,6 @@ ExpectedStmt ASTNodeImporter::VisitCXXDependentScopeMemberExpr(
auto ToQualifierLoc = importChecked(Err, E->getQualifierLoc());
auto ToTemplateKeywordLoc = importChecked(Err, E->getTemplateKeywordLoc());
-
UnresolvedSet<8> ToUnqualifiedLookups;
for (auto D : E->unqualified_lookups())
if (auto ToDOrErr = import(D.getDecl()))
diff --git a/clang/lib/AST/ExprCXX.cpp b/clang/lib/AST/ExprCXX.cpp
index 6fc59693bf69e..19ce3a3c5d8f9 100644
--- a/clang/lib/AST/ExprCXX.cpp
+++ b/clang/lib/AST/ExprCXX.cpp
@@ -1497,8 +1497,7 @@ CXXDependentScopeMemberExpr::CXXDependentScopeMemberExpr(
Base(Base), BaseType(BaseType), OperatorLoc(OperatorLoc),
MemberNameInfo(MemberNameInfo) {
CXXDependentScopeMemberExprBits.IsArrow = IsArrow;
- CXXDependentScopeMemberExprBits.HasQualifier =
- QualifierLoc.hasQualifier();
+ CXXDependentScopeMemberExprBits.HasQualifier = QualifierLoc.hasQualifier();
CXXDependentScopeMemberExprBits.NumUnqualifiedLookups =
UnqualifiedLookups.size();
CXXDependentScopeMemberExprBits.HasTemplateKWAndArgsInfo =
@@ -1509,7 +1508,8 @@ CXXDependentScopeMemberExpr::CXXDependentScopeMemberExpr(
NestedNameSpecifierLoc(QualifierLoc);
std::uninitialized_copy_n(UnqualifiedLookups.data(),
- UnqualifiedLookups.size(), getTrailingObjects<DeclAccessPair>());
+ UnqualifiedLookups.size(),
+ getTrailingObjects<DeclAccessPair>());
if (TemplateArgs) {
auto Deps = TemplateArgumentDependence::None;
@@ -1529,8 +1529,7 @@ CXXDependentScopeMemberExpr::CXXDependentScopeMemberExpr(
bool HasTemplateKWAndArgsInfo)
: Expr(CXXDependentScopeMemberExprClass, Empty) {
CXXDependentScopeMemberExprBits.HasQualifier = HasQualifier;
- CXXDependentScopeMemberExprBits.NumUnqualifiedLookups =
- NumUnqualifiedLookups;
+ CXXDependentScopeMemberExprBits.NumUnqualifiedLookups = NumUnqualifiedLookups;
CXXDependentScopeMemberExprBits.HasTemplateKWAndArgsInfo =
HasTemplateKWAndArgsInfo;
}
@@ -1547,12 +1546,11 @@ CXXDependentScopeMemberExpr *CXXDependentScopeMemberExpr::Create(
bool HasTemplateKWAndArgsInfo =
(TemplateArgs != nullptr) || TemplateKWLoc.isValid();
unsigned NumTemplateArgs = TemplateArgs ? TemplateArgs->size() : 0;
- unsigned Size = totalSizeToAlloc<NestedNameSpecifierLoc,
- DeclAccessPair,
- ASTTemplateKWAndArgsInfo,
- TemplateArgumentLoc>(
- HasQualifier, NumUnqualifiedLookups,
- HasTemplateKWAndArgsInfo, NumTemplateArgs);
+ unsigned Size =
+ totalSizeToAlloc<NestedNameSpecifierLoc, DeclAccessPair,
+ ASTTemplateKWAndArgsInfo, TemplateArgumentLoc>(
+ HasQualifier, NumUnqualifiedLookups, HasTemplateKWAndArgsInfo,
+ NumTemplateArgs);
void *Mem = Ctx.Allocate(Size, alignof(CXXDependentScopeMemberExpr));
return new (Mem) CXXDependentScopeMemberExpr(
@@ -1566,16 +1564,16 @@ CXXDependentScopeMemberExpr *CXXDependentScopeMemberExpr::CreateEmpty(
assert(!NumTemplateArgs || HasTemplateKWAndArgsInfo);
assert(!NumUnqualifiedLookups || HasQualifier);
- unsigned Size = totalSizeToAlloc<NestedNameSpecifierLoc,
- DeclAccessPair,
- ASTTemplateKWAndArgsInfo,
- TemplateArgumentLoc>(
- HasQualifier, NumUnqualifiedLookups,
- HasTemplateKWAndArgsInfo, NumTemplateArgs);
+ unsigned Size =
+ totalSizeToAlloc<NestedNameSpecifierLoc, DeclAccessPair,
+ ASTTemplateKWAndArgsInfo, TemplateArgumentLoc>(
+ HasQualifier, NumUnqualifiedLookups, HasTemplateKWAndArgsInfo,
+ NumTemplateArgs);
void *Mem = Ctx.Allocate(Size, alignof(CXXDependentScopeMemberExpr));
- return new (Mem) CXXDependentScopeMemberExpr(
- EmptyShell(), HasQualifier, NumUnqualifiedLookups, HasTemplateKWAndArgsInfo);
+ return new (Mem) CXXDependentScopeMemberExpr(EmptyShell(), HasQualifier,
+ NumUnqualifiedLookups,
+ HasTemplateKWAndArgsInfo);
}
CXXThisExpr *CXXThisExpr::Create(const ASTContext &Ctx, SourceLocation L,
diff --git a/clang/lib/AST/ItaniumMangle.cpp b/clang/lib/AST/ItaniumMangle.cpp
index a15fc9cba309b..f14c4762bee6f 100644
--- a/clang/lib/AST/ItaniumMangle.cpp
+++ b/clang/lib/AST/ItaniumMangle.cpp
@@ -597,8 +597,7 @@ class CXXNameMangler {
ArrayRef<DeclAccessPair> UnqualifiedLookups,
DeclarationName name,
const TemplateArgumentLoc *TemplateArgs,
- unsigned NumTemplateArgs,
- unsigned knownArity);
+ unsigned NumTemplateArgs, unsigned knownArity);
void mangleCastExpression(const Expr *E, StringRef CastEncoding);
void mangleInitListElements(const InitListExpr *InitList);
void mangleRequirement(SourceLocation RequiresExprLoc,
@@ -4496,14 +4495,11 @@ void CXXNameMangler::mangleMemberExprBase(const Expr *Base, bool IsArrow) {
}
/// Mangles a member expression.
-void CXXNameMangler::mangleMemberExpr(const Expr *base,
- bool isArrow,
- NestedNameSpecifier *qualifier,
- ArrayRef<DeclAccessPair> UnqualifiedLookups,
- DeclarationName member,
- const TemplateArgumentLoc *TemplateArgs,
- unsigned NumTemplateArgs,
- unsigned arity) {
+void CXXNameMangler::mangleMemberExpr(
+ const Expr *base, bool isArrow, NestedNameSpecifier *qualifier,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups, DeclarationName member,
+ const TemplateArgumentLoc *TemplateArgs, unsigned NumTemplateArgs,
+ unsigned arity) {
// <expression> ::= dt <expression> <unresolved-name>
// ::= pt <expression> <unresolved-name>
if (base)
@@ -4985,11 +4981,9 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity,
case Expr::MemberExprClass: {
NotPrimaryExpr();
const MemberExpr *ME = cast<MemberExpr>(E);
- mangleMemberExpr(ME->getBase(), ME->isArrow(),
- ME->getQualifier(), std::nullopt,
- ME->getMemberDecl()->getDeclName(),
- ME->getTemplateArgs(), ME->getNumTemplateArgs(),
- Arity);
+ mangleMemberExpr(ME->getBase(), ME->isArrow(), ME->getQualifier(),
+ std::nullopt, ME->getMemberDecl()->getDeclName(),
+ ME->getTemplateArgs(), ME->getNumTemplateArgs(), Arity);
break;
}
@@ -4998,9 +4992,8 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity,
const UnresolvedMemberExpr *ME = cast<UnresolvedMemberExpr>(E);
mangleMemberExpr(ME->isImplicitAccess() ? nullptr : ME->getBase(),
ME->isArrow(), ME->getQualifier(), std::nullopt,
- ME->getMemberName(),
- ME->getTemplateArgs(), ME->getNumTemplateArgs(),
- Arity);
+ ME->getMemberName(), ME->getTemplateArgs(),
+ ME->getNumTemplateArgs(), Arity);
break;
}
@@ -5010,10 +5003,8 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity,
= cast<CXXDependentScopeMemberExpr>(E);
mangleMemberExpr(ME->isImplicitAccess() ? nullptr : ME->getBase(),
ME->isArrow(), ME->getQualifier(),
- ME->unqualified_lookups(),
- ME->getMember(),
- ME->getTemplateArgs(), ME->getNumTemplateArgs(),
- Arity);
+ ME->unqualified_lookups(), ME->getMember(),
+ ME->getTemplateArgs(), ME->getNumTemplateArgs(), Arity);
break;
}
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index b0b5a02ee0bdf..5a2afc60982d1 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -356,7 +356,12 @@ bool Sema::isAcceptableNestedNameSpecifier(const NamedDecl *SD,
return false;
}
-bool Sema::LookupFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS, UnresolvedSetImpl &R) {
+/// If the given nested-name-specifier begins with a bare identifier
+/// (e.g., Base::), perform name lookup for that identifier as a
+/// nested-name-specifier within the given scope, and return the result of that
+/// name lookup.
+bool Sema::LookupFirstQualifierInScope(Scope *S, NestedNameSpecifier *NNS,
+ UnresolvedSetImpl &R) {
if (!S)
return false;
@@ -468,7 +473,7 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
if (S) {
LookupName(Found, S);
} else if (LookupFirstQualifierInScope &&
- !SS.getUnqualifiedLookups().empty()) {
+ !SS.getUnqualifiedLookups().empty()) {
Found.addAllDecls(SS.getUnqualifiedLookups());
Found.resolveKind();
}
diff --git a/clang/lib/Sema/SemaCoroutine.cpp b/clang/lib/Sema/SemaCoroutine.cpp
index dbe0f0cf11b90..fa0eb1d2afbee 100644
--- a/clang/lib/Sema/SemaCoroutine.cpp
+++ b/clang/lib/Sema/SemaCoroutine.cpp
@@ -306,8 +306,8 @@ static ExprResult buildMemberCall(Sema &S, Expr *Base, SourceLocation Loc,
// FIXME: Fix BuildMemberReferenceExpr to take a const CXXScopeSpec&.
CXXScopeSpec SS;
ExprResult Result = S.BuildMemberReferenceExpr(
- Base, Base->getType(), Loc, /*IsPtr=*/false, SS,
- SourceLocation(), NameInfo, /*TemplateArgs=*/nullptr,
+ Base, Base->getType(), Loc, /*IsPtr=*/false, SS, SourceLocation(),
+ NameInfo, /*TemplateArgs=*/nullptr,
/*Scope=*/nullptr);
if (Result.isInvalid())
return ExprError();
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index 5763d9c03ef35..490cd6e864c43 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -4903,15 +4903,12 @@ BuildImplicitMemberInitializer(Sema &SemaRef, CXXConstructorDecl *Constructor,
MemberLookup.addDecl(Indirect ? cast<ValueDecl>(Indirect)
: cast<ValueDecl>(Field), AS_public);
MemberLookup.resolveKind();
- ExprResult CtorArg
- = SemaRef.BuildMemberReferenceExpr(MemberExprBase,
- ParamType, Loc,
- /*IsArrow=*/false,
- SS,
- /*TemplateKWLoc=*/SourceLocation(),
- MemberLookup,
- /*TemplateArgs=*/nullptr,
- /*S=*/nullptr);
+ ExprResult CtorArg = SemaRef.BuildMemberReferenceExpr(
+ MemberExprBase, ParamType, Loc,
+ /*IsArrow=*/false, SS,
+ /*TemplateKWLoc=*/SourceLocation(), MemberLookup,
+ /*TemplateArgs=*/nullptr,
+ /*S=*/nullptr);
if (CtorArg.isInvalid())
return true;
@@ -14337,9 +14334,10 @@ class MemberBuilder: public ExprBuilder {
public:
Expr *build(Sema &S, SourceLocation Loc) const override {
return assertNotNull(S.BuildMemberReferenceExpr(
- Builder.build(S, Loc), Type, Loc, IsArrow, SS,
- /*TemplateKwLoc=*/SourceLocation(), MemberLookup,
- /*TemplateArgs=*/nullptr, /*S=*/nullptr).get());
+ Builder.build(S, Loc), Type, Loc, IsArrow, SS,
+ /*TemplateKwLoc=*/SourceLocation(), MemberLookup,
+ /*TemplateArgs=*/nullptr, /*S=*/nullptr)
+ .get());
}
MemberBuilder(const ExprBuilder &Builder, QualType Type, bool IsArrow,
@@ -14545,12 +14543,11 @@ buildSingleCopyAssignRecursively(Sema &S, SourceLocation Loc, QualType T,
Loc);
// Create the reference to operator=.
- ExprResult OpEqualRef
- = S.BuildMemberReferenceExpr(To.build(S, Loc), T, Loc, /*IsArrow=*/false,
- SS, /*TemplateKWLoc=*/SourceLocation(),
- OpLookup,
- /*TemplateArgs=*/nullptr, /*S*/nullptr,
- /*SuppressQualifierCheck=*/true);
+ ExprResult OpEqualRef = S.BuildMemberReferenceExpr(
+ To.build(S, Loc), T, Loc, /*IsArrow=*/false, SS,
+ /*TemplateKWLoc=*/SourceLocation(), OpLookup,
+ /*TemplateArgs=*/nullptr, /*S*/ nullptr,
+ /*SuppressQualifierCheck=*/true);
if (OpEqualRef.isInvalid())
return StmtError();
diff --git a/clang/lib/Sema/SemaExprMember.cpp b/clang/lib/Sema/SemaExprMember.cpp
index 7eddcbb231d60..c4ade5b98102b 100644
--- a/clang/lib/Sema/SemaExprMember.cpp
+++ b/clang/lib/Sema/SemaExprMember.cpp
@@ -552,9 +552,8 @@ static Decl *FindGetterSetterNameDecl(const ObjCObjectPointerType *QIdTy,
}
ExprResult
-Sema::ActOnDependentMemberExpr(Expr *BaseExpr, QualType BaseType,
- bool IsArrow, SourceLocation OpLoc,
- const CXXScopeSpec &SS,
+Sema::ActOnDependentMemberExpr(Expr *BaseExpr, QualType BaseType, bool IsArrow,
+ SourceLocation OpLoc, const CXXScopeSpec &SS,
SourceLocation TemplateKWLoc,
const DeclarationNameInfo &NameInfo,
const TemplateArgumentListInfo *TemplateArgs) {
@@ -826,11 +825,9 @@ ExprResult Sema::BuildMemberReferenceExpr(
BaseType = Base->getType();
}
- return BuildMemberReferenceExpr(Base, BaseType,
- OpLoc, IsArrow, SS, TemplateKWLoc,
- R, TemplateArgs, S,
- /*SuppressQualifierCheck=*/false,
- ExtraArgs);
+ return BuildMemberReferenceExpr(Base, BaseType, OpLoc, IsArrow, SS,
+ TemplateKWLoc, R, TemplateArgs, S,
+ /*SuppressQualifierCheck=*/false, ExtraArgs);
}
ExprResult
@@ -968,16 +965,11 @@ static bool IsInFnTryBlockHandler(const Scope *S) {
return false;
}
-ExprResult
-Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
- SourceLocation OpLoc, bool IsArrow,
- const CXXScopeSpec &SS,
- SourceLocation TemplateKWLoc,
- LookupResult &R,
- const TemplateArgumentListInfo *TemplateArgs,
- const Scope *S,
- bool SuppressQualifierCheck,
- ActOnMemberAccessExtraArgs *ExtraArgs) {
+ExprResult Sema::BuildMemberReferenceExpr(
+ Expr *BaseExpr, QualType BaseExprType, SourceLocation OpLoc, bool IsArrow,
+ const CXXScopeSpec &SS, SourceLocation TemplateKWLoc, LookupResult &R,
+ const TemplateArgumentListInfo *TemplateArgs, const Scope *S,
+ bool SuppressQualifierCheck, ActOnMemberAccessExtraArgs *ExtraArgs) {
assert(!SS.isInvalid() && "nested-name-specifier cannot be invalid");
// If the member wasn't found in the current instantiation, or if the
// arrow operator was used with a dependent non-pointer object expression,
@@ -1193,9 +1185,9 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
// Non-dependent member, but dependent template arguments.
if (!VDecl.get())
- return ActOnDependentMemberExpr(
- BaseExpr, BaseExpr->getType(), IsArrow, OpLoc, SS, TemplateKWLoc,
- MemberNameInfo, TemplateArgs);
+ return ActOnDependentMemberExpr(BaseExpr, BaseExpr->getType(), IsArrow,
+ OpLoc, SS, TemplateKWLoc, MemberNameInfo,
+ TemplateArgs);
VarDecl *Var = cast<VarDecl>(VDecl.get());
if (!Var->getTemplateSpecializationKind())
@@ -1769,7 +1761,8 @@ ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
return ExprError(Diag(OpLoc, diag::err_hlsl_operator_unsupported) << 2);
UnresolvedSet<4> UnqualifiedLookups;
- if (SS.isValid() && LookupFirstQualifierInScope(S, SS.getScopeRep(), UnqualifiedLookups)) {
+ if (SS.isValid() &&
+ LookupFirstQualifierInScope(S, SS.getScopeRep(), UnqualifiedLookups)) {
SS.setUnqualifiedLookups(UnqualifiedLookups.pairs());
}
// This is a postfix expression, so get rid of ParenListExprs.
@@ -1779,8 +1772,8 @@ ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
ActOnMemberAccessExtraArgs ExtraArgs = {S, Id, ObjCImpDecl};
ExprResult Res = BuildMemberReferenceExpr(
- Base, Base->getType(), OpLoc, IsArrow, SS, TemplateKWLoc,
- NameInfo, TemplateArgs, S, &ExtraArgs);
+ Base, Base->getType(), OpLoc, IsArrow, SS, TemplateKWLoc, NameInfo,
+ TemplateArgs, S, &ExtraArgs);
if (!Res.isInvalid() && isa<MemberExpr>(Res.get()))
CheckMemberAccessOfNoDeref(cast<MemberExpr>(Res.get()));
@@ -1924,9 +1917,8 @@ Sema::BuildImplicitMemberExpr(const CXXScopeSpec &SS,
baseExpr = BuildCXXThisExpr(loc, ThisTy, /*IsImplicit=*/true);
}
- return BuildMemberReferenceExpr(
- baseExpr, ThisTy,
- /*OpLoc=*/SourceLocation(),
- /*IsArrow=*/!getLangOpts().HLSL, SS,
- TemplateKWLoc, R, TemplateArgs, S);
+ return BuildMemberReferenceExpr(baseExpr, ThisTy,
+ /*OpLoc=*/SourceLocation(),
+ /*IsArrow=*/!getLangOpts().HLSL, SS,
+ TemplateKWLoc, R, TemplateArgs, S);
}
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index c82980b94d3e7..f49635aa445a6 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -16043,12 +16043,11 @@ Sema::BuildForRangeBeginEndCall(SourceLocation Loc,
CandidateSet->clear(OverloadCandidateSet::CSK_Normal);
if (!MemberLookup.empty()) {
- ExprResult MemberRef =
- BuildMemberReferenceExpr(Range, Range->getType(), Loc,
- /*IsPtr=*/false, /*SS=*/CXXScopeSpec(),
- /*TemplateKWLoc=*/SourceLocation(),
- MemberLookup,
- /*TemplateArgs=*/nullptr, S);
+ ExprResult MemberRef = BuildMemberReferenceExpr(
+ Range, Range->getType(), Loc,
+ /*IsPtr=*/false, /*SS=*/CXXScopeSpec(),
+ /*TemplateKWLoc=*/SourceLocation(), MemberLookup,
+ /*TemplateArgs=*/nullptr, S);
if (MemberRef.isInvalid()) {
*CallExpr = ExprError();
return FRS_DiagnosticIssued;
diff --git a/clang/lib/Sema/SemaStmtAsm.cpp b/clang/lib/Sema/SemaStmtAsm.cpp
index 9b1e49620173d..da2e99b6bc00c 100644
--- a/clang/lib/Sema/SemaStmtAsm.cpp
+++ b/clang/lib/Sema/SemaStmtAsm.cpp
@@ -900,7 +900,8 @@ Sema::LookupInlineAsmVarDeclField(Expr *E, StringRef Member,
return CXXDependentScopeMemberExpr::Create(
Context, E, T, /*IsArrow=*/false, AsmLoc, NestedNameSpecifierLoc(),
SourceLocation(),
- /*UnqualifiedLookups=*/std::nullopt, NameInfo, /*TemplateArgs=*/nullptr);
+ /*UnqualifiedLookups=*/std::nullopt, NameInfo,
+ /*TemplateArgs=*/nullptr);
}
const RecordType *RT = T->getAs<RecordType>();
@@ -924,7 +925,7 @@ Sema::LookupInlineAsmVarDeclField(Expr *E, StringRef Member,
// Make an Expr to thread through OpDecl.
ExprResult Result = BuildMemberReferenceExpr(
E, E->getType(), AsmLoc, /*IsArrow=*/false, /*SS=*/CXXScopeSpec(),
- /*TemplateKWLoc*/SourceLocation(), FieldResult,
+ /*TemplateKWLoc*/ SourceLocation(), FieldResult,
/*TemplateArgs=*/nullptr, /*S=*/nullptr);
return Result;
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index 7c8dc59306071..b749f5c814a40 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -472,7 +472,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
if (S) {
LookupName(Found, S);
} else if (LookupFirstQualifierInScope &&
- !SS.getUnqualifiedLookups().empty()) {
+ !SS.getUnqualifiedLookups().empty()) {
Found.addAllDecls(SS.getUnqualifiedLookups());
Found.resolveKind();
}
diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp
index c12a56bf4a7fe..89d767b323011 100644
--- a/clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -1515,11 +1515,10 @@ namespace {
NestedNameSpecifierLoc QualifierLoc,
QualType T);
- TemplateName
- TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
- SourceLocation NameLoc,
- QualType ObjectType = QualType(),
- bool AllowInjectedClassName = false);
+ TemplateName TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
+ SourceLocation NameLoc,
+ QualType ObjectType = QualType(),
+ bool AllowInjectedClassName = false);
const CXXAssumeAttr *TransformCXXAssumeAttr(const CXXAssumeAttr *AA);
const LoopHintAttr *TransformLoopHintAttr(const LoopHintAttr *LH);
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index a24debd6d9fad..652425c3c3b47 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -541,10 +541,9 @@ class TreeTransform {
/// By default, transforms all of the types and declarations within the
/// nested-name-specifier. Subclasses may override this function to provide
/// alternate behavior.
- NestedNameSpecifierLoc
- TransformNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS,
- QualType ObjectType = QualType(),
- ArrayRef<DeclAccessPair> UnqualifiedLookups = std::nullopt);
+ NestedNameSpecifierLoc TransformNestedNameSpecifierLoc(
+ NestedNameSpecifierLoc NNS, QualType ObjectType = QualType(),
+ ArrayRef<DeclAccessPair> UnqualifiedLookups = std::nullopt);
/// Transform the given declaration name.
///
@@ -585,11 +584,10 @@ class TreeTransform {
/// By default, transforms the template name by transforming the declarations
/// and nested-name-specifiers that occur within the template name.
/// Subclasses may override this function to provide alternate behavior.
- TemplateName
- TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
- SourceLocation NameLoc,
- QualType ObjectType = QualType(),
- bool AllowInjectedClassName = false);
+ TemplateName TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
+ SourceLocation NameLoc,
+ QualType ObjectType = QualType(),
+ bool AllowInjectedClassName = false);
/// Transform the given template argument.
///
@@ -1139,8 +1137,7 @@ class TreeTransform {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
TemplateName InstName = getDerived().RebuildTemplateName(
- SS, TemplateKWLoc, *Name, NameLoc, QualType(),
- AllowInjectedClassName);
+ SS, TemplateKWLoc, *Name, NameLoc, QualType(), AllowInjectedClassName);
if (InstName.isNull())
return QualType();
@@ -2847,15 +2844,14 @@ class TreeTransform {
///
/// By default, performs semantic analysis to build the new expression.
/// Subclasses may override this routine to provide different behavior.
- ExprResult RebuildMemberExpr(Expr *Base, SourceLocation OpLoc,
- bool isArrow,
- NestedNameSpecifierLoc QualifierLoc,
- SourceLocation TemplateKWLoc,
- const DeclarationNameInfo &MemberNameInfo,
- ValueDecl *Member,
- NamedDecl *FoundDecl,
- const TemplateArgumentListInfo *ExplicitTemplateArgs,
- ArrayRef<DeclAccessPair> UnqualifiedLookups) {
+ ExprResult
+ RebuildMemberExpr(Expr *Base, SourceLocation OpLoc, bool isArrow,
+ NestedNameSpecifierLoc QualifierLoc,
+ SourceLocation TemplateKWLoc,
+ const DeclarationNameInfo &MemberNameInfo,
+ ValueDecl *Member, NamedDecl *FoundDecl,
+ const TemplateArgumentListInfo *ExplicitTemplateArgs,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups) {
ExprResult BaseResult = getSema().PerformMemberExprBaseConversion(Base,
isArrow);
if (!Member->getDeclName()) {
@@ -2922,9 +2918,9 @@ class TreeTransform {
}
return getSema().BuildMemberReferenceExpr(Base, BaseType, OpLoc, isArrow,
- SS, TemplateKWLoc,
- R, ExplicitTemplateArgs,
- /*S*/nullptr);
+ SS, TemplateKWLoc, R,
+ ExplicitTemplateArgs,
+ /*S*/ nullptr);
}
/// Build a new binary operator expression.
@@ -2999,7 +2995,7 @@ class TreeTransform {
return getSema().BuildMemberReferenceExpr(
Base, Base->getType(), OpLoc, IsArrow, SS,
/*TemplateKWLoc=*/SourceLocation(), NameInfo,
- /*TemplateArgs=*/ nullptr, /*S=*/nullptr);
+ /*TemplateArgs=*/nullptr, /*S=*/nullptr);
}
/// Build a new initializer list expression.
@@ -3567,46 +3563,37 @@ class TreeTransform {
///
/// By default, performs semantic analysis to build the new expression.
/// Subclasses may override this routine to provide different behavior.
- ExprResult RebuildCXXDependentScopeMemberExpr(Expr *BaseE,
- QualType BaseType,
- bool IsArrow,
- SourceLocation OperatorLoc,
- NestedNameSpecifierLoc QualifierLoc,
- SourceLocation TemplateKWLoc,
- ArrayRef<DeclAccessPair> UnqualifiedLookups,
- const DeclarationNameInfo &MemberNameInfo,
- const TemplateArgumentListInfo *TemplateArgs) {
+ ExprResult RebuildCXXDependentScopeMemberExpr(
+ Expr *BaseE, QualType BaseType, bool IsArrow, SourceLocation OperatorLoc,
+ NestedNameSpecifierLoc QualifierLoc, SourceLocation TemplateKWLoc,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups,
+ const DeclarationNameInfo &MemberNameInfo,
+ const TemplateArgumentListInfo *TemplateArgs) {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
SS.setUnqualifiedLookups(UnqualifiedLookups);
- return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType,
- OperatorLoc, IsArrow,
- SS, TemplateKWLoc,
- MemberNameInfo,
- TemplateArgs, /*S=*/nullptr);
+ return SemaRef.BuildMemberReferenceExpr(
+ BaseE, BaseType, OperatorLoc, IsArrow, SS, TemplateKWLoc,
+ MemberNameInfo, TemplateArgs, /*S=*/nullptr);
}
/// Build a new member reference expression.
///
/// By default, performs semantic analysis to build the new expression.
/// Subclasses may override this routine to provide different behavior.
- ExprResult RebuildUnresolvedMemberExpr(Expr *BaseE, QualType BaseType,
- SourceLocation OperatorLoc,
- bool IsArrow,
- NestedNameSpecifierLoc QualifierLoc,
- SourceLocation TemplateKWLoc,
- ArrayRef<DeclAccessPair> UnqualifiedLookups,
- LookupResult &R,
- const TemplateArgumentListInfo *TemplateArgs) {
+ ExprResult RebuildUnresolvedMemberExpr(
+ Expr *BaseE, QualType BaseType, SourceLocation OperatorLoc, bool IsArrow,
+ NestedNameSpecifierLoc QualifierLoc, SourceLocation TemplateKWLoc,
+ ArrayRef<DeclAccessPair> UnqualifiedLookups, LookupResult &R,
+ const TemplateArgumentListInfo *TemplateArgs) {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
SS.setUnqualifiedLookups(UnqualifiedLookups);
- return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType,
- OperatorLoc, IsArrow,
- SS, TemplateKWLoc,
- R, TemplateArgs, /*S=*/nullptr);
+ return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType, OperatorLoc,
+ IsArrow, SS, TemplateKWLoc, R,
+ TemplateArgs, /*S=*/nullptr);
}
/// Build a new noexcept expression.
@@ -3841,13 +3828,12 @@ class TreeTransform {
SourceLocation PropertyLoc) {
CXXScopeSpec SS;
DeclarationNameInfo NameInfo(Property->getDeclName(), PropertyLoc);
- return getSema().BuildMemberReferenceExpr(BaseArg, BaseArg->getType(),
- /*FIXME:*/PropertyLoc,
- /*IsArrow=*/false,
- SS, /*TemplateKWLoc=*/SourceLocation(),
- NameInfo,
- /*TemplateArgs=*/nullptr,
- /*S=*/nullptr);
+ return getSema().BuildMemberReferenceExpr(
+ BaseArg, BaseArg->getType(),
+ /*FIXME:*/ PropertyLoc,
+ /*IsArrow=*/false, SS, /*TemplateKWLoc=*/SourceLocation(), NameInfo,
+ /*TemplateArgs=*/nullptr,
+ /*S=*/nullptr);
}
/// Build a new Objective-C property reference expression.
@@ -3874,12 +3860,11 @@ class TreeTransform {
SourceLocation OpLoc, bool IsArrow) {
CXXScopeSpec SS;
DeclarationNameInfo NameInfo(&getSema().Context.Idents.get("isa"), IsaLoc);
- return getSema().BuildMemberReferenceExpr(BaseArg, BaseArg->getType(),
- OpLoc, IsArrow,
- SS, /*TemplateKWLoc=*/SourceLocation(),
- NameInfo,
- /*TemplateArgs=*/nullptr,
- /*S=*/nullptr);
+ return getSema().BuildMemberReferenceExpr(
+ BaseArg, BaseArg->getType(), OpLoc, IsArrow, SS,
+ /*TemplateKWLoc=*/SourceLocation(), NameInfo,
+ /*TemplateArgs=*/nullptr,
+ /*S=*/nullptr);
}
/// Build a new shuffle vector expression.
@@ -4044,16 +4029,14 @@ class TreeTransform {
}
private:
- TypeLoc TransformTypeInObjectScope(TypeLoc TL,
- QualType ObjectType,
+ TypeLoc TransformTypeInObjectScope(TypeLoc TL, QualType ObjectType,
CXXScopeSpec &SS);
TypeSourceInfo *TransformTypeInObjectScope(TypeSourceInfo *TSInfo,
QualType ObjectType,
CXXScopeSpec &SS);
- TypeSourceInfo *TransformTSIInObjectScope(TypeLoc TL,
- QualType ObjectType,
+ TypeSourceInfo *TransformTSIInObjectScope(TypeLoc TL, QualType ObjectType,
CXXScopeSpec &SS);
QualType TransformDependentNameType(TypeLocBuilder &TLB,
@@ -4395,8 +4378,8 @@ NestedNameSpecifierLoc TreeTransform<Derived>::TransformNestedNameSpecifierLoc(
Q.getLocalBeginLoc(), Q.getLocalEndLoc(),
ObjectType);
if (SemaRef.BuildCXXNestedNameSpecifier(/*Scope=*/nullptr, IdInfo,
- /*EnteringContext=*/false,
- SS, /*ErrorRecoveryLookup=*/false))
+ /*EnteringContext=*/false, SS,
+ /*ErrorRecoveryLookup=*/false))
return NestedNameSpecifierLoc();
break;
}
@@ -4550,13 +4533,10 @@ ::TransformDeclarationNameInfo(const DeclarationNameInfo &NameInfo) {
llvm_unreachable("Unknown name kind.");
}
-template<typename Derived>
-TemplateName
-TreeTransform<Derived>::TransformTemplateName(CXXScopeSpec &SS,
- TemplateName Name,
- SourceLocation NameLoc,
- QualType ObjectType,
- bool AllowInjectedClassName) {
+template <typename Derived>
+TemplateName TreeTransform<Derived>::TransformTemplateName(
+ CXXScopeSpec &SS, TemplateName Name, SourceLocation NameLoc,
+ QualType ObjectType, bool AllowInjectedClassName) {
if (QualifiedTemplateName *QTN = Name.getAsQualifiedTemplateName()) {
TemplateDecl *Template = QTN->getUnderlyingTemplate().getAsTemplateDecl();
assert(Template && "qualified template name must refer to a template");
@@ -4592,12 +4572,9 @@ TreeTransform<Derived>::TransformTemplateName(CXXScopeSpec &SS,
SourceLocation TemplateKWLoc = NameLoc;
if (DTN->isIdentifier()) {
- return getDerived().RebuildTemplateName(SS,
- TemplateKWLoc,
- *DTN->getIdentifier(),
- NameLoc,
- ObjectType,
- AllowInjectedClassName);
+ return getDerived().RebuildTemplateName(
+ SS, TemplateKWLoc, *DTN->getIdentifier(), NameLoc, ObjectType,
+ AllowInjectedClassName);
}
return getDerived().RebuildTemplateName(SS, TemplateKWLoc,
@@ -5141,26 +5118,22 @@ QualType TreeTransform<Derived>::RebuildQualifiedType(QualType T,
return SemaRef.BuildQualifiedType(T, Loc, Quals);
}
-template<typename Derived>
-TypeLoc
-TreeTransform<Derived>::TransformTypeInObjectScope(TypeLoc TL,
- QualType ObjectType,
- CXXScopeSpec &SS) {
+template <typename Derived>
+TypeLoc TreeTransform<Derived>::TransformTypeInObjectScope(TypeLoc TL,
+ QualType ObjectType,
+ CXXScopeSpec &SS) {
if (getDerived().AlreadyTransformed(TL.getType()))
return TL;
- TypeSourceInfo *TSI =
- TransformTSIInObjectScope(TL, ObjectType, SS);
+ TypeSourceInfo *TSI = TransformTSIInObjectScope(TL, ObjectType, SS);
if (TSI)
return TSI->getTypeLoc();
return TypeLoc();
}
-template<typename Derived>
-TypeSourceInfo *
-TreeTransform<Derived>::TransformTypeInObjectScope(TypeSourceInfo *TSInfo,
- QualType ObjectType,
- CXXScopeSpec &SS) {
+template <typename Derived>
+TypeSourceInfo *TreeTransform<Derived>::TransformTypeInObjectScope(
+ TypeSourceInfo *TSInfo, QualType ObjectType, CXXScopeSpec &SS) {
if (getDerived().AlreadyTransformed(TSInfo->getType()))
return TSInfo;
@@ -5192,13 +5165,11 @@ TypeSourceInfo *TreeTransform<Derived>::TransformTSIInObjectScope(
DependentTemplateSpecializationTypeLoc SpecTL =
TL.castAs<DependentTemplateSpecializationTypeLoc>();
- TemplateName Template
- = getDerived().RebuildTemplateName(SS,
- SpecTL.getTemplateKeywordLoc(),
- *SpecTL.getTypePtr()->getIdentifier(),
- SpecTL.getTemplateNameLoc(),
- ObjectType,
- /*AllowInjectedClassName=*/true);
+ TemplateName Template = getDerived().RebuildTemplateName(
+ SS, SpecTL.getTemplateKeywordLoc(),
+ *SpecTL.getTypePtr()->getIdentifier(), SpecTL.getTemplateNameLoc(),
+ ObjectType,
+ /*AllowInjectedClassName=*/true);
if (Template.isNull())
return nullptr;
@@ -12350,16 +12321,11 @@ TreeTransform<Derived>::TransformMemberExpr(MemberExpr *E) {
return ExprError();
}
- return getDerived().RebuildMemberExpr(Base.get(), FakeOperatorLoc,
- E->isArrow(),
- QualifierLoc,
- TemplateKWLoc,
- MemberNameInfo,
- Member,
- FoundDecl,
- (E->hasExplicitTemplateArgs()
- ? &TransArgs : nullptr),
- UnqualifiedLookups);
+ return getDerived().RebuildMemberExpr(
+ Base.get(), FakeOperatorLoc, E->isArrow(), QualifierLoc, TemplateKWLoc,
+ MemberNameInfo, Member, FoundDecl,
+ (E->hasExplicitTemplateArgs() ? &TransArgs : nullptr),
+ UnqualifiedLookups);
}
template<typename Derived>
@@ -13486,9 +13452,8 @@ TreeTransform<Derived>::TransformCXXPseudoDestructorExpr(
PseudoDestructorTypeStorage Destroyed;
if (E->getDestroyedTypeInfo()) {
- TypeSourceInfo *DestroyedTypeInfo
- = getDerived().TransformTypeInObjectScope(E->getDestroyedTypeInfo(),
- ObjectType, SS);
+ TypeSourceInfo *DestroyedTypeInfo = getDerived().TransformTypeInObjectScope(
+ E->getDestroyedTypeInfo(), ObjectType, SS);
if (!DestroyedTypeInfo)
return ExprError();
Destroyed = DestroyedTypeInfo;
@@ -13514,7 +13479,7 @@ TreeTransform<Derived>::TransformCXXPseudoDestructorExpr(
if (E->getScopeTypeInfo()) {
CXXScopeSpec EmptySS;
ScopeTypeInfo = getDerived().TransformTypeInObjectScope(
- E->getScopeTypeInfo(), ObjectType, EmptySS);
+ E->getScopeTypeInfo(), ObjectType, EmptySS);
if (!ScopeTypeInfo)
return ExprError();
}
@@ -14775,28 +14740,26 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
ObjectType = BaseType->castAs<PointerType>()->getPointeeType();
}
- #if 0
+#if 0
// Transform the first part of the nested-name-specifier that qualifies
// the member name.
NamedDecl *FirstQualifierInScope
= getDerived().TransformFirstQualifierInScope(
E->getFirstQualifierFoundInScope(),
E->getQualifierLoc().getBeginLoc());
- #endif
+#endif
UnresolvedSet<4> UnqualifiedLookups;
for (auto D : E->unqualified_lookups()) {
if (NamedDecl *InstD = getDerived().TransformFirstQualifierInScope(
- D.getDecl(), E->getQualifierLoc().getBeginLoc()))
+ D.getDecl(), E->getQualifierLoc().getBeginLoc()))
UnqualifiedLookups.addDecl(InstD);
}
NestedNameSpecifierLoc QualifierLoc;
if (E->getQualifier()) {
- QualifierLoc
- = getDerived().TransformNestedNameSpecifierLoc(E->getQualifierLoc(),
- ObjectType,
- UnqualifiedLookups.pairs());
+ QualifierLoc = getDerived().TransformNestedNameSpecifierLoc(
+ E->getQualifierLoc(), ObjectType, UnqualifiedLookups.pairs());
if (!QualifierLoc)
return ExprError();
}
@@ -14815,23 +14778,16 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
if (!E->hasExplicitTemplateArgs()) {
// This is a reference to a member without an explicitly-specified
// template argument list. Optimize for this common case.
- if (!getDerived().AlwaysRebuild() &&
- Base.get() == OldBase &&
- BaseType == E->getBaseType() &&
- QualifierLoc == E->getQualifierLoc() &&
+ if (!getDerived().AlwaysRebuild() && Base.get() == OldBase &&
+ BaseType == E->getBaseType() && QualifierLoc == E->getQualifierLoc() &&
NameInfo.getName() == E->getMember() &&
UnqualifiedLookups.pairs() == E->unqualified_lookups())
return E;
- return getDerived().RebuildCXXDependentScopeMemberExpr(Base.get(),
- BaseType,
- E->isArrow(),
- E->getOperatorLoc(),
- QualifierLoc,
- TemplateKWLoc,
- UnqualifiedLookups.pairs(),
- NameInfo,
- /*TemplateArgs*/nullptr);
+ return getDerived().RebuildCXXDependentScopeMemberExpr(
+ Base.get(), BaseType, E->isArrow(), E->getOperatorLoc(), QualifierLoc,
+ TemplateKWLoc, UnqualifiedLookups.pairs(), NameInfo,
+ /*TemplateArgs*/ nullptr);
}
TemplateArgumentListInfo TransArgs(E->getLAngleLoc(), E->getRAngleLoc());
@@ -14840,15 +14796,9 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
TransArgs))
return ExprError();
- return getDerived().RebuildCXXDependentScopeMemberExpr(Base.get(),
- BaseType,
- E->isArrow(),
- E->getOperatorLoc(),
- QualifierLoc,
- TemplateKWLoc,
- UnqualifiedLookups.pairs(),
- NameInfo,
- &TransArgs);
+ return getDerived().RebuildCXXDependentScopeMemberExpr(
+ Base.get(), BaseType, E->isArrow(), E->getOperatorLoc(), QualifierLoc,
+ TemplateKWLoc, UnqualifiedLookups.pairs(), NameInfo, &TransArgs);
}
template <typename Derived>
@@ -16270,14 +16220,10 @@ TreeTransform<Derived>::RebuildTemplateName(CXXScopeSpec &SS,
TemplateName(Template));
}
-template<typename Derived>
-TemplateName
-TreeTransform<Derived>::RebuildTemplateName(CXXScopeSpec &SS,
- SourceLocation TemplateKWLoc,
- const IdentifierInfo &Name,
- SourceLocation NameLoc,
- QualType ObjectType,
- bool AllowInjectedClassName) {
+template <typename Derived>
+TemplateName TreeTransform<Derived>::RebuildTemplateName(
+ CXXScopeSpec &SS, SourceLocation TemplateKWLoc, const IdentifierInfo &Name,
+ SourceLocation NameLoc, QualType ObjectType, bool AllowInjectedClassName) {
UnqualifiedId TemplateName;
TemplateName.setIdentifier(&Name, NameLoc);
Sema::TemplateTy Template;
@@ -16432,12 +16378,10 @@ TreeTransform<Derived>::RebuildCXXPseudoDestructorExpr(Expr *Base,
}
SourceLocation TemplateKWLoc; // FIXME: retrieve it from caller.
- return getSema().BuildMemberReferenceExpr(Base, BaseType,
- OperatorLoc, isArrow,
- SS, TemplateKWLoc,
- NameInfo,
- /*TemplateArgs=*/nullptr,
- /*S=*/nullptr);
+ return getSema().BuildMemberReferenceExpr(
+ Base, BaseType, OperatorLoc, isArrow, SS, TemplateKWLoc, NameInfo,
+ /*TemplateArgs=*/nullptr,
+ /*S=*/nullptr);
}
template<typename Derived>
diff --git a/clang/lib/Serialization/ASTReaderStmt.cpp b/clang/lib/Serialization/ASTReaderStmt.cpp
index 901f8fb5fc071..475a03ce7ab2d 100644
--- a/clang/lib/Serialization/ASTReaderStmt.cpp
+++ b/clang/lib/Serialization/ASTReaderStmt.cpp
@@ -1999,11 +1999,13 @@ void ASTStmtReader::VisitCXXDependentScopeMemberExpr(
unsigned NumUnqualifiedLookups = Record.readInt();
unsigned NumTemplateArgs = Record.readInt();
E->CXXDependentScopeMemberExprBits.HasQualifier = HasQualifier;
- E->CXXDependentScopeMemberExprBits.NumUnqualifiedLookups = NumUnqualifiedLookups;
+ E->CXXDependentScopeMemberExprBits.NumUnqualifiedLookups =
+ NumUnqualifiedLookups;
E->CXXDependentScopeMemberExprBits.HasTemplateKWAndArgsInfo = HasTemplateInfo;
E->BaseType = Record.readType();
- E->CXXDependentScopeMemberExprBits.IsArrow = CurrentUnpackingBits->getNextBit();
+ E->CXXDependentScopeMemberExprBits.IsArrow =
+ CurrentUnpackingBits->getNextBit();
if (CurrentUnpackingBits->getNextBit())
E->Base = Record.readSubExpr();
@@ -2020,7 +2022,9 @@ void ASTStmtReader::VisitCXXDependentScopeMemberExpr(
for (unsigned I = 0; I != NumUnqualifiedLookups; ++I) {
auto *FoundD = Record.readDeclAs<NamedDecl>();
auto AS = (AccessSpecifier)Record.readInt();
- E->getTrailingObjects<DeclAccessPair>()[I] = DeclAccessPair::make(FoundD, AS);;
+ E->getTrailingObjects<DeclAccessPair>()[I] =
+ DeclAccessPair::make(FoundD, AS);
+ ;
}
if (HasTemplateInfo)
@@ -2028,8 +2032,7 @@ void ASTStmtReader::VisitCXXDependentScopeMemberExpr(
*E->getTrailingObjects<ASTTemplateKWAndArgsInfo>(),
E->getTrailingObjects<TemplateArgumentLoc>(), NumTemplateArgs);
-
- #if 0
+#if 0
unsigned NumTemplateArgs = Record.readInt();
CurrentUnpackingBits.emplace(Record.readInt());
bool HasTemplateKWAndArgsInfo = CurrentUnpackingBits->getNextBit();
@@ -2066,7 +2069,7 @@ void ASTStmtReader::VisitCXXDependentScopeMemberExpr(
*E->getTrailingObjects<NamedDecl *>() = readDeclAs<NamedDecl>();
E->MemberNameInfo = Record.readDeclarationNameInfo();
- #endif
+#endif
}
void
@@ -4114,7 +4117,7 @@ Stmt *ASTReader::ReadStmtFromStream(ModuleFile &F) {
case EXPR_CXX_DEPENDENT_SCOPE_MEMBER: {
- #if 0
+#if 0
unsigned NumTemplateArgs = Record[ASTStmtReader::NumExprFields];
BitsUnpacker DependentScopeMemberBits(
Record[ASTStmtReader::NumExprFields + 1]);
@@ -4122,16 +4125,17 @@ Stmt *ASTReader::ReadStmtFromStream(ModuleFile &F) {
bool HasFirstQualifierFoundInScope =
DependentScopeMemberBits.getNextBit();
- #endif
- BitsUnpacker DependentScopeMemberBits(Record[ASTStmtReader::NumExprFields]);
+#endif
+ BitsUnpacker DependentScopeMemberBits(
+ Record[ASTStmtReader::NumExprFields]);
bool HasQualifier = DependentScopeMemberBits.getNextBit();
bool HasTemplateInfo = DependentScopeMemberBits.getNextBit();
unsigned NumUnqualifiedLookups = Record[ASTStmtReader::NumExprFields + 1];
unsigned NumTemplateArgs = Record[ASTStmtReader::NumExprFields + 2];
S = CXXDependentScopeMemberExpr::CreateEmpty(
- Context, HasQualifier, NumUnqualifiedLookups,
- HasTemplateInfo, NumTemplateArgs);
+ Context, HasQualifier, NumUnqualifiedLookups, HasTemplateInfo,
+ NumTemplateArgs);
break;
}
diff --git a/clang/lib/Serialization/ASTWriterStmt.cpp b/clang/lib/Serialization/ASTWriterStmt.cpp
index e16a8135368d5..e1fc1851bd541 100644
--- a/clang/lib/Serialization/ASTWriterStmt.cpp
+++ b/clang/lib/Serialization/ASTWriterStmt.cpp
@@ -2023,7 +2023,7 @@ void ASTStmtWriter::VisitCXXDependentScopeMemberExpr(
AddTemplateKWAndArgsInfo(*E->getTrailingObjects<ASTTemplateKWAndArgsInfo>(),
E->getTrailingObjects<TemplateArgumentLoc>());
- #if 0
+#if 0
// Don't emit anything here (or if you do you will have to update
// the corresponding deserialization function).
Record.push_back(E->getNumTemplateArgs());
@@ -2052,7 +2052,7 @@ void ASTStmtWriter::VisitCXXDependentScopeMemberExpr(
Record.AddDeclRef(E->getFirstQualifierFoundInScope());
Record.AddDeclarationNameInfo(E->MemberNameInfo);
- #endif
+#endif
Code = serialization::EXPR_CXX_DEPENDENT_SCOPE_MEMBER;
}
>From 5772c6fd723b8408047bdf160d68c9d7634df2e2 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Fri, 31 May 2024 14:35:35 -0400
Subject: [PATCH 05/26] [FOLD] add tests
---
.../basic.lookup.qual.general/p3-example3.cpp | 27 ++
.../basic.lookup.qual.general/p3.cpp | 71 +++++
clang/test/CXX/temp/temp.names/p3-23.cpp | 250 ++++++++++++++++++
3 files changed, 348 insertions(+)
create mode 100644 clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3-example3.cpp
create mode 100644 clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
create mode 100644 clang/test/CXX/temp/temp.names/p3-23.cpp
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3-example3.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3-example3.cpp
new file mode 100644
index 0000000000000..423eacd21d441
--- /dev/null
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3-example3.cpp
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -std=c++23 %s -verify
+
+int f();
+
+struct A {
+ int B, C; // expected-note {{declared as a non-template here}}
+ template<int> using D = void;
+ using T = void;
+ void f();
+};
+
+using B = A;
+template<int> using C = A;
+template<int> using D = A;
+template<int> using X = A;
+
+template<class T>
+void g(T *p) {
+ p->X<0>::f(); // expected-error {{no member named 'X' in 'A'}}
+ p->template X<0>::f();
+ p->B::f();
+ p->template C<0>::f(); // expected-error {{'C' following the 'template' keyword does not refer to a template}}
+ p->template D<0>::f(); // expected-error {{type 'template D<0>' (aka 'void') cannot be used prior to '::' because it has no members}}
+ p->T::f(); // expected-error {{'A::T' (aka 'void') is not a class, namespace, or enumeration}}
+}
+
+template void g(A*); // expected-note {{in instantiation of}}
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
new file mode 100644
index 0000000000000..e3c4aae984aeb
--- /dev/null
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
@@ -0,0 +1,71 @@
+// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify
+
+struct A {
+ int x;
+
+ template<typename T>
+ using C = A;
+};
+
+using B = A;
+
+template<typename T>
+using D = A;
+
+using E = void;
+
+struct F : A {
+ void non_template() {
+ this->x;
+ this->A::x;
+ this->B::x;
+ this->C<int>::x;
+ this->D<int>::x;
+ this->E::x; // expected-error {{'E' (aka 'void') is not a class, namespace, or enumeration}}
+ }
+};
+
+template<typename T>
+void not_instantiated(T t) {
+ t.x;
+ t.A::x;
+ t.B::x;
+ t.C<int>::x; // expected-error {{use 'template' keyword to treat 'C' as a dependent template name}}
+ t.template C<int>::x;
+ t.D<int>::x; // expected-error {{use 'template' keyword to treat 'D' as a dependent template name}}
+ t.template D<int>::x;
+ t.E::x;
+}
+
+template<typename T>
+void instantiated_valid(T t) {
+ t.x;
+ t.A::x;
+ t.B::x;
+ t.template C<int>::x;
+ t.template D<int>::x;
+ t.E::x;
+}
+
+template<typename T>
+void instantiated_invalid(T t) {
+ t.x;
+ t.A::x;
+ t.B::x; // expected-error {{'Invalid::B' (aka 'void') is not a class, namespace, or enumeration}}
+ t.template C<int>::x;
+ t.template D<int>::x; // expected-error {{'D' following the 'template' keyword does not refer to a template}}
+ t.E::x; // expected-error {{'E' (aka 'void') is not a class, namespace, or enumeration}}
+}
+
+struct Valid : A {
+ using E = A;
+};
+
+template void instantiated_valid(Valid);
+
+struct Invalid : A {
+ using B = void;
+ using D = A; // expected-note {{declared as a non-template here}}
+};
+
+template void instantiated_invalid(Invalid); // expected-note {{in instantiation of}}
diff --git a/clang/test/CXX/temp/temp.names/p3-23.cpp b/clang/test/CXX/temp/temp.names/p3-23.cpp
new file mode 100644
index 0000000000000..5119cd4ecac9f
--- /dev/null
+++ b/clang/test/CXX/temp/temp.names/p3-23.cpp
@@ -0,0 +1,250 @@
+// RUN: %clang_cc1 -std=c++23 %s -verify
+
+namespace FoundNothing {
+ template<typename T>
+ void f0(T &t) {
+ t.x<0;
+ t.x<0>; // expected-error {{expected expression}}
+ t.x<0>1;
+ }
+
+ template<typename T>
+ struct A {
+ void f1() {
+ this->x<0; // expected-error {{no member named 'x' in 'A<T>'}}
+ this->x<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{no member named 'x' in 'A<T>'}}
+ this->x<0>1; // expected-error {{no member named 'x' in 'A<T>'}}
+ }
+ };
+} // namespace FoundNothing
+
+namespace FoundSingleNonTemplate {
+ void f0();
+
+ struct A0;
+
+ template<typename T>
+ void g0(T &t) {
+ t.f0<0;
+ t.f0<0>; // expected-error {{expected expression}}
+ t.f0<0> 1;
+
+ t.A0<0;
+ t.A0<0>; // expected-error {{expected expression}}
+ t.A0<0>1;
+ }
+
+ template<typename T>
+ struct B {
+ void f1();
+
+ struct A1; // expected-note 3{{member 'A1' declared here}}
+
+ void g1() {
+ this->f0<0; // expected-error {{no member named 'f0' in 'B<T>'}}
+ this->f0<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{no member named 'f0' in 'B<T>'}}
+ this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
+
+ this->A0<0; // expected-error {{no member named 'A0' in 'B<T>'}}
+ this->A0<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{no member named 'A0' in 'B<T>'}}
+ this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
+
+ this->f1<0; // expected-error {{reference to non-static member function must be called}}
+ this->f1<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{reference to non-static member function must be called}}
+ this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
+
+ this->A1<0; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>1; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ }
+ };
+} // namespace FoundSingleNonTemplate
+
+namespace FoundSingleTemplate {
+ template<int I>
+ void f0();
+
+ template<int I>
+ struct A0;
+
+ template<typename T>
+ void g0(T &t) {
+ t.f0<0;
+ t.f0<0>; // expected-error {{expected expression}}
+ t.f0<0>1;
+
+ t.A0<0;
+ t.A0<0>; // expected-error {{expected expression}}
+ t.A0<0>1;
+ }
+
+ template<typename T>
+ struct B {
+ template<int I>
+ void f1(); // expected-note 2{{possible target for call}}
+
+ template<int I>
+ struct A1; // expected-note 2{{member 'A1' declared here}}
+
+ void g1() {
+ this->f0<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ this->f0<0>; // expected-error {{no member named 'f0' in 'B<T>'}}
+ this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
+ // expected-error at -1 {{expected ';' after expression}}
+
+ this->A0<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ this->A0<0>; // expected-error {{no member named 'A0' in 'B<T>'}}
+ this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
+ // expected-error at -1 {{expected ';' after expression}}
+
+
+ this->f1<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ this->f1<0>; // expected-error {{reference to non-static member function must be called}}
+ this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
+ // expected-error at -1 {{expected ';' after expression}}
+
+ this->A1<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ this->A1<0>; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>1; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
+ // expected-error at -1 {{expected ';' after expression}}
+ }
+ };
+} // namespace FoundSingleTemplate
+
+namespace FoundAmbiguousNonTemplate {
+ inline namespace N {
+ int f0;
+
+ struct A0;
+ } // namespace N
+
+ void f0();
+
+ struct A0;
+
+ template<typename T>
+ void g0(T &t) {
+ t.f0<0;
+ t.f0<0>; // expected-error {{expected expression}}
+ t.f0<0>1;
+
+ t.A0<0;
+ t.A0<0>; // expected-error {{expected expression}}
+ t.A0<0>1;
+ }
+
+ template<typename T>
+ struct B {
+ void f1();
+
+ struct A1; // expected-note 3{{member 'A1' declared here}}
+
+ void g1() {
+ this->f0<0; // expected-error {{no member named 'f0' in 'B<T>'}}
+ this->f0<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{no member named 'f0' in 'B<T>'}}
+ this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
+
+ this->A0<0; // expected-error {{no member named 'A0' in 'B<T>'}}
+ this->A0<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{no member named 'A0' in 'B<T>'}}
+ this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
+
+ this->f1<0; // expected-error {{reference to non-static member function must be called}}
+ this->f1<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{reference to non-static member function must be called}}
+ this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
+
+ this->A1<0; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>; // expected-error {{expected expression}}
+ // expected-error at -1 {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>1; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ }
+ };
+} // namespace FoundAmbiguousNonTemplates
+
+namespace FoundAmbiguousTemplate {
+ inline namespace N {
+ template<int I>
+ int f0; // expected-note 3{{candidate found by name lookup is 'FoundAmbiguousTemplate::N::f0'}}
+
+ template<int I>
+ struct A0; // expected-note 3{{candidate found by name lookup is 'FoundAmbiguousTemplate::N::A0'}}
+ } // namespace N
+
+ template<int I>
+ void f0(); // expected-note 3{{candidate found by name lookup is 'FoundAmbiguousTemplate::f0'}}
+
+ template<int I>
+ struct A0; // expected-note 3{{candidate found by name lookup is 'FoundAmbiguousTemplate::A0'}}
+
+ template<typename T>
+ void g0(T &t) {
+ t.f0<0;
+ t.f0<0>; // expected-error {{expected expression}}
+ t.f0<0>1;
+
+ t.A0<0;
+ t.A0<0>; // expected-error {{expected expression}}
+ t.A0<0>1;
+ }
+
+ template<typename T>
+ struct B {
+ template<int I>
+ void f1(); // expected-note 2{{possible target for call}}
+
+ template<int I>
+ struct A1; // expected-note 2{{member 'A1' declared here}}
+
+ void g1() {
+ this->f0<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ // expected-error at -3 {{reference to 'f0' is ambiguous}}
+ this->f0<0>; // expected-error {{no member named 'f0' in 'B<T>'}}
+ // expected-error at -1 {{reference to 'f0' is ambiguous}}
+ this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
+ // expected-error at -1 {{expected ';' after expression}}
+ // expected-error at -2 {{reference to 'f0' is ambiguous}}
+
+ this->A0<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ // expected-error at -3 {{reference to 'A0' is ambiguous}}
+ this->A0<0>; // expected-error {{no member named 'A0' in 'B<T>'}}
+ // expected-error at -1 {{reference to 'A0' is ambiguous}}
+ this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
+ // expected-error at -1 {{expected ';' after expression}}
+ // expected-error at -2 {{reference to 'A0' is ambiguous}}
+
+
+ this->f1<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ this->f1<0>; // expected-error {{reference to non-static member function must be called}}
+ this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
+ // expected-error at -1 {{expected ';' after expression}}
+
+ this->A1<0; // expected-error {{expected '>'}}
+ // expected-note at -1 {{to match this '<'}}
+ // expected-error at -2 {{expected unqualified-id}}
+ this->A1<0>; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>1; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
+ // expected-error at -1 {{expected ';' after expression}}
+ }
+ };
+} // namespace FoundAmbiguousTemplate
>From 667030b5c290fa0ead79e50fa793e6faea52d51a Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Fri, 31 May 2024 14:44:10 -0400
Subject: [PATCH 06/26] [FOLD] cleanups
---
clang/include/clang/AST/ExprCXX.h | 21 +---------
clang/include/clang/AST/Stmt.h | 6 ---
clang/lib/Sema/TreeTransform.h | 9 ----
clang/lib/Serialization/ASTReaderStmt.cpp | 50 -----------------------
clang/lib/Serialization/ASTWriterStmt.cpp | 31 --------------
5 files changed, 2 insertions(+), 115 deletions(-)
diff --git a/clang/include/clang/AST/ExprCXX.h b/clang/include/clang/AST/ExprCXX.h
index cb82b37aa6e49..edaea6fe27cc3 100644
--- a/clang/include/clang/AST/ExprCXX.h
+++ b/clang/include/clang/AST/ExprCXX.h
@@ -3812,25 +3812,8 @@ class CXXDependentScopeMemberExpr final
return getQualifierLoc().getNestedNameSpecifier();
}
-#if 0
- /// Retrieve the first part of the nested-name-specifier that was
- /// found in the scope of the member access expression when the member access
- /// was initially parsed.
- ///
- /// This function only returns a useful result when member access expression
- /// uses a qualified member name, e.g., "x.Base::f". Here, the declaration
- /// returned by this function describes what was found by unqualified name
- /// lookup for the identifier "Base" within the scope of the member access
- /// expression itself. At template instantiation time, this information is
- /// combined with the results of name lookup into the type of the object
- /// expression itself (the class type of x).
- NamedDecl *getFirstQualifierFoundInScope() const {
- if (!hasFirstQualifierFoundInScope())
- return nullptr;
- return *getTrailingObjects<NamedDecl *>();
- }
-#endif
-
+ /// Retrieve the declarations found by unqualified lookup for the first
+ /// component name of the nested-name-specifier, if any.
ArrayRef<DeclAccessPair> unqualified_lookups() const {
if (!getNumUnqualifiedLookups())
return std::nullopt;
diff --git a/clang/include/clang/AST/Stmt.h b/clang/include/clang/AST/Stmt.h
index 6e6221ec15fdb..257a61c97c9c6 100644
--- a/clang/include/clang/AST/Stmt.h
+++ b/clang/include/clang/AST/Stmt.h
@@ -1030,12 +1030,6 @@ class alignas(void *) Stmt {
LLVM_PREFERRED_TYPE(bool)
unsigned HasTemplateKWAndArgsInfo : 1;
-#if 0
- /// See getFirstQualifierFoundInScope() and the comment listing
- /// the trailing objects.
- LLVM_PREFERRED_TYPE(bool)
- unsigned HasFirstQualifierFoundInScope : 1;
-#endif
/// Number of declarations found by unqualified lookup for the
/// first component name of the nested-name-specifier.
unsigned NumUnqualifiedLookups;
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index 652425c3c3b47..1a19db85e73ce 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -14740,15 +14740,6 @@ TreeTransform<Derived>::TransformCXXDependentScopeMemberExpr(
ObjectType = BaseType->castAs<PointerType>()->getPointeeType();
}
-#if 0
- // Transform the first part of the nested-name-specifier that qualifies
- // the member name.
- NamedDecl *FirstQualifierInScope
- = getDerived().TransformFirstQualifierInScope(
- E->getFirstQualifierFoundInScope(),
- E->getQualifierLoc().getBeginLoc());
-#endif
-
UnresolvedSet<4> UnqualifiedLookups;
for (auto D : E->unqualified_lookups()) {
if (NamedDecl *InstD = getDerived().TransformFirstQualifierInScope(
diff --git a/clang/lib/Serialization/ASTReaderStmt.cpp b/clang/lib/Serialization/ASTReaderStmt.cpp
index 475a03ce7ab2d..5a5d7be69a2c3 100644
--- a/clang/lib/Serialization/ASTReaderStmt.cpp
+++ b/clang/lib/Serialization/ASTReaderStmt.cpp
@@ -2024,52 +2024,12 @@ void ASTStmtReader::VisitCXXDependentScopeMemberExpr(
auto AS = (AccessSpecifier)Record.readInt();
E->getTrailingObjects<DeclAccessPair>()[I] =
DeclAccessPair::make(FoundD, AS);
- ;
}
if (HasTemplateInfo)
ReadTemplateKWAndArgsInfo(
*E->getTrailingObjects<ASTTemplateKWAndArgsInfo>(),
E->getTrailingObjects<TemplateArgumentLoc>(), NumTemplateArgs);
-
-#if 0
- unsigned NumTemplateArgs = Record.readInt();
- CurrentUnpackingBits.emplace(Record.readInt());
- bool HasTemplateKWAndArgsInfo = CurrentUnpackingBits->getNextBit();
- bool HasFirstQualifierFoundInScope = CurrentUnpackingBits->getNextBit();
-
- assert((HasTemplateKWAndArgsInfo == E->hasTemplateKWAndArgsInfo()) &&
- "Wrong HasTemplateKWAndArgsInfo!");
- assert(
- (HasFirstQualifierFoundInScope == E->hasFirstQualifierFoundInScope()) &&
- "Wrong HasFirstQualifierFoundInScope!");
-
- if (HasTemplateKWAndArgsInfo)
- ReadTemplateKWAndArgsInfo(
- *E->getTrailingObjects<ASTTemplateKWAndArgsInfo>(),
- E->getTrailingObjects<TemplateArgumentLoc>(), NumTemplateArgs);
-
- assert((NumTemplateArgs == E->getNumTemplateArgs()) &&
- "Wrong NumTemplateArgs!");
-
- E->CXXDependentScopeMemberExprBits.IsArrow =
- CurrentUnpackingBits->getNextBit();
-
- E->BaseType = Record.readType();
- E->QualifierLoc = Record.readNestedNameSpecifierLoc();
- // not ImplicitAccess
- if (CurrentUnpackingBits->getNextBit())
- E->Base = Record.readSubExpr();
- else
- E->Base = nullptr;
-
- E->CXXDependentScopeMemberExprBits.OperatorLoc = readSourceLocation();
-
- if (HasFirstQualifierFoundInScope)
- *E->getTrailingObjects<NamedDecl *>() = readDeclAs<NamedDecl>();
-
- E->MemberNameInfo = Record.readDeclarationNameInfo();
-#endif
}
void
@@ -4116,16 +4076,6 @@ Stmt *ASTReader::ReadStmtFromStream(ModuleFile &F) {
break;
case EXPR_CXX_DEPENDENT_SCOPE_MEMBER: {
-
-#if 0
- unsigned NumTemplateArgs = Record[ASTStmtReader::NumExprFields];
- BitsUnpacker DependentScopeMemberBits(
- Record[ASTStmtReader::NumExprFields + 1]);
- bool HasTemplateKWAndArgsInfo = DependentScopeMemberBits.getNextBit();
-
- bool HasFirstQualifierFoundInScope =
- DependentScopeMemberBits.getNextBit();
-#endif
BitsUnpacker DependentScopeMemberBits(
Record[ASTStmtReader::NumExprFields]);
bool HasQualifier = DependentScopeMemberBits.getNextBit();
diff --git a/clang/lib/Serialization/ASTWriterStmt.cpp b/clang/lib/Serialization/ASTWriterStmt.cpp
index e1fc1851bd541..30c5b1bc56f47 100644
--- a/clang/lib/Serialization/ASTWriterStmt.cpp
+++ b/clang/lib/Serialization/ASTWriterStmt.cpp
@@ -2023,37 +2023,6 @@ void ASTStmtWriter::VisitCXXDependentScopeMemberExpr(
AddTemplateKWAndArgsInfo(*E->getTrailingObjects<ASTTemplateKWAndArgsInfo>(),
E->getTrailingObjects<TemplateArgumentLoc>());
-#if 0
- // Don't emit anything here (or if you do you will have to update
- // the corresponding deserialization function).
- Record.push_back(E->getNumTemplateArgs());
- CurrentPackingBits.updateBits();
- CurrentPackingBits.addBit(E->hasTemplateKWAndArgsInfo());
- CurrentPackingBits.addBit(E->hasFirstQualifierFoundInScope());
-
- if (E->hasTemplateKWAndArgsInfo()) {
- const ASTTemplateKWAndArgsInfo &ArgInfo =
- *E->getTrailingObjects<ASTTemplateKWAndArgsInfo>();
- AddTemplateKWAndArgsInfo(ArgInfo,
- E->getTrailingObjects<TemplateArgumentLoc>());
- }
-
- CurrentPackingBits.addBit(E->isArrow());
-
- Record.AddTypeRef(E->getBaseType());
- Record.AddNestedNameSpecifierLoc(E->getQualifierLoc());
- CurrentPackingBits.addBit(!E->isImplicitAccess());
- if (!E->isImplicitAccess())
- Record.AddStmt(E->getBase());
-
- Record.AddSourceLocation(E->getOperatorLoc());
-
- if (E->hasFirstQualifierFoundInScope())
- Record.AddDeclRef(E->getFirstQualifierFoundInScope());
-
- Record.AddDeclarationNameInfo(E->MemberNameInfo);
-#endif
-
Code = serialization::EXPR_CXX_DEPENDENT_SCOPE_MEMBER;
}
>From 28f1cc70c140c72f290983c7db34a7c96fc57c31 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Fri, 31 May 2024 15:29:21 -0400
Subject: [PATCH 07/26] [FOLD] use -Wno-unused for test
---
clang/test/CXX/temp/temp.names/p3-23.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/test/CXX/temp/temp.names/p3-23.cpp b/clang/test/CXX/temp/temp.names/p3-23.cpp
index 5119cd4ecac9f..a7015c2d250fb 100644
--- a/clang/test/CXX/temp/temp.names/p3-23.cpp
+++ b/clang/test/CXX/temp/temp.names/p3-23.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -std=c++23 %s -verify
+// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify
namespace FoundNothing {
template<typename T>
>From f4f5a2ed2e58ec3a630c23e6ac4cfe1f3e2afef4 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Fri, 31 May 2024 16:39:54 -0400
Subject: [PATCH 08/26] [FOLD] add additional tests
---
.../basic.lookup.qual.general/p3.cpp | 151 +++++++++++-------
1 file changed, 89 insertions(+), 62 deletions(-)
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
index e3c4aae984aeb..6798e961123c3 100644
--- a/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
@@ -1,71 +1,98 @@
// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify
-struct A {
- int x;
+namespace Unambiguous {
+ struct A {
+ int x;
+
+ template<typename T>
+ using C = A;
+ };
+
+ using B = A;
template<typename T>
- using C = A;
-};
+ using D = A;
+
+ using E = void;
-using B = A;
+ struct F : A {
+ void non_template() {
+ this->x;
+ this->A::x;
+ this->B::x;
+ this->C<int>::x;
+ this->D<int>::x;
+ this->E::x; // expected-error {{'Unambiguous::E' (aka 'void') is not a class, namespace, or enumeration}}
+ }
+ };
-template<typename T>
-using D = A;
+ template<typename T>
+ void not_instantiated(T t) {
+ t.x;
+ t.A::x;
+ t.B::x;
+ t.C<int>::x; // expected-error {{use 'template' keyword to treat 'C' as a dependent template name}}
+ t.template C<int>::x;
+ t.D<int>::x; // expected-error {{use 'template' keyword to treat 'D' as a dependent template name}}
+ t.template D<int>::x;
+ t.E::x;
+ }
-using E = void;
+ template<typename T>
+ void instantiated_valid(T t) {
+ t.x;
+ t.A::x;
+ t.B::x;
+ t.template C<int>::x;
+ t.template D<int>::x;
+ t.E::x;
+ }
-struct F : A {
- void non_template() {
- this->x;
- this->A::x;
- this->B::x;
- this->C<int>::x;
- this->D<int>::x;
- this->E::x; // expected-error {{'E' (aka 'void') is not a class, namespace, or enumeration}}
+ template<typename T>
+ void instantiated_invalid(T t) {
+ t.x;
+ t.A::x;
+ t.B::x; // expected-error {{'Unambiguous::Invalid::B' (aka 'void') is not a class, namespace, or enumeration}}
+ t.template C<int>::x;
+ t.template D<int>::x; // expected-error {{'D' following the 'template' keyword does not refer to a template}}
+ t.E::x; // expected-error {{'Unambiguous::E' (aka 'void') is not a class, namespace, or enumeration}}
}
-};
-
-template<typename T>
-void not_instantiated(T t) {
- t.x;
- t.A::x;
- t.B::x;
- t.C<int>::x; // expected-error {{use 'template' keyword to treat 'C' as a dependent template name}}
- t.template C<int>::x;
- t.D<int>::x; // expected-error {{use 'template' keyword to treat 'D' as a dependent template name}}
- t.template D<int>::x;
- t.E::x;
-}
-
-template<typename T>
-void instantiated_valid(T t) {
- t.x;
- t.A::x;
- t.B::x;
- t.template C<int>::x;
- t.template D<int>::x;
- t.E::x;
-}
-
-template<typename T>
-void instantiated_invalid(T t) {
- t.x;
- t.A::x;
- t.B::x; // expected-error {{'Invalid::B' (aka 'void') is not a class, namespace, or enumeration}}
- t.template C<int>::x;
- t.template D<int>::x; // expected-error {{'D' following the 'template' keyword does not refer to a template}}
- t.E::x; // expected-error {{'E' (aka 'void') is not a class, namespace, or enumeration}}
-}
-
-struct Valid : A {
- using E = A;
-};
-
-template void instantiated_valid(Valid);
-
-struct Invalid : A {
- using B = void;
- using D = A; // expected-note {{declared as a non-template here}}
-};
-
-template void instantiated_invalid(Invalid); // expected-note {{in instantiation of}}
+
+ struct Valid : A {
+ using E = A;
+ };
+
+ template void instantiated_valid(Valid);
+
+ struct Invalid : A {
+ using B = void;
+ using D = A; // expected-note {{declared as a non-template here}}
+ };
+
+ template void instantiated_invalid(Invalid); // expected-note {{in instantiation of}}
+} // namespace Unambiguous
+
+namespace Ambiguous {
+ inline namespace N {
+ struct A { }; // expected-note {{candidate found by name lookup is 'Ambiguous::N::A'}}
+ }
+
+ struct A { }; // expected-note {{candidate found by name lookup is 'Ambiguous::A'}}
+
+ template<typename T>
+ void f(T t) {
+ t.A::x; // expected-error {{reference to 'A' is ambiguous}}
+ }
+
+ struct B {
+ using A = B;
+
+ int x;
+ };
+
+ struct C { };
+
+ template void f(B);
+ template void f(C); // expected-note {{in instantiation of}}
+
+} // namespace Ambiguous
>From 0985ac789ffff0b773e176a97984954a54f3034f Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Mon, 3 Jun 2024 06:40:11 -0400
Subject: [PATCH 09/26] [FOLD] factor out some NFC changes
---
clang/include/clang/Sema/Sema.h | 2 +-
clang/lib/Parse/ParseDeclCXX.cpp | 2 +-
clang/lib/Parse/ParseExpr.cpp | 9 ++++-----
clang/lib/Sema/SemaExprMember.cpp | 9 ++++++---
clang/lib/Sema/SemaPseudoObject.cpp | 16 ++++++++--------
5 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index a5e3f9bcf4f70..e21b5bb8b0de7 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -8585,7 +8585,7 @@ class Sema final : public SemaBase {
/// decl; this is an ugly hack around the fact that Objective-C
/// \@implementations aren't properly put in the context chain
ExprResult ActOnMemberAccessExpr(Scope *S, Expr *Base, SourceLocation OpLoc,
- bool IsArrow, CXXScopeSpec &SS,
+ tok::TokenKind OpKind, CXXScopeSpec &SS,
SourceLocation TemplateKWLoc,
UnqualifiedId &Member, Decl *ObjCImpDecl);
diff --git a/clang/lib/Parse/ParseDeclCXX.cpp b/clang/lib/Parse/ParseDeclCXX.cpp
index 7ade92069c6ba..ce827c689beb7 100644
--- a/clang/lib/Parse/ParseDeclCXX.cpp
+++ b/clang/lib/Parse/ParseDeclCXX.cpp
@@ -728,7 +728,7 @@ Parser::DeclGroupPtrTy Parser::ParseUsingDeclaration(
return nullptr;
}
CXXScopeSpec SS;
- if (ParseOptionalCXXScopeSpecifier(SS, /*ObjectType=*/nullptr,
+ if (ParseOptionalCXXScopeSpecifier(SS, /*ParsedType=*/nullptr,
/*ObectHasErrors=*/false,
/*EnteringConttext=*/false,
/*MayBePseudoDestructor=*/nullptr,
diff --git a/clang/lib/Parse/ParseExpr.cpp b/clang/lib/Parse/ParseExpr.cpp
index 1cbc9779ada60..2dd2e1b83548b 100644
--- a/clang/lib/Parse/ParseExpr.cpp
+++ b/clang/lib/Parse/ParseExpr.cpp
@@ -2269,7 +2269,6 @@ Parser::ParsePostfixExpressionSuffix(ExprResult LHS) {
}
break;
}
-
ParseOptionalCXXScopeSpecifier(
SS, ObjectType, LHS.get() && LHS.get()->containsErrors(),
/*EnteringContext=*/false, &MayBePseudoDestructor);
@@ -2344,10 +2343,10 @@ Parser::ParsePostfixExpressionSuffix(ExprResult LHS) {
}
if (!LHS.isInvalid())
- LHS = Actions.ActOnMemberAccessExpr(
- getCurScope(), LHS.get(), OpLoc, OpKind == tok::arrow, SS,
- TemplateKWLoc, Name,
- CurParsedObjCImpl ? CurParsedObjCImpl->Dcl : nullptr);
+ LHS = Actions.ActOnMemberAccessExpr(getCurScope(), LHS.get(), OpLoc,
+ OpKind, SS, TemplateKWLoc, Name,
+ CurParsedObjCImpl ? CurParsedObjCImpl->Dcl
+ : nullptr);
if (!LHS.isInvalid()) {
if (Tok.is(tok::less))
checkPotentialAngleBracket(LHS);
diff --git a/clang/lib/Sema/SemaExprMember.cpp b/clang/lib/Sema/SemaExprMember.cpp
index c4ade5b98102b..114e1368d11e8 100644
--- a/clang/lib/Sema/SemaExprMember.cpp
+++ b/clang/lib/Sema/SemaExprMember.cpp
@@ -1033,7 +1033,7 @@ ExprResult Sema::BuildMemberReferenceExpr(
if (RetryExpr.isUsable() && !Trap.hasErrorOccurred()) {
CXXScopeSpec TempSS(SS);
RetryExpr = ActOnMemberAccessExpr(
- ExtraArgs->S, RetryExpr.get(), OpLoc, /*IsArrow=*/true, TempSS,
+ ExtraArgs->S, RetryExpr.get(), OpLoc, tok::arrow, TempSS,
TemplateKWLoc, ExtraArgs->Id, ExtraArgs->ObjCImpDecl);
}
if (Trap.hasErrorOccurred())
@@ -1736,10 +1736,12 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult &R,
}
ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
- SourceLocation OpLoc, bool IsArrow,
+ SourceLocation OpLoc,
+ tok::TokenKind OpKind,
CXXScopeSpec &SS,
SourceLocation TemplateKWLoc,
- UnqualifiedId &Id, Decl *ObjCImpDecl) {
+ UnqualifiedId &Id,
+ Decl *ObjCImpDecl) {
if (SS.isSet() && SS.isInvalid())
return ExprError();
@@ -1756,6 +1758,7 @@ ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
const TemplateArgumentListInfo *TemplateArgs;
DecomposeUnqualifiedId(Id, TemplateArgsBuffer,
NameInfo, TemplateArgs);
+ bool IsArrow = OpKind == tok::arrow;
if (getLangOpts().HLSL && IsArrow)
return ExprError(Diag(OpLoc, diag::err_hlsl_operator_unsupported) << 2);
diff --git a/clang/lib/Sema/SemaPseudoObject.cpp b/clang/lib/Sema/SemaPseudoObject.cpp
index 86c303e67bc1d..fdb584ceb8105 100644
--- a/clang/lib/Sema/SemaPseudoObject.cpp
+++ b/clang/lib/Sema/SemaPseudoObject.cpp
@@ -1395,10 +1395,10 @@ ExprResult MSPropertyOpBuilder::buildGet() {
GetterName.setIdentifier(II, RefExpr->getMemberLoc());
CXXScopeSpec SS;
SS.Adopt(RefExpr->getQualifierLoc());
- ExprResult GetterExpr = S.ActOnMemberAccessExpr(
- S.getCurScope(), InstanceBase, /*OpLoc=*/SourceLocation(),
- RefExpr->isArrow(), SS, /*TemplateKWLoc=*/SourceLocation(), GetterName,
- /*ObjCImpDecl=*/nullptr);
+ ExprResult GetterExpr =
+ S.ActOnMemberAccessExpr(S.getCurScope(), InstanceBase, SourceLocation(),
+ RefExpr->isArrow() ? tok::arrow : tok::period, SS,
+ SourceLocation(), GetterName, nullptr);
if (GetterExpr.isInvalid()) {
S.Diag(RefExpr->getMemberLoc(),
diag::err_cannot_find_suitable_accessor) << 0 /* getter */
@@ -1424,10 +1424,10 @@ ExprResult MSPropertyOpBuilder::buildSet(Expr *op, SourceLocation sl,
SetterName.setIdentifier(II, RefExpr->getMemberLoc());
CXXScopeSpec SS;
SS.Adopt(RefExpr->getQualifierLoc());
- ExprResult SetterExpr = S.ActOnMemberAccessExpr(
- S.getCurScope(), InstanceBase, /*OpLoc=*/SourceLocation(),
- RefExpr->isArrow(), SS, /*TemplateKWLoc=*/SourceLocation(), SetterName,
- /*ObjCImpDecl=*/nullptr);
+ ExprResult SetterExpr =
+ S.ActOnMemberAccessExpr(S.getCurScope(), InstanceBase, SourceLocation(),
+ RefExpr->isArrow() ? tok::arrow : tok::period, SS,
+ SourceLocation(), SetterName, nullptr);
if (SetterExpr.isInvalid()) {
S.Diag(RefExpr->getMemberLoc(),
diag::err_cannot_find_suitable_accessor) << 1 /* setter */
>From 5fdaa8d75e551d4a4990c35a919b48bbc2d8dfe7 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Mon, 3 Jun 2024 06:44:35 -0400
Subject: [PATCH 10/26] [FOLD] remove fixme from test
---
clang/test/CXX/drs/cwg1xx.cpp | 1 -
clang/test/CXX/temp/temp.names/p3-23.cpp | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/clang/test/CXX/drs/cwg1xx.cpp b/clang/test/CXX/drs/cwg1xx.cpp
index 3831b42e87b00..6bca460818425 100644
--- a/clang/test/CXX/drs/cwg1xx.cpp
+++ b/clang/test/CXX/drs/cwg1xx.cpp
@@ -615,7 +615,6 @@ namespace cwg141 { // cwg141: 3.1
// cxx98-note@#cwg141-S {{lookup from the current scope refers here}}
// expected-error@#cwg141-a {{no member named 'n' in 'cwg141::A::S<int>'; did you mean '::cwg141::S<int>::n'?}}
// expected-note@#cwg141-S {{'::cwg141::S<int>::n' declared here}}
- // FIXME: we issue a useful diagnostic first, then some bogus ones.
b.f<int>();
// expected-error at -1 {{no member named 'f' in 'cwg141::B'}}
(void)b.S<int>::n;
diff --git a/clang/test/CXX/temp/temp.names/p3-23.cpp b/clang/test/CXX/temp/temp.names/p3-23.cpp
index a7015c2d250fb..f652a81101162 100644
--- a/clang/test/CXX/temp/temp.names/p3-23.cpp
+++ b/clang/test/CXX/temp/temp.names/p3-23.cpp
@@ -28,7 +28,7 @@ namespace FoundSingleNonTemplate {
void g0(T &t) {
t.f0<0;
t.f0<0>; // expected-error {{expected expression}}
- t.f0<0> 1;
+ t.f0<0>1;
t.A0<0;
t.A0<0>; // expected-error {{expected expression}}
>From 9c04edd0ff6d560c51307fc371ec6974cf44954a Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Mon, 3 Jun 2024 08:36:13 -0400
Subject: [PATCH 11/26] [FOLD] make missing 'template' keyword an extension
---
.../clang/Basic/DiagnosticParseKinds.td | 4 +---
clang/lib/Parse/ParseExprCXX.cpp | 8 ++------
.../basic.lookup.qual.general/p3.cpp | 4 ++--
.../class.derived/class.member.lookup/p8.cpp | 4 ++--
clang/test/CXX/temp/temp.res/p3.cpp | 2 +-
clang/test/FixIt/fixit.cpp | 4 ++--
clang/test/Misc/warning-flags.c | 2 +-
.../Parser/cxx2a-concepts-requires-expr.cpp | 2 +-
.../SemaTemplate/dependent-base-classes.cpp | 20 +++++++++----------
.../dependent-template-recover.cpp | 12 +++++------
clang/test/SemaTemplate/template-id-expr.cpp | 14 ++++++-------
.../SemaTemplate/typename-specifier-3.cpp | 2 +-
12 files changed, 36 insertions(+), 42 deletions(-)
diff --git a/clang/include/clang/Basic/DiagnosticParseKinds.td b/clang/include/clang/Basic/DiagnosticParseKinds.td
index 12aab09f28556..0bd2e35bf2e31 100644
--- a/clang/include/clang/Basic/DiagnosticParseKinds.td
+++ b/clang/include/clang/Basic/DiagnosticParseKinds.td
@@ -895,9 +895,7 @@ def missing_template_arg_list_after_template_kw : Extension<
"keyword">, InGroup<DiagGroup<"missing-template-arg-list-after-template-kw">>,
DefaultError;
-def err_missing_dependent_template_keyword : Error<
- "use 'template' keyword to treat '%0' as a dependent template name">;
-def warn_missing_dependent_template_keyword : ExtWarn<
+def ext_missing_dependent_template_keyword : ExtWarn<
"use 'template' keyword to treat '%0' as a dependent template name">;
def ext_extern_template : Extension<
diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp
index 1d364f77a8146..f50d4df2fe9ef 100644
--- a/clang/lib/Parse/ParseExprCXX.cpp
+++ b/clang/lib/Parse/ParseExprCXX.cpp
@@ -566,11 +566,7 @@ bool Parser::ParseOptionalCXXScopeSpecifier(
// member of an unknown specialization. However, this will only
// parse correctly as a template, so suggest the keyword 'template'
// before 'getAs' and treat this as a dependent template name.
- unsigned DiagID = diag::err_missing_dependent_template_keyword;
- if (getLangOpts().MicrosoftExt)
- DiagID = diag::warn_missing_dependent_template_keyword;
-
- Diag(Tok.getLocation(), DiagID)
+ Diag(Tok.getLocation(), diag::ext_missing_dependent_template_keyword)
<< II.getName()
<< FixItHint::CreateInsertion(Tok.getLocation(), "template ");
}
@@ -2580,7 +2576,7 @@ bool Parser::ParseUnqualifiedIdTemplateId(
else
Name += Id.Identifier->getName();
}
- Diag(Id.StartLocation, diag::err_missing_dependent_template_keyword)
+ Diag(Id.StartLocation, diag::ext_missing_dependent_template_keyword)
<< Name
<< FixItHint::CreateInsertion(Id.StartLocation, "template ");
}
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
index 6798e961123c3..7d843649c3f30 100644
--- a/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.qual/basic.lookup.qual.general/p3.cpp
@@ -31,9 +31,9 @@ namespace Unambiguous {
t.x;
t.A::x;
t.B::x;
- t.C<int>::x; // expected-error {{use 'template' keyword to treat 'C' as a dependent template name}}
+ t.C<int>::x; // expected-warning {{use 'template' keyword to treat 'C' as a dependent template name}}
t.template C<int>::x;
- t.D<int>::x; // expected-error {{use 'template' keyword to treat 'D' as a dependent template name}}
+ t.D<int>::x; // expected-warning {{use 'template' keyword to treat 'D' as a dependent template name}}
t.template D<int>::x;
t.E::x;
}
diff --git a/clang/test/CXX/class.derived/class.member.lookup/p8.cpp b/clang/test/CXX/class.derived/class.member.lookup/p8.cpp
index e9a57f739cc35..97d3587881bbc 100644
--- a/clang/test/CXX/class.derived/class.member.lookup/p8.cpp
+++ b/clang/test/CXX/class.derived/class.member.lookup/p8.cpp
@@ -47,8 +47,8 @@ template<typename T>
void DerivedT<T>::Inner() {
Derived1T<T>::Foo();
Derived2T<T>::Member = 42;
- this->Derived1T<T>::Foo(); // expected-error{{use 'template' keyword to treat 'Derived1T' as a dependent template name}}
- this->Derived2T<T>::Member = 42; // expected-error{{use 'template' keyword to treat 'Derived2T' as a dependent template name}}
+ this->Derived1T<T>::Foo(); // expected-warning{{use 'template' keyword to treat 'Derived1T' as a dependent template name}}
+ this->Derived2T<T>::Member = 42; // expected-warning{{use 'template' keyword to treat 'Derived2T' as a dependent template name}}
this->Foo(); // expected-error{{non-static member 'Foo' found in multiple base-class subobjects of type 'BaseT<int>'}}
}
diff --git a/clang/test/CXX/temp/temp.res/p3.cpp b/clang/test/CXX/temp/temp.res/p3.cpp
index 37ab93559e369..a4d735e05e9b8 100644
--- a/clang/test/CXX/temp/temp.res/p3.cpp
+++ b/clang/test/CXX/temp/temp.res/p3.cpp
@@ -30,6 +30,6 @@ template<typename T> int A<T>::template C<int>::*f5() {} // expected-error {{has
template<typename T> template<typename U> struct A<T>::B {
friend A<T>::C<T> f6(); // ok, same as 'friend T f6();'
- friend A<U>::C<T> f7(); // expected-error {{use 'template' keyword to treat 'C' as a dependent template name}} expected-warning {{missing 'typename'}}
+ friend A<U>::C<T> f7(); // expected-warning {{use 'template' keyword to treat 'C' as a dependent template name}} expected-warning {{missing 'typename'}}
friend A<U>::template C<T> f8(); // expected-warning {{missing 'typename'}}
};
diff --git a/clang/test/FixIt/fixit.cpp b/clang/test/FixIt/fixit.cpp
index 605c2d0bd0235..144eefb3ae4bd 100644
--- a/clang/test/FixIt/fixit.cpp
+++ b/clang/test/FixIt/fixit.cpp
@@ -158,12 +158,12 @@ class F1 {
template<class T>
class F2 {
- typename F1<T>:: /*template*/ Iterator<0> Mypos; // expected-error {{use 'template' keyword to treat 'Iterator' as a dependent template name}}
+ typename F1<T>:: /*template*/ Iterator<0> Mypos; // expected-warning {{use 'template' keyword to treat 'Iterator' as a dependent template name}}
};
template <class T>
void f(){
- typename F1<T>:: /*template*/ Iterator<0> Mypos; // expected-error {{use 'template' keyword to treat 'Iterator' as a dependent template name}}
+ typename F1<T>:: /*template*/ Iterator<0> Mypos; // expected-warning {{use 'template' keyword to treat 'Iterator' as a dependent template name}}
}
// Tests for &/* fixits
diff --git a/clang/test/Misc/warning-flags.c b/clang/test/Misc/warning-flags.c
index cdbe1e95cba96..651a86fb6e226 100644
--- a/clang/test/Misc/warning-flags.c
+++ b/clang/test/Misc/warning-flags.c
@@ -21,6 +21,7 @@ The list of warnings below should NEVER grow. It should gradually shrink to 0.
CHECK: Warnings without flags (65):
CHECK-NEXT: ext_expected_semi_decl_list
+CHECK-NEXT: ext_missing_dependent_template_keyword
CHECK-NEXT: ext_missing_whitespace_after_macro_name
CHECK-NEXT: ext_new_paren_array_nonconst
CHECK-NEXT: ext_plain_complex
@@ -61,7 +62,6 @@ CHECK-NEXT: warn_invalid_cpu_supports
CHECK-NEXT: warn_maynot_respond
CHECK-NEXT: warn_method_param_redefinition
CHECK-NEXT: warn_missing_case_for_condition
-CHECK-NEXT: warn_missing_dependent_template_keyword
CHECK-NEXT: warn_missing_whitespace_after_macro_name
CHECK-NEXT: warn_mt_message
CHECK-NEXT: warn_no_constructor_for_refconst
diff --git a/clang/test/Parser/cxx2a-concepts-requires-expr.cpp b/clang/test/Parser/cxx2a-concepts-requires-expr.cpp
index 5755844a323d2..0c7f453b5c48d 100644
--- a/clang/test/Parser/cxx2a-concepts-requires-expr.cpp
+++ b/clang/test/Parser/cxx2a-concepts-requires-expr.cpp
@@ -78,7 +78,7 @@ bool r22 = requires { typename s::~s; };
template<typename T>
bool r23 = requires { typename identity<T>::temp<T>; };
-// expected-error at -1 {{use 'template' keyword to treat 'temp' as a dependent template name}}
+// expected-warning at -1 {{use 'template' keyword to treat 'temp' as a dependent template name}}
template<typename T>
bool r24 = requires {
diff --git a/clang/test/SemaTemplate/dependent-base-classes.cpp b/clang/test/SemaTemplate/dependent-base-classes.cpp
index 92a37efaa7e73..4cb88a5b4070a 100644
--- a/clang/test/SemaTemplate/dependent-base-classes.cpp
+++ b/clang/test/SemaTemplate/dependent-base-classes.cpp
@@ -1,12 +1,12 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s
template<typename T, typename U>
-struct X0 : T::template apply<U> {
+struct X0 : T::template apply<U> {
X0(U u) : T::template apply<U>(u) { }
};
template<typename T, typename U>
-struct X1 : T::apply<U> { }; // expected-error{{use 'template' keyword to treat 'apply' as a dependent template name}}
+struct X1 : T::apply<U> { }; // expected-warning{{use 'template' keyword to treat 'apply' as a dependent template name}}
template<typename T>
struct X2 : vector<T> { }; // expected-error{{no template named 'vector'}}
@@ -85,7 +85,7 @@ namespace PR6081 {
struct A { };
template<typename T>
- class B : public A<T>
+ class B : public A<T>
{
public:
template< class X >
@@ -109,9 +109,9 @@ namespace PR6081 {
namespace PR6413 {
template <typename T> class Base_A { };
-
+
class Base_B { };
-
+
template <typename T>
class Derived
: public virtual Base_A<T>
@@ -120,12 +120,12 @@ namespace PR6413 {
}
namespace PR5812 {
- template <class T> struct Base {
- Base* p;
- };
+ template <class T> struct Base {
+ Base* p;
+ };
- template <class T> struct Derived: public Base<T> {
- typename Derived::Base* p; // meaning Derived::Base<T>
+ template <class T> struct Derived: public Base<T> {
+ typename Derived::Base* p; // meaning Derived::Base<T>
};
Derived<int> di;
diff --git a/clang/test/SemaTemplate/dependent-template-recover.cpp b/clang/test/SemaTemplate/dependent-template-recover.cpp
index c7e27e8da25f1..c763989e6dadb 100644
--- a/clang/test/SemaTemplate/dependent-template-recover.cpp
+++ b/clang/test/SemaTemplate/dependent-template-recover.cpp
@@ -2,15 +2,15 @@
template<typename T, typename U, int N>
struct X {
void f(T* t) {
- t->f0<U>(); // expected-error{{use 'template' keyword to treat 'f0' as a dependent template name}}
- t->f0<int>(); // expected-error{{use 'template' keyword to treat 'f0' as a dependent template name}}
+ t->f0<U>(); // expected-warning{{use 'template' keyword to treat 'f0' as a dependent template name}}
+ t->f0<int>(); // expected-warning{{use 'template' keyword to treat 'f0' as a dependent template name}}
- t->operator+<U const, 1>(1); // expected-error{{use 'template' keyword to treat 'operator +' as a dependent template name}}
- t->f1<int const, 2>(1); // expected-error{{use 'template' keyword to treat 'f1' as a dependent template name}}
+ t->operator+<U const, 1>(1); // expected-warning{{use 'template' keyword to treat 'operator +' as a dependent template name}}
+ t->f1<int const, 2>(1); // expected-warning{{use 'template' keyword to treat 'f1' as a dependent template name}}
t->f1<3, int const>(1); // expected-error{{missing 'template' keyword prior to dependent template name 'f1'}}
- T::getAs<U>(); // expected-error{{use 'template' keyword to treat 'getAs' as a dependent template name}}
- t->T::getAs<U>(); // expected-error{{use 'template' keyword to treat 'getAs' as a dependent template name}}
+ T::getAs<U>(); // expected-warning{{use 'template' keyword to treat 'getAs' as a dependent template name}}
+ t->T::getAs<U>(); // expected-warning{{use 'template' keyword to treat 'getAs' as a dependent template name}}
(*t).f2<N>(); // expected-error{{missing 'template' keyword prior to dependent template name 'f2'}}
(*t).f2<0>(); // expected-error{{missing 'template' keyword prior to dependent template name 'f2'}}
diff --git a/clang/test/SemaTemplate/template-id-expr.cpp b/clang/test/SemaTemplate/template-id-expr.cpp
index dc12823ae307f..760d6c5852403 100644
--- a/clang/test/SemaTemplate/template-id-expr.cpp
+++ b/clang/test/SemaTemplate/template-id-expr.cpp
@@ -19,7 +19,7 @@ template<typename T>
struct X0 {
template<typename U>
void f1();
-
+
template<typename U>
void f2(U) {
f1<U>();
@@ -39,9 +39,9 @@ struct Y {
template<int I>
struct X {
X(int, int);
- void f() {
- Y<X<I> >(X<I>(0, 0));
- Y<X<I> >(::X<I>(0, 0));
+ void f() {
+ Y<X<I> >(X<I>(0, 0));
+ Y<X<I> >(::X<I>(0, 0));
}
};
@@ -149,11 +149,11 @@ struct Y2 : Y1<T> {
int x;
x = Y1::f4(0);
- x = Y1::f4<int>(0); // expected-error {{use 'template'}} expected-error {{assigning to 'int' from incompatible type 'void'}}
+ x = Y1::f4<int>(0); // expected-warning {{use 'template'}} expected-error {{assigning to 'int' from incompatible type 'void'}}
x = Y1::template f4(0); // expected-error {{assigning to 'int' from incompatible type 'void'}} expected-error {{a template argument list is expected after a name prefixed by the template keyword}}
x = p->f4(0);
- x = p->f4<int>(0); // expected-error {{assigning to 'int' from incompatible type 'void'}} expected-error {{use 'template'}}
+ x = p->f4<int>(0); // expected-error {{assigning to 'int' from incompatible type 'void'}} expected-warning {{use 'template'}}
x = p->template f4(0); // expected-error {{assigning to 'int' from incompatible type 'void'}} expected-error {{a template argument list is expected after a name prefixed by the template keyword}}
}
};
@@ -184,7 +184,7 @@ class E {
#if __cplusplus <= 199711L
// expected-warning at +2 {{extension}}
#endif
-template<typename T> using D = int; // expected-note {{declared here}}
+template<typename T> using D = int; // expected-note {{declared here}}
E<D> ed; // expected-note {{instantiation of}}
namespace non_functions {
diff --git a/clang/test/SemaTemplate/typename-specifier-3.cpp b/clang/test/SemaTemplate/typename-specifier-3.cpp
index 714830f0032d2..a9010969322e5 100644
--- a/clang/test/SemaTemplate/typename-specifier-3.cpp
+++ b/clang/test/SemaTemplate/typename-specifier-3.cpp
@@ -46,7 +46,7 @@ namespace PR12884_half_fixed {
typedef int arg;
};
struct C {
- typedef typename B::X<typename B::arg> x; // expected-error {{use 'template'}} expected-error {{refers to non-type}}
+ typedef typename B::X<typename B::arg> x; // expected-warning {{use 'template'}} expected-error {{refers to non-type}}
};
};
>From 8c6d78bee8763ad824414d3b7d5bc82039e4e131 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Mon, 3 Jun 2024 12:07:39 -0400
Subject: [PATCH 12/26] [FOLD] fix missing 'template' keyword in libc++
---
libcxx/include/regex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcxx/include/regex b/libcxx/include/regex
index b814135121321..17ad0cf5b2aea 100644
--- a/libcxx/include/regex
+++ b/libcxx/include/regex
@@ -4214,7 +4214,7 @@ public:
_LIBCPP_HIDE_FROM_ABI int compare(const value_type* __s) const { return str().compare(__s); }
_LIBCPP_HIDE_FROM_ABI void swap(sub_match& __s) _NOEXCEPT_(__is_nothrow_swappable_v<_BidirectionalIterator>) {
- this->pair<_BidirectionalIterator, _BidirectionalIterator>::swap(__s);
+ this->template pair<_BidirectionalIterator, _BidirectionalIterator>::swap(__s);
std::swap(matched, __s.matched);
}
};
>From b09684a9a53883da42c118b95de92607bdc2e437 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 4 Jun 2024 07:52:12 -0400
Subject: [PATCH 13/26] [FOLD] experimental improved recovery
---
clang/include/clang/Parse/Parser.h | 3 +-
clang/include/clang/Sema/Sema.h | 9 ++-
clang/lib/Parse/ParseExprCXX.cpp | 68 +++++++++++++++++-----
clang/lib/Sema/SemaTemplate.cpp | 20 ++++---
clang/lib/Sema/SemaTemplateInstantiate.cpp | 7 ++-
clang/lib/Sema/TreeTransform.h | 22 ++++---
clang/test/CXX/drs/cwg3xx.cpp | 10 ++--
clang/test/CXX/drs/cwg4xx.cpp | 2 +-
8 files changed, 96 insertions(+), 45 deletions(-)
diff --git a/clang/include/clang/Parse/Parser.h b/clang/include/clang/Parse/Parser.h
index 6880fa4bb0b03..da8a18e04d8a6 100644
--- a/clang/include/clang/Parse/Parser.h
+++ b/clang/include/clang/Parse/Parser.h
@@ -3376,7 +3376,8 @@ class Parser : public CodeCompletionHandler {
SourceLocation NameLoc,
bool EnteringContext,
UnqualifiedId &Id,
- bool AssumeTemplateId);
+ bool AssumeTemplateId,
+ bool ForDestructor);
bool ParseUnqualifiedIdOperator(CXXScopeSpec &SS, bool EnteringContext,
ParsedType ObjectType,
UnqualifiedId &Result);
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index e21b5bb8b0de7..0928afbaae6ec 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -11123,7 +11123,8 @@ class Sema final : public SemaBase {
QualType ObjectType, bool EnteringContext,
RequiredTemplateKind RequiredTemplate = SourceLocation(),
AssumedTemplateKind *ATK = nullptr,
- bool AllowTypoCorrection = true);
+ bool AllowTypoCorrection = true,
+ bool MayBeNNS = false);
TemplateNameKind isTemplateName(Scope *S, CXXScopeSpec &SS,
bool hasTemplateKeyword,
@@ -11131,7 +11132,8 @@ class Sema final : public SemaBase {
ParsedType ObjectType, bool EnteringContext,
TemplateTy &Template,
bool &MemberOfUnknownSpecialization,
- bool Disambiguation = false);
+ bool Disambiguation = false,
+ bool MayBeNNS = false);
/// Try to resolve an undeclared template name as a type template.
///
@@ -11465,7 +11467,8 @@ class Sema final : public SemaBase {
const UnqualifiedId &Name,
ParsedType ObjectType,
bool EnteringContext, TemplateTy &Template,
- bool AllowInjectedClassName = false);
+ bool AllowInjectedClassName = false,
+ bool MayBeNNS = false);
DeclResult ActOnClassTemplateSpecialization(
Scope *S, unsigned TagSpec, TagUseKind TUK, SourceLocation KWLoc,
diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp
index f50d4df2fe9ef..ddd5b73daee54 100644
--- a/clang/lib/Parse/ParseExprCXX.cpp
+++ b/clang/lib/Parse/ParseExprCXX.cpp
@@ -100,7 +100,8 @@ void Parser::CheckForTemplateAndDigraph(Token &Next, ParsedType ObjectType,
bool MemberOfUnknownSpecialization;
if (!Actions.isTemplateName(getCurScope(), SS, /*hasTemplateKeyword=*/false,
TemplateName, ObjectType, EnteringContext,
- Template, MemberOfUnknownSpecialization))
+ Template, MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false, /*MayBeNNS=*/true))
return;
FixDigraph(*this, PP, Next, SecondToken, tok::unknown,
@@ -353,7 +354,8 @@ bool Parser::ParseOptionalCXXScopeSpecifier(
TemplateTy Template;
TemplateNameKind TNK = Actions.ActOnTemplateName(
getCurScope(), SS, TemplateKWLoc, TemplateName, ObjectType,
- EnteringContext, Template, /*AllowInjectedClassName*/ true);
+ EnteringContext, Template, /*AllowInjectedClassName*/true,
+ /*MayBeNNS=*/true);
if (AnnotateTemplateIdToken(Template, TNK, SS, TemplateKWLoc,
TemplateName, false))
return true;
@@ -405,7 +407,6 @@ bool Parser::ParseOptionalCXXScopeSpecifier(
: TemplateId->TemplateNameLoc;
SS.SetInvalid(SourceRange(StartLoc, CCLoc));
}
-
continue;
}
@@ -534,12 +535,15 @@ bool Parser::ParseOptionalCXXScopeSpecifier(
ObjectType,
EnteringContext,
Template,
- MemberOfUnknownSpecialization)) {
+ MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false,
+ /*MayBeNNS=*/true)) {
// If lookup didn't find anything, we treat the name as a template-name
// anyway. C++20 requires this, and in prior language modes it improves
// error recovery. But before we commit to this, check that we actually
// have something that looks like a template-argument-list next.
- if (!IsTypename && TNK == TNK_Undeclared_template &&
+ if (!IsTypename && (TNK == TNK_Undeclared_template ||
+ (!HasScopeSpecifier && ObjectType)) &&
isTemplateArgumentList(1) == TPResult::False)
break;
@@ -1917,12 +1921,35 @@ Parser::ParseCXXPseudoDestructor(Expr *Base, SourceLocation OpLoc,
// void f(auto *p) { p->~X<int>(); }
// ... but there's no ambiguity, and nowhere to write 'template' in such an
// example, so we accept it anyway.
+ #if 1
if (Tok.is(tok::less) &&
ParseUnqualifiedIdTemplateId(
SS, ObjectType, Base && Base->containsErrors(), SourceLocation(),
Name, NameLoc, false, SecondTypeName,
- /*AssumeTemplateId=*/true))
+ /*AssumeTemplateId=*/true, /*ForDestructor=*/true))
return ExprError();
+ #endif
+ #if 0
+ if (Tok.is(tok::less)) {
+ TemplateTy Template;
+ TemplateNameKind TNK = Actions.ActOnTemplateName(
+ getCurScope(), SS, /*TemplateKWLoc=*/SourceLocation(),
+ SecondTypeName, ObjectType,
+ /*EnteringContext=*/false, Template,
+ /*AllowInjectedClassName*/true,
+ /*MayBeNNS=*/true);
+ if (TNK == TNK_Non_template)
+ return ExprError();
+
+ if (AnnotateTemplateIdToken(Template, TNK, SS,
+ /*TemplateKWLoc=*/SourceLocation(),
+ SecondTypeName, /*AllowTypeAnnotation=*/false))
+ return ExprError();
+ assert(Tok.is(tok::annot_template_id));
+ SecondTypeName.setTemplateId(takeTemplateIdAnnotation(Tok));
+ ConsumeAnnotationToken();
+ }
+ #endif
return Actions.ActOnPseudoDestructorExpr(getCurScope(), Base, OpLoc, OpKind,
SS, FirstTypeName, CCLoc, TildeLoc,
@@ -2529,7 +2556,8 @@ bool Parser::ParseCXXTypeSpecifierSeq(DeclSpec &DS, DeclaratorContext Context) {
bool Parser::ParseUnqualifiedIdTemplateId(
CXXScopeSpec &SS, ParsedType ObjectType, bool ObjectHadErrors,
SourceLocation TemplateKWLoc, IdentifierInfo *Name, SourceLocation NameLoc,
- bool EnteringContext, UnqualifiedId &Id, bool AssumeTemplateId) {
+ bool EnteringContext, UnqualifiedId &Id, bool AssumeTemplateId,
+ bool ForDestructor) {
assert(Tok.is(tok::less) && "Expected '<' to finish parsing a template-id");
TemplateTy Template;
@@ -2543,13 +2571,16 @@ bool Parser::ParseUnqualifiedIdTemplateId(
// this template-id is used to form a nested-name-specifier or not.
TNK = Actions.ActOnTemplateName(getCurScope(), SS, TemplateKWLoc, Id,
ObjectType, EnteringContext, Template,
- /*AllowInjectedClassName*/ true);
+ /*AllowInjectedClassName=*/true,
+ ForDestructor);
} else {
bool MemberOfUnknownSpecialization;
TNK = Actions.isTemplateName(getCurScope(), SS,
TemplateKWLoc.isValid(), Id,
ObjectType, EnteringContext, Template,
- MemberOfUnknownSpecialization);
+ MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false,
+ ForDestructor);
// If lookup found nothing but we're assuming that this is a template
// name, double-check that makes sense syntactically before committing
// to it.
@@ -2582,7 +2613,7 @@ bool Parser::ParseUnqualifiedIdTemplateId(
}
TNK = Actions.ActOnTemplateName(
getCurScope(), SS, TemplateKWLoc, Id, ObjectType, EnteringContext,
- Template, /*AllowInjectedClassName*/ true);
+ Template, /*AllowInjectedClassName=*/true, ForDestructor);
} else if (TNK == TNK_Non_template) {
return false;
}
@@ -2609,12 +2640,15 @@ bool Parser::ParseUnqualifiedIdTemplateId(
if (ObjectType) {
TNK = Actions.ActOnTemplateName(
getCurScope(), SS, TemplateKWLoc, TemplateName, ObjectType,
- EnteringContext, Template, /*AllowInjectedClassName*/ true);
+ EnteringContext, Template, /*AllowInjectedClassName=*/true,
+ /*MayBeNNS=*/true);
} else {
TNK = Actions.isTemplateName(getCurScope(), SS, TemplateKWLoc.isValid(),
TemplateName, ObjectType,
EnteringContext, Template,
- MemberOfUnknownSpecialization);
+ MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false,
+ /*MayBeNNS=*/true);
if (TNK == TNK_Non_template && !Id.DestructorName.get()) {
Diag(NameLoc, diag::err_destructor_template_id)
@@ -3025,7 +3059,7 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), Id, IdLoc,
- EnteringContext, Result, TemplateSpecified);
+ EnteringContext, Result, TemplateSpecified, /*ForDestructor=*/false);
if (TemplateSpecified) {
TemplateNameKind TNK =
@@ -3121,12 +3155,13 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), nullptr,
- SourceLocation(), EnteringContext, Result, TemplateSpecified);
+ SourceLocation(), EnteringContext, Result, TemplateSpecified,
+ /*ForDestructor=*/false);
else if (TemplateSpecified &&
Actions.ActOnTemplateName(
getCurScope(), SS, *TemplateKWLoc, Result, ObjectType,
EnteringContext, Template,
- /*AllowInjectedClassName*/ true) == TNK_Non_template)
+ /*AllowInjectedClassName=*/true) == TNK_Non_template)
return true;
return false;
@@ -3217,7 +3252,8 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), ClassName,
- ClassNameLoc, EnteringContext, Result, TemplateSpecified);
+ ClassNameLoc, EnteringContext, Result, TemplateSpecified,
+ /*ForDestructor=*/true);
}
// Note that this is a destructor name.
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index b749f5c814a40..0e27e03479319 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -181,7 +181,8 @@ TemplateNameKind Sema::isTemplateName(Scope *S,
bool EnteringContext,
TemplateTy &TemplateResult,
bool &MemberOfUnknownSpecialization,
- bool Disambiguation) {
+ bool Disambiguation,
+ bool MayBeNNS) {
assert(getLangOpts().CPlusPlus && "No template names in C!");
DeclarationName TName;
@@ -212,7 +213,8 @@ TemplateNameKind Sema::isTemplateName(Scope *S,
if (LookupTemplateName(R, S, SS, ObjectType, EnteringContext,
/*RequiredTemplate=*/SourceLocation(),
&AssumedTemplate,
- /*AllowTypoCorrection=*/!Disambiguation))
+ /*AllowTypoCorrection=*/!Disambiguation,
+ MayBeNNS))
return TNK_Non_template;
MemberOfUnknownSpecialization = R.wasNotFoundInCurrentInstantiation();
@@ -380,7 +382,8 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
QualType ObjectType, bool EnteringContext,
RequiredTemplateKind RequiredTemplate,
AssumedTemplateKind *ATK,
- bool AllowTypoCorrection) {
+ bool AllowTypoCorrection,
+ bool MayBeNNS) {
if (ATK)
*ATK = AssumedTemplateKind::None;
@@ -453,7 +456,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
}
bool LookupFirstQualifierInScope =
- Found.getLookupKind() != LookupMemberName && Found.empty() &&
+ MayBeNNS && Found.empty() &&
!ObjectType.isNull() && !IsDependent;
// FIXME: We should still do the lookup if the object expression is dependent,
@@ -5707,7 +5710,8 @@ TemplateNameKind Sema::ActOnTemplateName(Scope *S,
ParsedType ObjectType,
bool EnteringContext,
TemplateTy &Result,
- bool AllowInjectedClassName) {
+ bool AllowInjectedClassName,
+ bool MayBeNNS) {
if (TemplateKWLoc.isValid() && S && !S->getTemplateParamParent())
Diag(TemplateKWLoc,
getLangOpts().CPlusPlus11 ?
@@ -5744,7 +5748,8 @@ TemplateNameKind Sema::ActOnTemplateName(Scope *S,
bool MemberOfUnknownSpecialization;
TemplateNameKind TNK = isTemplateName(S, SS, TemplateKWLoc.isValid(), Name,
ObjectType, EnteringContext, Result,
- MemberOfUnknownSpecialization);
+ MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false, MayBeNNS);
if (TNK != TNK_Non_template) {
// We resolved this to a (non-dependent) template name. Return it.
auto *LookupRD = dyn_cast_or_null<CXXRecordDecl>(LookupCtx);
@@ -5783,7 +5788,8 @@ TemplateNameKind Sema::ActOnTemplateName(Scope *S,
? RequiredTemplateKind(TemplateKWLoc)
: TemplateNameIsRequired;
if (!LookupTemplateName(R, S, SS, ObjectType.get(), EnteringContext, RTK,
- /*ATK=*/nullptr, /*AllowTypoCorrection=*/false) &&
+ /*ATK=*/nullptr, /*AllowTypoCorrection=*/false,
+ MayBeNNS) &&
!R.isAmbiguous()) {
if (LookupCtx)
Diag(Name.getBeginLoc(), diag::err_no_member)
diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp
index 89d767b323011..64c5a16b2e4c3 100644
--- a/clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -1518,7 +1518,8 @@ namespace {
TemplateName TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
SourceLocation NameLoc,
QualType ObjectType = QualType(),
- bool AllowInjectedClassName = false);
+ bool AllowInjectedClassName = false,
+ bool MayBeNNS = false);
const CXXAssumeAttr *TransformCXXAssumeAttr(const CXXAssumeAttr *AA);
const LoopHintAttr *TransformLoopHintAttr(const LoopHintAttr *LH);
@@ -1950,7 +1951,7 @@ TemplateInstantiator::RebuildElaboratedType(SourceLocation KeywordLoc,
TemplateName TemplateInstantiator::TransformTemplateName(
CXXScopeSpec &SS, TemplateName Name, SourceLocation NameLoc,
- QualType ObjectType, bool AllowInjectedClassName) {
+ QualType ObjectType, bool AllowInjectedClassName, bool MayBeNNS) {
if (TemplateTemplateParmDecl *TTP
= dyn_cast_or_null<TemplateTemplateParmDecl>(Name.getAsTemplateDecl())) {
if (TTP->getDepth() < TemplateArgs.getNumLevels()) {
@@ -2022,7 +2023,7 @@ TemplateName TemplateInstantiator::TransformTemplateName(
}
return inherited::TransformTemplateName(SS, Name, NameLoc, ObjectType,
- AllowInjectedClassName);
+ AllowInjectedClassName, MayBeNNS);
}
ExprResult
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index 1a19db85e73ce..95cfe694bf317 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -587,7 +587,8 @@ class TreeTransform {
TemplateName TransformTemplateName(CXXScopeSpec &SS, TemplateName Name,
SourceLocation NameLoc,
QualType ObjectType = QualType(),
- bool AllowInjectedClassName = false);
+ bool AllowInjectedClassName = false,
+ bool MayBeNNS = false);
/// Transform the given template argument.
///
@@ -1137,7 +1138,8 @@ class TreeTransform {
CXXScopeSpec SS;
SS.Adopt(QualifierLoc);
TemplateName InstName = getDerived().RebuildTemplateName(
- SS, TemplateKWLoc, *Name, NameLoc, QualType(), AllowInjectedClassName);
+ SS, TemplateKWLoc, *Name, NameLoc, QualType(), AllowInjectedClassName,
+ /*MayBeNNS=*/false);
if (InstName.isNull())
return QualType();
@@ -1308,7 +1310,8 @@ class TreeTransform {
SourceLocation TemplateKWLoc,
const IdentifierInfo &Name,
SourceLocation NameLoc, QualType ObjectType,
- bool AllowInjectedClassName);
+ bool AllowInjectedClassName,
+ bool MayBeNNS);
/// Build a new template name given a nested name specifier and the
/// overloaded operator name that is referred to as a template.
@@ -4536,7 +4539,7 @@ ::TransformDeclarationNameInfo(const DeclarationNameInfo &NameInfo) {
template <typename Derived>
TemplateName TreeTransform<Derived>::TransformTemplateName(
CXXScopeSpec &SS, TemplateName Name, SourceLocation NameLoc,
- QualType ObjectType, bool AllowInjectedClassName) {
+ QualType ObjectType, bool AllowInjectedClassName, bool MayBeNNS) {
if (QualifiedTemplateName *QTN = Name.getAsQualifiedTemplateName()) {
TemplateDecl *Template = QTN->getUnderlyingTemplate().getAsTemplateDecl();
assert(Template && "qualified template name must refer to a template");
@@ -4574,7 +4577,7 @@ TemplateName TreeTransform<Derived>::TransformTemplateName(
if (DTN->isIdentifier()) {
return getDerived().RebuildTemplateName(
SS, TemplateKWLoc, *DTN->getIdentifier(), NameLoc, ObjectType,
- AllowInjectedClassName);
+ AllowInjectedClassName, MayBeNNS);
}
return getDerived().RebuildTemplateName(SS, TemplateKWLoc,
@@ -5155,7 +5158,7 @@ TypeSourceInfo *TreeTransform<Derived>::TransformTSIInObjectScope(
TemplateName Template = getDerived().TransformTemplateName(
SS, SpecTL.getTypePtr()->getTemplateName(), SpecTL.getTemplateNameLoc(),
- ObjectType, /*AllowInjectedClassName=*/true);
+ ObjectType, /*AllowInjectedClassName=*/true, /*MayBeNNS=*/true);
if (Template.isNull())
return nullptr;
@@ -5169,7 +5172,7 @@ TypeSourceInfo *TreeTransform<Derived>::TransformTSIInObjectScope(
SS, SpecTL.getTemplateKeywordLoc(),
*SpecTL.getTypePtr()->getIdentifier(), SpecTL.getTemplateNameLoc(),
ObjectType,
- /*AllowInjectedClassName=*/true);
+ /*AllowInjectedClassName=*/true, /*MayBeNNS=*/true);
if (Template.isNull())
return nullptr;
@@ -16214,14 +16217,15 @@ TreeTransform<Derived>::RebuildTemplateName(CXXScopeSpec &SS,
template <typename Derived>
TemplateName TreeTransform<Derived>::RebuildTemplateName(
CXXScopeSpec &SS, SourceLocation TemplateKWLoc, const IdentifierInfo &Name,
- SourceLocation NameLoc, QualType ObjectType, bool AllowInjectedClassName) {
+ SourceLocation NameLoc, QualType ObjectType, bool AllowInjectedClassName,
+ bool MayBeNNS) {
UnqualifiedId TemplateName;
TemplateName.setIdentifier(&Name, NameLoc);
Sema::TemplateTy Template;
getSema().ActOnTemplateName(/*Scope=*/nullptr, SS, TemplateKWLoc,
TemplateName, ParsedType::make(ObjectType),
/*EnteringContext=*/false, Template,
- AllowInjectedClassName);
+ AllowInjectedClassName, MayBeNNS);
return Template.get();
}
diff --git a/clang/test/CXX/drs/cwg3xx.cpp b/clang/test/CXX/drs/cwg3xx.cpp
index a10ed95941ba4..54c97d2c7860f 100644
--- a/clang/test/CXX/drs/cwg3xx.cpp
+++ b/clang/test/CXX/drs/cwg3xx.cpp
@@ -443,7 +443,7 @@ namespace cwg329 { // cwg329: 3.5
// expected-note@#cwg329-b {{in instantiation of template class 'cwg329::A<char>' requested here}}
// expected-note@#cwg329-i {{previous definition is here}}
};
- A<int> a;
+ A<int> a;
A<char> b; // #cwg329-b
void test() {
@@ -684,9 +684,9 @@ namespace cwg341 { // cwg341: sup 1708
namespace B {
extern "C" int &cwg341_a = cwg341_a;
// expected-error at -1 {{redefinition of 'cwg341_a'}}
- // expected-note@#cwg341_a {{previous definition is here}}
+ // expected-note@#cwg341_a {{previous definition is here}}
}
- extern "C" void cwg341_b(); // #cwg341_b
+ extern "C" void cwg341_b(); // #cwg341_b
}
int cwg341_a;
// expected-error at -1 {{declaration of 'cwg341_a' in global scope conflicts with declaration with C language linkage}}
@@ -704,7 +704,7 @@ namespace cwg341 {
// expected-error at -1 {{declaration of 'cwg341_d' with C language linkage conflicts with declaration in global scope}}
// expected-note@#cwg341_d {{declared in global scope here}}
- namespace A { extern "C" int cwg341_e; } // #cwg341_e
+ namespace A { extern "C" int cwg341_e; } // #cwg341_e
namespace B { extern "C" void cwg341_e(); }
// expected-error at -1 {{redefinition of 'cwg341_e' as different kind of symbol}}
// expected-note@#cwg341_e {{previous definition is here}}
@@ -1106,7 +1106,7 @@ namespace cwg364 { // cwg364: yes
}
// cwg366: yes
-#if "foo" // expected-error {{invalid token at start of a preprocessor expression}}
+#if "foo" // expected-error {{invalid token at start of a preprocessor expression}}
#endif
namespace cwg367 { // cwg367: yes
diff --git a/clang/test/CXX/drs/cwg4xx.cpp b/clang/test/CXX/drs/cwg4xx.cpp
index 98ff7553d989b..7598db4acf46a 100644
--- a/clang/test/CXX/drs/cwg4xx.cpp
+++ b/clang/test/CXX/drs/cwg4xx.cpp
@@ -20,7 +20,7 @@ namespace cwg400 { // cwg400: yes
struct A { int a; struct a {}; }; // #cwg400-A
struct B { int a; struct a {}; }; // #cwg400-B
struct C : A, B { using A::a; struct a b; };
- struct D : A, B {
+ struct D : A, B {
using A::a;
// FIXME: we should issue a single diagnostic
using B::a; // #cwg400-using-B-a
>From a02df5f6dcf41fc1401a3300e5fb658ac13ae479 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 4 Jun 2024 08:34:10 -0400
Subject: [PATCH 14/26] [FOLD] pass TildeLoc instead of bool
---
clang/include/clang/Parse/Parser.h | 4 ++--
clang/lib/Parse/ParseExprCXX.cpp | 36 ++++++++++++++++--------------
2 files changed, 21 insertions(+), 19 deletions(-)
diff --git a/clang/include/clang/Parse/Parser.h b/clang/include/clang/Parse/Parser.h
index da8a18e04d8a6..af6683e92433b 100644
--- a/clang/include/clang/Parse/Parser.h
+++ b/clang/include/clang/Parse/Parser.h
@@ -3372,12 +3372,12 @@ class Parser : public CodeCompletionHandler {
ParsedType ObjectType,
bool ObjectHadErrors,
SourceLocation TemplateKWLoc,
+ SourceLocation TildeLoc,
IdentifierInfo *Name,
SourceLocation NameLoc,
bool EnteringContext,
UnqualifiedId &Id,
- bool AssumeTemplateId,
- bool ForDestructor);
+ bool AssumeTemplateId);
bool ParseUnqualifiedIdOperator(CXXScopeSpec &SS, bool EnteringContext,
ParsedType ObjectType,
UnqualifiedId &Result);
diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp
index ddd5b73daee54..aa04daefa41ac 100644
--- a/clang/lib/Parse/ParseExprCXX.cpp
+++ b/clang/lib/Parse/ParseExprCXX.cpp
@@ -1912,6 +1912,7 @@ Parser::ParseCXXPseudoDestructor(Expr *Base, SourceLocation OpLoc,
IdentifierInfo *Name = Tok.getIdentifierInfo();
SourceLocation NameLoc = ConsumeToken();
SecondTypeName.setIdentifier(Name, NameLoc);
+ // SecondTypeName.setDestructorName(TildeLoc, nullptr, NameLoc);
// If there is a '<', the second type name is a template-id. Parse
// it as such.
@@ -1924,9 +1925,10 @@ Parser::ParseCXXPseudoDestructor(Expr *Base, SourceLocation OpLoc,
#if 1
if (Tok.is(tok::less) &&
ParseUnqualifiedIdTemplateId(
- SS, ObjectType, Base && Base->containsErrors(), SourceLocation(),
+ SS, ObjectType, Base && Base->containsErrors(),
+ /*TemplateKWLoc=*/SourceLocation(), TildeLoc,
Name, NameLoc, false, SecondTypeName,
- /*AssumeTemplateId=*/true, /*ForDestructor=*/true))
+ /*AssumeTemplateId=*/true))
return ExprError();
#endif
#if 0
@@ -2555,9 +2557,9 @@ bool Parser::ParseCXXTypeSpecifierSeq(DeclSpec &DS, DeclaratorContext Context) {
/// \returns true if a parse error occurred, false otherwise.
bool Parser::ParseUnqualifiedIdTemplateId(
CXXScopeSpec &SS, ParsedType ObjectType, bool ObjectHadErrors,
- SourceLocation TemplateKWLoc, IdentifierInfo *Name, SourceLocation NameLoc,
- bool EnteringContext, UnqualifiedId &Id, bool AssumeTemplateId,
- bool ForDestructor) {
+ SourceLocation TemplateKWLoc, SourceLocation TildeLoc,
+ IdentifierInfo *Name, SourceLocation NameLoc, bool EnteringContext,
+ UnqualifiedId &Id, bool AssumeTemplateId) {
assert(Tok.is(tok::less) && "Expected '<' to finish parsing a template-id");
TemplateTy Template;
@@ -2572,7 +2574,7 @@ bool Parser::ParseUnqualifiedIdTemplateId(
TNK = Actions.ActOnTemplateName(getCurScope(), SS, TemplateKWLoc, Id,
ObjectType, EnteringContext, Template,
/*AllowInjectedClassName=*/true,
- ForDestructor);
+ TildeLoc.isValid());
} else {
bool MemberOfUnknownSpecialization;
TNK = Actions.isTemplateName(getCurScope(), SS,
@@ -2580,7 +2582,7 @@ bool Parser::ParseUnqualifiedIdTemplateId(
ObjectType, EnteringContext, Template,
MemberOfUnknownSpecialization,
/*Disambiguation=*/false,
- ForDestructor);
+ TildeLoc.isValid());
// If lookup found nothing but we're assuming that this is a template
// name, double-check that makes sense syntactically before committing
// to it.
@@ -2613,7 +2615,7 @@ bool Parser::ParseUnqualifiedIdTemplateId(
}
TNK = Actions.ActOnTemplateName(
getCurScope(), SS, TemplateKWLoc, Id, ObjectType, EnteringContext,
- Template, /*AllowInjectedClassName=*/true, ForDestructor);
+ Template, /*AllowInjectedClassName=*/true, TildeLoc.isValid());
} else if (TNK == TNK_Non_template) {
return false;
}
@@ -2710,7 +2712,7 @@ bool Parser::ParseUnqualifiedIdTemplateId(
if (Id.getKind() == UnqualifiedIdKind::IK_ConstructorName)
Id.setConstructorName(Type.get(), NameLoc, RAngleLoc);
else
- Id.setDestructorName(Id.StartLocation, Type.get(), RAngleLoc);
+ Id.setDestructorName(TildeLoc, Type.get(), RAngleLoc);
return false;
}
@@ -3058,8 +3060,9 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
if (Tok.is(tok::less))
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
- TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), Id, IdLoc,
- EnteringContext, Result, TemplateSpecified, /*ForDestructor=*/false);
+ TemplateKWLoc ? *TemplateKWLoc : SourceLocation(),
+ /*TildeLoc=*/SourceLocation(), Id, IdLoc,
+ EnteringContext, Result, TemplateSpecified);
if (TemplateSpecified) {
TemplateNameKind TNK =
@@ -3154,9 +3157,9 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
Tok.is(tok::less))
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
- TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), nullptr,
- SourceLocation(), EnteringContext, Result, TemplateSpecified,
- /*ForDestructor=*/false);
+ TemplateKWLoc ? *TemplateKWLoc : SourceLocation(),
+ /*TildeLoc=*/SourceLocation(), /*Name=*/nullptr,
+ /*NameLoc=*/SourceLocation(), EnteringContext, Result, TemplateSpecified);
else if (TemplateSpecified &&
Actions.ActOnTemplateName(
getCurScope(), SS, *TemplateKWLoc, Result, ObjectType,
@@ -3251,9 +3254,8 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
Result.setDestructorName(TildeLoc, nullptr, ClassNameLoc);
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
- TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), ClassName,
- ClassNameLoc, EnteringContext, Result, TemplateSpecified,
- /*ForDestructor=*/true);
+ TemplateKWLoc ? *TemplateKWLoc : SourceLocation(),
+ TildeLoc, ClassName, ClassNameLoc, EnteringContext, Result, TemplateSpecified);
}
// Note that this is a destructor name.
>From 6645c60d72bc283d41c00c9e01ffb86b37ad034f Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 4 Jun 2024 09:27:48 -0400
Subject: [PATCH 15/26] [FOLD] update tests
---
.../basic.lookup.classref/p1-cxx11.cpp | 4 +--
.../basic.lookup/basic.lookup.classref/p1.cpp | 4 +--
clang/test/CXX/temp/temp.names/p3-23.cpp | 25 +++++--------------
3 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp
index 476745537f691..11eb67fb4f159 100644
--- a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1-cxx11.cpp
@@ -65,9 +65,7 @@ namespace PR11856 {
if (it1->end < it1->end) { }
X *x;
- if (x->end < 7) { } // expected-error{{expected '>'}}
- // expected-note at -1{{to match this '<'}}
- // expected-error at -2{{expected unqualified-id}}
+ if (x->end < 7) { } // expected-error{{no member named 'end' in 'PR11856::X'}}
Y *y;
if (y->end < 7) { }
diff --git a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp
index cabf3f73830bc..5221b883f046c 100644
--- a/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp
+++ b/clang/test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp
@@ -96,9 +96,7 @@ namespace PR11856 {
if (it1->end < it1->end) { }
X *x;
- if (x->end < 7) { } // expected-error{{expected '>'}}
- // expected-note at -1{{to match this '<'}}
- // expected-error at -2{{expected unqualified-id}}
+ if (x->end < 7) { } // expected-error{{no member named 'end' in 'PR11856::X'}}
Y *y;
if (y->end < 7) { }
diff --git a/clang/test/CXX/temp/temp.names/p3-23.cpp b/clang/test/CXX/temp/temp.names/p3-23.cpp
index f652a81101162..b041bef88416d 100644
--- a/clang/test/CXX/temp/temp.names/p3-23.cpp
+++ b/clang/test/CXX/temp/temp.names/p3-23.cpp
@@ -92,16 +92,12 @@ namespace FoundSingleTemplate {
struct A1; // expected-note 2{{member 'A1' declared here}}
void g1() {
- this->f0<0; // expected-error {{expected '>'}}
- // expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
+ this->f0<0; // expected-error {{no member named 'f0' in 'B<T>'}}
this->f0<0>; // expected-error {{no member named 'f0' in 'B<T>'}}
this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
// expected-error at -1 {{expected ';' after expression}}
- this->A0<0; // expected-error {{expected '>'}}
- // expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
+ this->A0<0; // expected-error {{no member named 'A0' in 'B<T>'}}
this->A0<0>; // expected-error {{no member named 'A0' in 'B<T>'}}
this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
// expected-error at -1 {{expected ';' after expression}}
@@ -109,14 +105,12 @@ namespace FoundSingleTemplate {
this->f1<0; // expected-error {{expected '>'}}
// expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
this->f1<0>; // expected-error {{reference to non-static member function must be called}}
this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
// expected-error at -1 {{expected ';' after expression}}
this->A1<0; // expected-error {{expected '>'}}
// expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
this->A1<0>; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
this->A1<0>1; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
// expected-error at -1 {{expected ';' after expression}}
@@ -211,37 +205,30 @@ namespace FoundAmbiguousTemplate {
struct A1; // expected-note 2{{member 'A1' declared here}}
void g1() {
- this->f0<0; // expected-error {{expected '>'}}
- // expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
- // expected-error at -3 {{reference to 'f0' is ambiguous}}
+ this->f0<0; // expected-error {{no member named 'f0' in 'B<T>'}}
+ // expected-error at -1 {{reference to 'f0' is ambiguous}}
this->f0<0>; // expected-error {{no member named 'f0' in 'B<T>'}}
// expected-error at -1 {{reference to 'f0' is ambiguous}}
this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
// expected-error at -1 {{expected ';' after expression}}
// expected-error at -2 {{reference to 'f0' is ambiguous}}
- this->A0<0; // expected-error {{expected '>'}}
- // expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
- // expected-error at -3 {{reference to 'A0' is ambiguous}}
+ this->A0<0; // expected-error {{no member named 'A0' in 'B<T>'}}
+ // expected-error at -1 {{reference to 'A0' is ambiguous}}
this->A0<0>; // expected-error {{no member named 'A0' in 'B<T>'}}
// expected-error at -1 {{reference to 'A0' is ambiguous}}
this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
// expected-error at -1 {{expected ';' after expression}}
// expected-error at -2 {{reference to 'A0' is ambiguous}}
-
this->f1<0; // expected-error {{expected '>'}}
// expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
this->f1<0>; // expected-error {{reference to non-static member function must be called}}
this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
// expected-error at -1 {{expected ';' after expression}}
this->A1<0; // expected-error {{expected '>'}}
// expected-note at -1 {{to match this '<'}}
- // expected-error at -2 {{expected unqualified-id}}
this->A1<0>; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
this->A1<0>1; // expected-error {{cannot refer to member 'A1' in 'B<T>' with '->'}}
// expected-error at -1 {{expected ';' after expression}}
>From 2e601c8371b582fa86e0fd4e4bd7702f3cfca6b0 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 4 Jun 2024 09:28:06 -0400
Subject: [PATCH 16/26] [FOLD] format
---
clang/include/clang/Parse/Parser.h | 15 ++---
clang/include/clang/Sema/Sema.h | 31 ++++------
clang/lib/Parse/ParseExprCXX.cpp | 99 ++++++++++++++----------------
clang/lib/Sema/SemaTemplate.cpp | 46 +++++---------
clang/lib/Sema/TreeTransform.h | 3 +-
5 files changed, 83 insertions(+), 111 deletions(-)
diff --git a/clang/include/clang/Parse/Parser.h b/clang/include/clang/Parse/Parser.h
index af6683e92433b..b4f5270a35956 100644
--- a/clang/include/clang/Parse/Parser.h
+++ b/clang/include/clang/Parse/Parser.h
@@ -3368,16 +3368,11 @@ class Parser : public CodeCompletionHandler {
BaseResult ParseBaseSpecifier(Decl *ClassDecl);
AccessSpecifier getAccessSpecifierIfPresent() const;
- bool ParseUnqualifiedIdTemplateId(CXXScopeSpec &SS,
- ParsedType ObjectType,
- bool ObjectHadErrors,
- SourceLocation TemplateKWLoc,
- SourceLocation TildeLoc,
- IdentifierInfo *Name,
- SourceLocation NameLoc,
- bool EnteringContext,
- UnqualifiedId &Id,
- bool AssumeTemplateId);
+ bool ParseUnqualifiedIdTemplateId(
+ CXXScopeSpec &SS, ParsedType ObjectType, bool ObjectHadErrors,
+ SourceLocation TemplateKWLoc, SourceLocation TildeLoc,
+ IdentifierInfo *Name, SourceLocation NameLoc, bool EnteringContext,
+ UnqualifiedId &Id, bool AssumeTemplateId);
bool ParseUnqualifiedIdOperator(CXXScopeSpec &SS, bool EnteringContext,
ParsedType ObjectType,
UnqualifiedId &Result);
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index 0928afbaae6ec..384000aec5810 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -11123,17 +11123,14 @@ class Sema final : public SemaBase {
QualType ObjectType, bool EnteringContext,
RequiredTemplateKind RequiredTemplate = SourceLocation(),
AssumedTemplateKind *ATK = nullptr,
- bool AllowTypoCorrection = true,
- bool MayBeNNS = false);
-
- TemplateNameKind isTemplateName(Scope *S, CXXScopeSpec &SS,
- bool hasTemplateKeyword,
- const UnqualifiedId &Name,
- ParsedType ObjectType, bool EnteringContext,
- TemplateTy &Template,
- bool &MemberOfUnknownSpecialization,
- bool Disambiguation = false,
- bool MayBeNNS = false);
+ bool AllowTypoCorrection = true, bool MayBeNNS = false);
+
+ TemplateNameKind
+ isTemplateName(Scope *S, CXXScopeSpec &SS, bool hasTemplateKeyword,
+ const UnqualifiedId &Name, ParsedType ObjectType,
+ bool EnteringContext, TemplateTy &Template,
+ bool &MemberOfUnknownSpecialization,
+ bool Disambiguation = false, bool MayBeNNS = false);
/// Try to resolve an undeclared template name as a type template.
///
@@ -11462,13 +11459,11 @@ class Sema final : public SemaBase {
/// For example, given "x.MetaFun::template apply", the scope specifier
/// \p SS will be "MetaFun::", \p TemplateKWLoc contains the location
/// of the "template" keyword, and "apply" is the \p Name.
- TemplateNameKind ActOnTemplateName(Scope *S, CXXScopeSpec &SS,
- SourceLocation TemplateKWLoc,
- const UnqualifiedId &Name,
- ParsedType ObjectType,
- bool EnteringContext, TemplateTy &Template,
- bool AllowInjectedClassName = false,
- bool MayBeNNS = false);
+ TemplateNameKind
+ ActOnTemplateName(Scope *S, CXXScopeSpec &SS, SourceLocation TemplateKWLoc,
+ const UnqualifiedId &Name, ParsedType ObjectType,
+ bool EnteringContext, TemplateTy &Template,
+ bool AllowInjectedClassName = false, bool MayBeNNS = false);
DeclResult ActOnClassTemplateSpecialization(
Scope *S, unsigned TagSpec, TagUseKind TUK, SourceLocation KWLoc,
diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp
index aa04daefa41ac..d3e5b8048a821 100644
--- a/clang/lib/Parse/ParseExprCXX.cpp
+++ b/clang/lib/Parse/ParseExprCXX.cpp
@@ -354,7 +354,7 @@ bool Parser::ParseOptionalCXXScopeSpecifier(
TemplateTy Template;
TemplateNameKind TNK = Actions.ActOnTemplateName(
getCurScope(), SS, TemplateKWLoc, TemplateName, ObjectType,
- EnteringContext, Template, /*AllowInjectedClassName*/true,
+ EnteringContext, Template, /*AllowInjectedClassName*/ true,
/*MayBeNNS=*/true);
if (AnnotateTemplateIdToken(Template, TNK, SS, TemplateKWLoc,
TemplateName, false))
@@ -529,21 +529,19 @@ bool Parser::ParseOptionalCXXScopeSpecifier(
UnqualifiedId TemplateName;
TemplateName.setIdentifier(&II, Tok.getLocation());
bool MemberOfUnknownSpecialization;
- if (TemplateNameKind TNK = Actions.isTemplateName(getCurScope(), SS,
- /*hasTemplateKeyword=*/false,
- TemplateName,
- ObjectType,
- EnteringContext,
- Template,
- MemberOfUnknownSpecialization,
- /*Disambiguation=*/false,
- /*MayBeNNS=*/true)) {
+ if (TemplateNameKind TNK = Actions.isTemplateName(
+ getCurScope(), SS,
+ /*hasTemplateKeyword=*/false, TemplateName, ObjectType,
+ EnteringContext, Template, MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false,
+ /*MayBeNNS=*/true)) {
// If lookup didn't find anything, we treat the name as a template-name
// anyway. C++20 requires this, and in prior language modes it improves
// error recovery. But before we commit to this, check that we actually
// have something that looks like a template-argument-list next.
- if (!IsTypename && (TNK == TNK_Undeclared_template ||
- (!HasScopeSpecifier && ObjectType)) &&
+ if (!IsTypename &&
+ (TNK == TNK_Undeclared_template ||
+ (!HasScopeSpecifier && ObjectType)) &&
isTemplateArgumentList(1) == TPResult::False)
break;
@@ -1912,26 +1910,25 @@ Parser::ParseCXXPseudoDestructor(Expr *Base, SourceLocation OpLoc,
IdentifierInfo *Name = Tok.getIdentifierInfo();
SourceLocation NameLoc = ConsumeToken();
SecondTypeName.setIdentifier(Name, NameLoc);
- // SecondTypeName.setDestructorName(TildeLoc, nullptr, NameLoc);
+// SecondTypeName.setDestructorName(TildeLoc, nullptr, NameLoc);
- // If there is a '<', the second type name is a template-id. Parse
- // it as such.
- //
- // FIXME: This is not a context in which a '<' is assumed to start a template
- // argument list. This affects examples such as
- // void f(auto *p) { p->~X<int>(); }
- // ... but there's no ambiguity, and nowhere to write 'template' in such an
- // example, so we accept it anyway.
- #if 1
- if (Tok.is(tok::less) &&
- ParseUnqualifiedIdTemplateId(
- SS, ObjectType, Base && Base->containsErrors(),
- /*TemplateKWLoc=*/SourceLocation(), TildeLoc,
- Name, NameLoc, false, SecondTypeName,
- /*AssumeTemplateId=*/true))
+// If there is a '<', the second type name is a template-id. Parse
+// it as such.
+//
+// FIXME: This is not a context in which a '<' is assumed to start a template
+// argument list. This affects examples such as
+// void f(auto *p) { p->~X<int>(); }
+// ... but there's no ambiguity, and nowhere to write 'template' in such an
+// example, so we accept it anyway.
+#if 1
+ if (Tok.is(tok::less) && ParseUnqualifiedIdTemplateId(
+ SS, ObjectType, Base && Base->containsErrors(),
+ /*TemplateKWLoc=*/SourceLocation(), TildeLoc,
+ Name, NameLoc, false, SecondTypeName,
+ /*AssumeTemplateId=*/true))
return ExprError();
- #endif
- #if 0
+#endif
+#if 0
if (Tok.is(tok::less)) {
TemplateTy Template;
TemplateNameKind TNK = Actions.ActOnTemplateName(
@@ -1951,7 +1948,7 @@ Parser::ParseCXXPseudoDestructor(Expr *Base, SourceLocation OpLoc,
SecondTypeName.setTemplateId(takeTemplateIdAnnotation(Tok));
ConsumeAnnotationToken();
}
- #endif
+#endif
return Actions.ActOnPseudoDestructorExpr(getCurScope(), Base, OpLoc, OpKind,
SS, FirstTypeName, CCLoc, TildeLoc,
@@ -2557,9 +2554,9 @@ bool Parser::ParseCXXTypeSpecifierSeq(DeclSpec &DS, DeclaratorContext Context) {
/// \returns true if a parse error occurred, false otherwise.
bool Parser::ParseUnqualifiedIdTemplateId(
CXXScopeSpec &SS, ParsedType ObjectType, bool ObjectHadErrors,
- SourceLocation TemplateKWLoc, SourceLocation TildeLoc,
- IdentifierInfo *Name, SourceLocation NameLoc, bool EnteringContext,
- UnqualifiedId &Id, bool AssumeTemplateId) {
+ SourceLocation TemplateKWLoc, SourceLocation TildeLoc, IdentifierInfo *Name,
+ SourceLocation NameLoc, bool EnteringContext, UnqualifiedId &Id,
+ bool AssumeTemplateId) {
assert(Tok.is(tok::less) && "Expected '<' to finish parsing a template-id");
TemplateTy Template;
@@ -2577,12 +2574,10 @@ bool Parser::ParseUnqualifiedIdTemplateId(
TildeLoc.isValid());
} else {
bool MemberOfUnknownSpecialization;
- TNK = Actions.isTemplateName(getCurScope(), SS,
- TemplateKWLoc.isValid(), Id,
- ObjectType, EnteringContext, Template,
- MemberOfUnknownSpecialization,
- /*Disambiguation=*/false,
- TildeLoc.isValid());
+ TNK = Actions.isTemplateName(
+ getCurScope(), SS, TemplateKWLoc.isValid(), Id, ObjectType,
+ EnteringContext, Template, MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false, TildeLoc.isValid());
// If lookup found nothing but we're assuming that this is a template
// name, double-check that makes sense syntactically before committing
// to it.
@@ -2640,15 +2635,14 @@ bool Parser::ParseUnqualifiedIdTemplateId(
bool MemberOfUnknownSpecialization;
TemplateName.setIdentifier(Name, NameLoc);
if (ObjectType) {
- TNK = Actions.ActOnTemplateName(
- getCurScope(), SS, TemplateKWLoc, TemplateName, ObjectType,
- EnteringContext, Template, /*AllowInjectedClassName=*/true,
- /*MayBeNNS=*/true);
+ TNK = Actions.ActOnTemplateName(getCurScope(), SS, TemplateKWLoc,
+ TemplateName, ObjectType, EnteringContext,
+ Template, /*AllowInjectedClassName=*/true,
+ /*MayBeNNS=*/true);
} else {
TNK = Actions.isTemplateName(getCurScope(), SS, TemplateKWLoc.isValid(),
- TemplateName, ObjectType,
- EnteringContext, Template,
- MemberOfUnknownSpecialization,
+ TemplateName, ObjectType, EnteringContext,
+ Template, MemberOfUnknownSpecialization,
/*Disambiguation=*/false,
/*MayBeNNS=*/true);
@@ -3061,8 +3055,8 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
TemplateKWLoc ? *TemplateKWLoc : SourceLocation(),
- /*TildeLoc=*/SourceLocation(), Id, IdLoc,
- EnteringContext, Result, TemplateSpecified);
+ /*TildeLoc=*/SourceLocation(), Id, IdLoc, EnteringContext, Result,
+ TemplateSpecified);
if (TemplateSpecified) {
TemplateNameKind TNK =
@@ -3159,7 +3153,8 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
SS, ObjectType, ObjectHadErrors,
TemplateKWLoc ? *TemplateKWLoc : SourceLocation(),
/*TildeLoc=*/SourceLocation(), /*Name=*/nullptr,
- /*NameLoc=*/SourceLocation(), EnteringContext, Result, TemplateSpecified);
+ /*NameLoc=*/SourceLocation(), EnteringContext, Result,
+ TemplateSpecified);
else if (TemplateSpecified &&
Actions.ActOnTemplateName(
getCurScope(), SS, *TemplateKWLoc, Result, ObjectType,
@@ -3254,8 +3249,8 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType,
Result.setDestructorName(TildeLoc, nullptr, ClassNameLoc);
return ParseUnqualifiedIdTemplateId(
SS, ObjectType, ObjectHadErrors,
- TemplateKWLoc ? *TemplateKWLoc : SourceLocation(),
- TildeLoc, ClassName, ClassNameLoc, EnteringContext, Result, TemplateSpecified);
+ TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), TildeLoc,
+ ClassName, ClassNameLoc, EnteringContext, Result, TemplateSpecified);
}
// Note that this is a destructor name.
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index 0e27e03479319..c2d48bf34e72b 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -173,16 +173,12 @@ bool Sema::hasAnyAcceptableTemplateNames(LookupResult &R,
return false;
}
-TemplateNameKind Sema::isTemplateName(Scope *S,
- CXXScopeSpec &SS,
- bool hasTemplateKeyword,
- const UnqualifiedId &Name,
- ParsedType ObjectTypePtr,
- bool EnteringContext,
- TemplateTy &TemplateResult,
- bool &MemberOfUnknownSpecialization,
- bool Disambiguation,
- bool MayBeNNS) {
+TemplateNameKind
+Sema::isTemplateName(Scope *S, CXXScopeSpec &SS, bool hasTemplateKeyword,
+ const UnqualifiedId &Name, ParsedType ObjectTypePtr,
+ bool EnteringContext, TemplateTy &TemplateResult,
+ bool &MemberOfUnknownSpecialization, bool Disambiguation,
+ bool MayBeNNS) {
assert(getLangOpts().CPlusPlus && "No template names in C!");
DeclarationName TName;
@@ -213,8 +209,7 @@ TemplateNameKind Sema::isTemplateName(Scope *S,
if (LookupTemplateName(R, S, SS, ObjectType, EnteringContext,
/*RequiredTemplate=*/SourceLocation(),
&AssumedTemplate,
- /*AllowTypoCorrection=*/!Disambiguation,
- MayBeNNS))
+ /*AllowTypoCorrection=*/!Disambiguation, MayBeNNS))
return TNK_Non_template;
MemberOfUnknownSpecialization = R.wasNotFoundInCurrentInstantiation();
@@ -382,8 +377,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
QualType ObjectType, bool EnteringContext,
RequiredTemplateKind RequiredTemplate,
AssumedTemplateKind *ATK,
- bool AllowTypoCorrection,
- bool MayBeNNS) {
+ bool AllowTypoCorrection, bool MayBeNNS) {
if (ATK)
*ATK = AssumedTemplateKind::None;
@@ -456,8 +450,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
}
bool LookupFirstQualifierInScope =
- MayBeNNS && Found.empty() &&
- !ObjectType.isNull() && !IsDependent;
+ MayBeNNS && Found.empty() && !ObjectType.isNull() && !IsDependent;
// FIXME: We should still do the lookup if the object expression is dependent,
// but instead of using them we should store them via
@@ -5703,15 +5696,10 @@ ExprResult Sema::BuildQualifiedTemplateIdExpr(
return BuildTemplateIdExpr(SS, TemplateKWLoc, R, /*ADL=*/false, TemplateArgs);
}
-TemplateNameKind Sema::ActOnTemplateName(Scope *S,
- CXXScopeSpec &SS,
- SourceLocation TemplateKWLoc,
- const UnqualifiedId &Name,
- ParsedType ObjectType,
- bool EnteringContext,
- TemplateTy &Result,
- bool AllowInjectedClassName,
- bool MayBeNNS) {
+TemplateNameKind Sema::ActOnTemplateName(
+ Scope *S, CXXScopeSpec &SS, SourceLocation TemplateKWLoc,
+ const UnqualifiedId &Name, ParsedType ObjectType, bool EnteringContext,
+ TemplateTy &Result, bool AllowInjectedClassName, bool MayBeNNS) {
if (TemplateKWLoc.isValid() && S && !S->getTemplateParamParent())
Diag(TemplateKWLoc,
getLangOpts().CPlusPlus11 ?
@@ -5746,10 +5734,10 @@ TemplateNameKind Sema::ActOnTemplateName(Scope *S,
// "template" keyword is now permitted). We follow the C++0x
// rules, even in C++03 mode with a warning, retroactively applying the DR.
bool MemberOfUnknownSpecialization;
- TemplateNameKind TNK = isTemplateName(S, SS, TemplateKWLoc.isValid(), Name,
- ObjectType, EnteringContext, Result,
- MemberOfUnknownSpecialization,
- /*Disambiguation=*/false, MayBeNNS);
+ TemplateNameKind TNK =
+ isTemplateName(S, SS, TemplateKWLoc.isValid(), Name, ObjectType,
+ EnteringContext, Result, MemberOfUnknownSpecialization,
+ /*Disambiguation=*/false, MayBeNNS);
if (TNK != TNK_Non_template) {
// We resolved this to a (non-dependent) template name. Return it.
auto *LookupRD = dyn_cast_or_null<CXXRecordDecl>(LookupCtx);
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index 95cfe694bf317..2b6c6d11dee9c 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -1310,8 +1310,7 @@ class TreeTransform {
SourceLocation TemplateKWLoc,
const IdentifierInfo &Name,
SourceLocation NameLoc, QualType ObjectType,
- bool AllowInjectedClassName,
- bool MayBeNNS);
+ bool AllowInjectedClassName, bool MayBeNNS);
/// Build a new template name given a nested name specifier and the
/// overloaded operator name that is referred to as a template.
>From 6f2d78fa282ee9670884c75f0621d1548968381e Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 4 Jun 2024 09:33:30 -0400
Subject: [PATCH 17/26] [FOLD] reorder diags
---
clang/test/CXX/temp/temp.names/p3-23.cpp | 36 ++++++++++++------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/clang/test/CXX/temp/temp.names/p3-23.cpp b/clang/test/CXX/temp/temp.names/p3-23.cpp
index b041bef88416d..27c24e1d61706 100644
--- a/clang/test/CXX/temp/temp.names/p3-23.cpp
+++ b/clang/test/CXX/temp/temp.names/p3-23.cpp
@@ -12,8 +12,8 @@ namespace FoundNothing {
struct A {
void f1() {
this->x<0; // expected-error {{no member named 'x' in 'A<T>'}}
- this->x<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{no member named 'x' in 'A<T>'}}
+ this->x<0>; // expected-error {{no member named 'x' in 'A<T>'}}
+ // expected-error at -1 {{expected expression}}
this->x<0>1; // expected-error {{no member named 'x' in 'A<T>'}}
}
};
@@ -43,23 +43,23 @@ namespace FoundSingleNonTemplate {
void g1() {
this->f0<0; // expected-error {{no member named 'f0' in 'B<T>'}}
- this->f0<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{no member named 'f0' in 'B<T>'}}
+ this->f0<0>; // expected-error {{no member named 'f0' in 'B<T>'}}
+ // expected-error at -1 {{expected expression}}
this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
this->A0<0; // expected-error {{no member named 'A0' in 'B<T>'}}
- this->A0<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{no member named 'A0' in 'B<T>'}}
+ this->A0<0>; // expected-error {{no member named 'A0' in 'B<T>'}}
+ // expected-error at -1 {{expected expression}}
this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
this->f1<0; // expected-error {{reference to non-static member function must be called}}
- this->f1<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{reference to non-static member function must be called}}
+ this->f1<0>; // expected-error {{reference to non-static member function must be called}}
+ // expected-error at -1 {{expected expression}}
this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
this->A1<0; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
- this->A1<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ // expected-error at -1 {{expected expression}}
this->A1<0>1; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
}
};
@@ -148,23 +148,23 @@ namespace FoundAmbiguousNonTemplate {
void g1() {
this->f0<0; // expected-error {{no member named 'f0' in 'B<T>'}}
- this->f0<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{no member named 'f0' in 'B<T>'}}
+ this->f0<0>; // expected-error {{no member named 'f0' in 'B<T>'}}
+ // expected-error at -1 {{expected expression}}
this->f0<0>1; // expected-error {{no member named 'f0' in 'B<T>'}}
this->A0<0; // expected-error {{no member named 'A0' in 'B<T>'}}
- this->A0<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{no member named 'A0' in 'B<T>'}}
+ this->A0<0>; // expected-error {{no member named 'A0' in 'B<T>'}}
+ // expected-error at -1 {{expected expression}}
this->A0<0>1; // expected-error {{no member named 'A0' in 'B<T>'}}
this->f1<0; // expected-error {{reference to non-static member function must be called}}
- this->f1<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{reference to non-static member function must be called}}
+ this->f1<0>; // expected-error {{reference to non-static member function must be called}}
+ // expected-error at -1 {{expected expression}}
this->f1<0>1; // expected-error {{reference to non-static member function must be called}}
this->A1<0; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
- this->A1<0>; // expected-error {{expected expression}}
- // expected-error at -1 {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ this->A1<0>; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
+ // expected-error at -1 {{expected expression}}
this->A1<0>1; // expected-error {{cannot refer to type member 'A1' in 'B<T>' with '->'}}
}
};
>From a43893ff61d6707d073028f253c5a449d858c95c Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 4 Jun 2024 10:19:18 -0400
Subject: [PATCH 18/26] [FOLD] fix warning
---
clang/lib/AST/ExprCXX.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang/lib/AST/ExprCXX.cpp b/clang/lib/AST/ExprCXX.cpp
index 19ce3a3c5d8f9..9d2883a8debb7 100644
--- a/clang/lib/AST/ExprCXX.cpp
+++ b/clang/lib/AST/ExprCXX.cpp
@@ -1494,8 +1494,8 @@ CXXDependentScopeMemberExpr::CXXDependentScopeMemberExpr(
const TemplateArgumentListInfo *TemplateArgs)
: Expr(CXXDependentScopeMemberExprClass, Ctx.DependentTy, VK_LValue,
OK_Ordinary),
- Base(Base), BaseType(BaseType), OperatorLoc(OperatorLoc),
- MemberNameInfo(MemberNameInfo) {
+ Base(Base), BaseType(BaseType), MemberNameInfo(MemberNameInfo),
+ OperatorLoc(OperatorLoc) {
CXXDependentScopeMemberExprBits.IsArrow = IsArrow;
CXXDependentScopeMemberExprBits.HasQualifier = QualifierLoc.hasQualifier();
CXXDependentScopeMemberExprBits.NumUnqualifiedLookups =
>From 174ef5974adc0b0eaf0debea08f133588541901d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 4 Jun 2024 10:22:13 -0400
Subject: [PATCH 19/26] [FOLD] cleanups
---
clang/lib/Parse/ParseExprCXX.cpp | 40 +++++++-------------------------
1 file changed, 8 insertions(+), 32 deletions(-)
diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp
index d3e5b8048a821..17be090dea3fd 100644
--- a/clang/lib/Parse/ParseExprCXX.cpp
+++ b/clang/lib/Parse/ParseExprCXX.cpp
@@ -1910,45 +1910,21 @@ Parser::ParseCXXPseudoDestructor(Expr *Base, SourceLocation OpLoc,
IdentifierInfo *Name = Tok.getIdentifierInfo();
SourceLocation NameLoc = ConsumeToken();
SecondTypeName.setIdentifier(Name, NameLoc);
-// SecondTypeName.setDestructorName(TildeLoc, nullptr, NameLoc);
-// If there is a '<', the second type name is a template-id. Parse
-// it as such.
-//
-// FIXME: This is not a context in which a '<' is assumed to start a template
-// argument list. This affects examples such as
-// void f(auto *p) { p->~X<int>(); }
-// ... but there's no ambiguity, and nowhere to write 'template' in such an
-// example, so we accept it anyway.
-#if 1
+ // If there is a '<', the second type name is a template-id. Parse
+ // it as such.
+ //
+ // FIXME: This is not a context in which a '<' is assumed to start a template
+ // argument list. This affects examples such as
+ // void f(auto *p) { p->~X<int>(); }
+ // ... but there's no ambiguity, and nowhere to write 'template' in such an
+ // example, so we accept it anyway
if (Tok.is(tok::less) && ParseUnqualifiedIdTemplateId(
SS, ObjectType, Base && Base->containsErrors(),
/*TemplateKWLoc=*/SourceLocation(), TildeLoc,
Name, NameLoc, false, SecondTypeName,
/*AssumeTemplateId=*/true))
return ExprError();
-#endif
-#if 0
- if (Tok.is(tok::less)) {
- TemplateTy Template;
- TemplateNameKind TNK = Actions.ActOnTemplateName(
- getCurScope(), SS, /*TemplateKWLoc=*/SourceLocation(),
- SecondTypeName, ObjectType,
- /*EnteringContext=*/false, Template,
- /*AllowInjectedClassName*/true,
- /*MayBeNNS=*/true);
- if (TNK == TNK_Non_template)
- return ExprError();
-
- if (AnnotateTemplateIdToken(Template, TNK, SS,
- /*TemplateKWLoc=*/SourceLocation(),
- SecondTypeName, /*AllowTypeAnnotation=*/false))
- return ExprError();
- assert(Tok.is(tok::annot_template_id));
- SecondTypeName.setTemplateId(takeTemplateIdAnnotation(Tok));
- ConsumeAnnotationToken();
- }
-#endif
return Actions.ActOnPseudoDestructorExpr(getCurScope(), Base, OpLoc, OpKind,
SS, FirstTypeName, CCLoc, TildeLoc,
>From 42c96ac681a43b064348d55128a38063229f729b Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Fri, 7 Jun 2024 15:12:53 -0400
Subject: [PATCH 20/26] [FOLD] use LookupParsedName for
LookupTemplateName/BuildNestedNameSpecifier
---
clang/lib/Sema/SemaCXXScopeSpec.cpp | 44 ++++++++++++++++++---
clang/lib/Sema/SemaTemplate.cpp | 59 +++++++++++++++++++++++++----
2 files changed, 89 insertions(+), 14 deletions(-)
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index 5a2afc60982d1..03474238f0796 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -422,6 +422,7 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
bool ErrorRecoveryLookup,
bool *IsCorrectedToColon,
bool OnlyNamespace) {
+ #if 0
if (IdInfo.Identifier->isEditorPlaceholder())
return true;
LookupResult Found(*this, IdInfo.Identifier, IdInfo.IdentifierLoc,
@@ -515,16 +516,25 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
LookupName(Found, S);
}
#endif
+#endif
- if (Found.isAmbiguous())
+
+ if (IdInfo.Identifier->isEditorPlaceholder())
return true;
+ if (IsCorrectedToColon)
+ *IsCorrectedToColon = false;
+
+ QualType ObjectType = GetTypeFromParser(IdInfo.ObjectType);
+ LookupResult Found(*this, IdInfo.Identifier, IdInfo.IdentifierLoc,
+ OnlyNamespace ? LookupNamespaceName
+ : LookupNestedNameSpecifierName);
+
+ LookupParsedName(Found, S, &SS, ObjectType,
+ /*AllowBuiltinCreation=*/false, EnteringContext);
// If we performed lookup into a dependent context and did not find anything,
// that's fine: just build a dependent nested-name-specifier.
- if (Found.empty() && isDependent &&
- !(LookupCtx && LookupCtx->isRecord() &&
- (!cast<CXXRecordDecl>(LookupCtx)->hasDefinition() ||
- !cast<CXXRecordDecl>(LookupCtx)->hasAnyDependentBases()))) {
+ if (Found.wasNotFoundInCurrentInstantiation()) {
// Don't speculate if we're just trying to improve error recovery.
if (ErrorRecoveryLookup)
return true;
@@ -537,13 +547,35 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
return false;
}
+ bool ObjectTypeSearchedInScope = false;
+ bool LookupFirstQualifierInScope =
+ Found.empty() && !ObjectType.isNull();
+
+ if (LookupFirstQualifierInScope) {
+ if (S) {
+ LookupName(Found, S);
+ } else if (!SS.getUnqualifiedLookups().empty()) {
+ Found.addAllDecls(SS.getUnqualifiedLookups());
+ Found.resolveKind();
+ }
+ ObjectTypeSearchedInScope = true;
+ }
+
+ if (Found.isAmbiguous())
+ return true;
+
+ DeclContext *LookupCtx = SS.isSet()
+ ? computeDeclContext(SS, EnteringContext)
+ : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
+
+
if (Found.empty() && !ErrorRecoveryLookup) {
// If identifier is not found as class-name-or-namespace-name, but is found
// as other entity, don't look for typos.
LookupResult R(*this, Found.getLookupNameInfo(), LookupOrdinaryName);
if (LookupCtx)
LookupQualifiedName(R, LookupCtx);
- else if (S && !isDependent)
+ else if (S)
LookupName(R, S);
if (!R.empty()) {
// Don't diagnose problems with this speculative lookup.
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index c2d48bf34e72b..5545823baca7a 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -386,6 +386,33 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
Found.setTemplateNameLookup(true);
+ // Template names cannot appear inside an Objective-C class or object type
+ // or a vector type.
+ //
+ // FIXME: This is wrong. For example:
+ //
+ // template<typename T> using Vec = T __attribute__((ext_vector_type(4)));
+ // Vec<int> vi;
+ // vi.Vec<int>::~Vec<int>();
+ //
+ // ... should be accepted but we will not treat 'Vec' as a template name
+ // here. The right thing to do would be to check if the name is a valid
+ // vector component name, and look up a template name if not. And similarly
+ // for lookups into Objective-C class and object types, where the same
+ // problem can arise.
+ if (!ObjectType.isNull() &&
+ (ObjectType->isVectorType() || ObjectType->isObjCObjectOrInterfaceType())) {
+ Found.clear();
+ return false;
+ }
+
+ LookupParsedName(Found, S, &SS, ObjectType,
+ /*AllowBuiltinCreation=*/false, EnteringContext);
+
+ if (Found.wasNotFoundInCurrentInstantiation())
+ return false;
+
+ #if 0
// Determine where to perform name lookup
DeclContext *LookupCtx = nullptr;
bool IsDependent = false;
@@ -448,10 +475,13 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
// unknown specialization when we come to instantiate the template.
IsDependent |= Found.wasNotFoundInCurrentInstantiation();
}
+ #endif
+
+ #if 0
+ bool ObjectTypeSearchedInScope = false;
bool LookupFirstQualifierInScope =
MayBeNNS && Found.empty() && !ObjectType.isNull() && !IsDependent;
-
// FIXME: We should still do the lookup if the object expression is dependent,
// but instead of using them we should store them via
// setFirstQualifierFoundInScope and pretend we found nothing.
@@ -478,6 +508,21 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
IsDependent |= Found.wasNotFoundInCurrentInstantiation();
}
+ #endif
+
+ bool ObjectTypeSearchedInScope = false;
+ bool LookupFirstQualifierInScope =
+ MayBeNNS && Found.empty() && !ObjectType.isNull();
+
+ if (LookupFirstQualifierInScope) {
+ if (S) {
+ LookupName(Found, S);
+ } else if (!SS.getUnqualifiedLookups().empty()) {
+ Found.addAllDecls(SS.getUnqualifiedLookups());
+ Found.resolveKind();
+ }
+ ObjectTypeSearchedInScope = true;
+ }
if (Found.isAmbiguous())
return false;
@@ -496,7 +541,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
getLangOpts().CPlusPlus20 && llvm::all_of(Found, [](NamedDecl *ND) {
return isa<FunctionDecl>(ND->getUnderlyingDecl());
});
- if (AllFunctions || (Found.empty() && !IsDependent)) {
+ if (AllFunctions || Found.empty()) {
// If lookup found any functions, or if this is a name that can only be
// used for a function, then strongly assume this is a function
// template-id.
@@ -508,11 +553,14 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
}
}
- if (Found.empty() && !IsDependent && AllowTypoCorrection) {
+ if (Found.empty() && AllowTypoCorrection) {
// If we did not find any names, and this is not a disambiguation, attempt
// to correct any typos.
DeclarationName Name = Found.getLookupName();
Found.clear();
+ DeclContext *LookupCtx = SS.isSet()
+ ? computeDeclContext(SS, EnteringContext)
+ : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
// Simple filter callback that, for keywords, only accepts the C++ *_cast
DefaultFilterCCC FilterCCC{};
FilterCCC.WantTypeSpecifiers = false;
@@ -547,11 +595,6 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
Found.empty() ? nullptr : Found.getRepresentativeDecl();
FilterAcceptableTemplateNames(Found);
if (Found.empty()) {
- if (IsDependent) {
- Found.setNotFoundInCurrentInstantiation();
- return false;
- }
-
// If a 'template' keyword was used, a lookup that finds only non-template
// names is an error.
if (ExampleLookupResult && RequiredTemplate) {
>From 971d758a3306d43cde9abc8f931c36d5966190d3 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 18 Jun 2024 11:34:56 -0400
Subject: [PATCH 21/26] [FOLD] nns error correction lookup uses
LookupParsedName
---
clang/lib/Sema/SemaCXXScopeSpec.cpp | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index 03474238f0796..15b6f3e4ca689 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -564,19 +564,13 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
if (Found.isAmbiguous())
return true;
- DeclContext *LookupCtx = SS.isSet()
- ? computeDeclContext(SS, EnteringContext)
- : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
-
-
if (Found.empty() && !ErrorRecoveryLookup) {
// If identifier is not found as class-name-or-namespace-name, but is found
// as other entity, don't look for typos.
LookupResult R(*this, Found.getLookupNameInfo(), LookupOrdinaryName);
- if (LookupCtx)
- LookupQualifiedName(R, LookupCtx);
- else if (S)
- LookupName(R, S);
+ LookupParsedName(R, S, &SS, ObjectType,
+ /*AllowBuiltinCreation=*/false, EnteringContext);
+
if (!R.empty()) {
// Don't diagnose problems with this speculative lookup.
R.suppressDiagnostics();
@@ -603,6 +597,10 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
}
}
+ DeclContext *LookupCtx = SS.isSet()
+ ? computeDeclContext(SS, EnteringContext)
+ : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
+
if (Found.empty() && !ErrorRecoveryLookup && !getLangOpts().MSVCCompat) {
// We haven't found anything, and we're not recovering from a
// different kind of error, so look for typos.
>From 1983f3fe505cac193c0fef1bfe084e8d80fed90b Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Wed, 19 Jun 2024 09:38:18 -0400
Subject: [PATCH 22/26] [FOLD] address review comments
---
clang/lib/Sema/TreeTransform.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h
index 2b6c6d11dee9c..06fe2d748f48a 100644
--- a/clang/lib/Sema/TreeTransform.h
+++ b/clang/lib/Sema/TreeTransform.h
@@ -2922,7 +2922,7 @@ class TreeTransform {
return getSema().BuildMemberReferenceExpr(Base, BaseType, OpLoc, isArrow,
SS, TemplateKWLoc, R,
ExplicitTemplateArgs,
- /*S*/ nullptr);
+ /*S=*/nullptr);
}
/// Build a new binary operator expression.
>From d93983920f4729c7117bf8fc705cfca1eca6726d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Wed, 19 Jun 2024 09:46:03 -0400
Subject: [PATCH 23/26] [FOLD] format
---
clang/lib/Sema/SemaCXXScopeSpec.cpp | 13 ++++++-------
clang/lib/Sema/SemaTemplate.cpp | 20 ++++++++++----------
2 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index 15b6f3e4ca689..16c43812028aa 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -422,7 +422,7 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
bool ErrorRecoveryLookup,
bool *IsCorrectedToColon,
bool OnlyNamespace) {
- #if 0
+#if 0
if (IdInfo.Identifier->isEditorPlaceholder())
return true;
LookupResult Found(*this, IdInfo.Identifier, IdInfo.IdentifierLoc,
@@ -518,7 +518,6 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
#endif
#endif
-
if (IdInfo.Identifier->isEditorPlaceholder())
return true;
if (IsCorrectedToColon)
@@ -548,8 +547,7 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
}
bool ObjectTypeSearchedInScope = false;
- bool LookupFirstQualifierInScope =
- Found.empty() && !ObjectType.isNull();
+ bool LookupFirstQualifierInScope = Found.empty() && !ObjectType.isNull();
if (LookupFirstQualifierInScope) {
if (S) {
@@ -597,9 +595,10 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
}
}
- DeclContext *LookupCtx = SS.isSet()
- ? computeDeclContext(SS, EnteringContext)
- : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
+ DeclContext *LookupCtx =
+ SS.isSet()
+ ? computeDeclContext(SS, EnteringContext)
+ : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
if (Found.empty() && !ErrorRecoveryLookup && !getLangOpts().MSVCCompat) {
// We haven't found anything, and we're not recovering from a
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index 5545823baca7a..2e9ae86d75cf3 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -400,8 +400,8 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
// vector component name, and look up a template name if not. And similarly
// for lookups into Objective-C class and object types, where the same
// problem can arise.
- if (!ObjectType.isNull() &&
- (ObjectType->isVectorType() || ObjectType->isObjCObjectOrInterfaceType())) {
+ if (!ObjectType.isNull() && (ObjectType->isVectorType() ||
+ ObjectType->isObjCObjectOrInterfaceType())) {
Found.clear();
return false;
}
@@ -412,7 +412,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
if (Found.wasNotFoundInCurrentInstantiation())
return false;
- #if 0
+#if 0
// Determine where to perform name lookup
DeclContext *LookupCtx = nullptr;
bool IsDependent = false;
@@ -475,10 +475,9 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
// unknown specialization when we come to instantiate the template.
IsDependent |= Found.wasNotFoundInCurrentInstantiation();
}
- #endif
+#endif
-
- #if 0
+#if 0
bool ObjectTypeSearchedInScope = false;
bool LookupFirstQualifierInScope =
MayBeNNS && Found.empty() && !ObjectType.isNull() && !IsDependent;
@@ -508,7 +507,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
IsDependent |= Found.wasNotFoundInCurrentInstantiation();
}
- #endif
+#endif
bool ObjectTypeSearchedInScope = false;
bool LookupFirstQualifierInScope =
@@ -558,9 +557,10 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
// to correct any typos.
DeclarationName Name = Found.getLookupName();
Found.clear();
- DeclContext *LookupCtx = SS.isSet()
- ? computeDeclContext(SS, EnteringContext)
- : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
+ DeclContext *LookupCtx =
+ SS.isSet()
+ ? computeDeclContext(SS, EnteringContext)
+ : (!ObjectType.isNull() ? computeDeclContext(ObjectType) : nullptr);
// Simple filter callback that, for keywords, only accepts the C++ *_cast
DefaultFilterCCC FilterCCC{};
FilterCCC.WantTypeSpecifiers = false;
>From 4d62132cf5583b870ee905d24086f2068391c8c7 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Wed, 19 Jun 2024 11:30:36 -0400
Subject: [PATCH 24/26] [FOLD] some cleanup + comments
---
clang/include/clang/Sema/Sema.h | 8 --
clang/lib/Sema/SemaCXXScopeSpec.cpp | 134 ++++++-------------------
clang/lib/Sema/SemaTemplate.cpp | 148 +++++++++-------------------
3 files changed, 78 insertions(+), 212 deletions(-)
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index 384000aec5810..85f0fc41a3257 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -2843,9 +2843,6 @@ class Sema final : public SemaBase {
/// \param EnteringContext If true, enter the context specified by the
/// nested-name-specifier.
/// \param SS Optional nested name specifier preceding the identifier.
- /// \param ScopeLookupResult Provides the result of name lookup within the
- /// scope of the nested-name-specifier that was computed at template
- /// definition time.
/// \param ErrorRecoveryLookup Specifies if the method is called to improve
/// error recovery and what kind of recovery is performed.
/// \param IsCorrectedToColon If not null, suggestion of replace '::' -> ':'
@@ -2854,11 +2851,6 @@ class Sema final : public SemaBase {
/// not '::'.
/// \param OnlyNamespace If true, only considers namespaces in lookup.
///
- /// This routine differs only slightly from ActOnCXXNestedNameSpecifier, in
- /// that it contains an extra parameter \p ScopeLookupResult, which provides
- /// the result of name lookup within the scope of the nested-name-specifier
- /// that was computed at template definition time.
- ///
/// If ErrorRecoveryLookup is true, then this call is used to improve error
/// recovery. This means that it should not emit diagnostics, it should
/// just return true on failure. It also means it should only return a valid
diff --git a/clang/lib/Sema/SemaCXXScopeSpec.cpp b/clang/lib/Sema/SemaCXXScopeSpec.cpp
index 16c43812028aa..dd61bb22e3dfa 100644
--- a/clang/lib/Sema/SemaCXXScopeSpec.cpp
+++ b/clang/lib/Sema/SemaCXXScopeSpec.cpp
@@ -422,102 +422,6 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
bool ErrorRecoveryLookup,
bool *IsCorrectedToColon,
bool OnlyNamespace) {
-#if 0
- if (IdInfo.Identifier->isEditorPlaceholder())
- return true;
- LookupResult Found(*this, IdInfo.Identifier, IdInfo.IdentifierLoc,
- OnlyNamespace ? LookupNamespaceName
- : LookupNestedNameSpecifierName);
- QualType ObjectType = GetTypeFromParser(IdInfo.ObjectType);
-
- // Determine where to perform name lookup
- DeclContext *LookupCtx = nullptr;
- bool isDependent = false;
- if (IsCorrectedToColon)
- *IsCorrectedToColon = false;
- if (!ObjectType.isNull()) {
- // This nested-name-specifier occurs in a member access expression, e.g.,
- // x->B::f, and we are looking into the type of the object.
- assert(!SS.isSet() && "ObjectType and scope specifier cannot coexist");
- LookupCtx = computeDeclContext(ObjectType);
- isDependent = !LookupCtx && ObjectType->isDependentType();
- } else if (SS.isNotEmpty()) {
- // This nested-name-specifier occurs after another nested-name-specifier,
- // so look into the context associated with the prior nested-name-specifier.
- LookupCtx = computeDeclContext(SS, EnteringContext);
- isDependent = !LookupCtx && isDependentScopeSpecifier(SS);
- // The declaration context must be complete.
- if (LookupCtx && RequireCompleteDeclContext(SS, LookupCtx))
- return true;
- Found.setContextRange(SS.getRange());
- }
-
- bool ObjectTypeSearchedInScope = false;
- if (LookupCtx) {
- // Perform "qualified" name lookup into the declaration context we
- // computed, which is either the type of the base of a member access
- // expression or the declaration context associated with a prior
- // nested-name-specifier.
-
- LookupQualifiedName(Found, LookupCtx);
-
- isDependent |= Found.wasNotFoundInCurrentInstantiation();
- }
-
- bool LookupFirstQualifierInScope =
- Found.empty() && !ObjectType.isNull() && !isDependent;
-
- // FIXME: We should still do the lookup if the object expression is dependent,
- // but instead of using them we should store them via
- // setFirstQualifierFoundInScope and pretend we found nothing.
- if (SS.isEmpty() && (ObjectType.isNull() || LookupFirstQualifierInScope)) {
- if (S) {
- LookupName(Found, S);
- } else if (LookupFirstQualifierInScope &&
- !SS.getUnqualifiedLookups().empty()) {
- Found.addAllDecls(SS.getUnqualifiedLookups());
- Found.resolveKind();
- }
-
- if (!ObjectType.isNull())
- ObjectTypeSearchedInScope = true;
- }
-#if 0
- if (!ObjectType.isNull() && Found.empty() && !isDependent) {
- // C++ [basic.lookup.classref]p4:
- // If the id-expression in a class member access is a qualified-id of
- // the form
- //
- // class-name-or-namespace-name::...
- //
- // the class-name-or-namespace-name following the . or -> operator is
- // looked up both in the context of the entire postfix-expression and in
- // the scope of the class of the object expression. If the name is found
- // only in the scope of the class of the object expression, the name
- // shall refer to a class-name. If the name is found only in the
- // context of the entire postfix-expression, the name shall refer to a
- // class-name or namespace-name. [...]
- //
- // Qualified name lookup into a class will not find a namespace-name,
- // so we do not need to diagnose that case specifically. However,
- // this qualified name lookup may find nothing. In that case, perform
- // unqualified name lookup in the given scope (if available) or
- // reconstruct the result from when name lookup was performed at template
- // definition time.
- if (S)
- LookupName(Found, S);
- else if (ScopeLookupResult)
- Found.addDecl(ScopeLookupResult);
-
- ObjectTypeSearchedInScope = true;
- }
- } else if (!isDependent) {
- // Perform unqualified name lookup in the current scope.
- LookupName(Found, S);
- }
-#endif
-#endif
-
if (IdInfo.Identifier->isEditorPlaceholder())
return true;
if (IsCorrectedToColon)
@@ -528,28 +432,50 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo,
OnlyNamespace ? LookupNamespaceName
: LookupNestedNameSpecifierName);
+ // C++ [basic.lookup.qual.general]p3:
+ // Qualified name lookup in a class, namespace, or enumeration performs a
+ // search of the scope associated with it except as specified below.
LookupParsedName(Found, S, &SS, ObjectType,
/*AllowBuiltinCreation=*/false, EnteringContext);
- // If we performed lookup into a dependent context and did not find anything,
- // that's fine: just build a dependent nested-name-specifier.
+ // C++ [basic.lookup.qual.general]p3:
+ // [...] Unless otherwise specified, a qualified name undergoes qualified
+ // name lookup in its lookup context from the point where it appears unless
+ // the lookup context either is dependent and is not the current
+ // instantiation or is not a class or class template.
if (Found.wasNotFoundInCurrentInstantiation()) {
// Don't speculate if we're just trying to improve error recovery.
if (ErrorRecoveryLookup)
return true;
- // We were not able to compute the declaration context for a dependent
- // base object type or prior nested-name-specifier, so this
- // nested-name-specifier refers to an unknown specialization. Just build
- // a dependent nested-name-specifier.
+ // The lookup context is dependent and either:
+ // - it is not the current instantiation, or
+ // - it is the current instantiation, it has at least one dependent base
+ // class, and qualified lookup found nothing.
+ // Build a dependent nested-name-specifier. We will lookup the name again
+ // during instantiation.
SS.Extend(Context, IdInfo.Identifier, IdInfo.IdentifierLoc, IdInfo.CCLoc);
return false;
}
bool ObjectTypeSearchedInScope = false;
- bool LookupFirstQualifierInScope = Found.empty() && !ObjectType.isNull();
- if (LookupFirstQualifierInScope) {
+ // C++ [basic.lookup.qual.general]p2:
+ // A member-qualified name is the (unique) component name, if any, of
+ // - an unqualified-id or
+ // - a nested-name-specifier of the form type-name :: or namespace-name ::
+ // in the id-expression of a class member access expression.
+ //
+ // C++ [basic.lookup.qual.general]p3:
+ // [...] If nothing is found by qualified lookup for a member-qualified
+ // name that is the terminal name of a nested-name-specifier and is not
+ // dependent, it undergoes unqualified lookup.
+ //
+ // In 'x.A::B::y', 'A' will undergo unqualified lookup if qualified lookup
+ // in the type of 'x' finds nothing. If the lookup context is dependent,
+ // we perform the unqualified lookup in the template definition context
+ // and store the results so we can replicate the lookup during instantiation.
+ if (Found.empty() && !ObjectType.isNull()) {
if (S) {
LookupName(Found, S);
} else if (!SS.getUnqualifiedLookups().empty()) {
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index 2e9ae86d75cf3..f84e7e0d87188 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -409,111 +409,59 @@ bool Sema::LookupTemplateName(LookupResult &Found, Scope *S, CXXScopeSpec &SS,
LookupParsedName(Found, S, &SS, ObjectType,
/*AllowBuiltinCreation=*/false, EnteringContext);
+ // C++ [basic.lookup.qual.general]p3:
+ // [...] Unless otherwise specified, a qualified name undergoes qualified
+ // name lookup in its lookup context from the point where it appears unless
+ // the lookup context either is dependent and is not the current
+ // instantiation or is not a class or class template.
+ //
+ // The lookup context is dependent and either:
+ // - it is not the current instantiation, or
+ // - it is the current instantiation, it has at least one dependent base
+ // class, and qualified lookup found nothing.
+ //
+ // If this is a member-qualified name that is the terminal name of a
+ // nested-name-specifier, we perform unqualified lookup and store the results
+ // so we can replicate the lookup during instantiation. The results of the
+ // unqualified loookup are *not* used to determine whether '<' is interpreted
+ // as the delimiter of a template-argument-list.
+ //
+ // For example:
+ //
+ // template<typename T>
+ // struct A {
+ // int x;
+ // };
+ //
+ // template<typename T>
+ // using B = A<T>;
+ //
+ // template<typename T>
+ // void f(A<T> a, A<int> b) {
+ // a.B<T>::x; // error: missing 'template' before 'B'
+ // b.B<int>::x; // ok, lookup context is not dependent
+ // }
if (Found.wasNotFoundInCurrentInstantiation())
return false;
-#if 0
- // Determine where to perform name lookup
- DeclContext *LookupCtx = nullptr;
- bool IsDependent = false;
- if (!ObjectType.isNull()) {
- // This nested-name-specifier occurs in a member access expression, e.g.,
- // x->B::f, and we are looking into the type of the object.
- assert(SS.isEmpty() && "ObjectType and scope specifier cannot coexist");
- LookupCtx = computeDeclContext(ObjectType);
- IsDependent = !LookupCtx && ObjectType->isDependentType();
- assert((IsDependent || !ObjectType->isIncompleteType() ||
- !ObjectType->getAs<TagType>() ||
- ObjectType->castAs<TagType>()->isBeingDefined()) &&
- "Caller should have completed object type");
-
- // Template names cannot appear inside an Objective-C class or object type
- // or a vector type.
- //
- // FIXME: This is wrong. For example:
- //
- // template<typename T> using Vec = T __attribute__((ext_vector_type(4)));
- // Vec<int> vi;
- // vi.Vec<int>::~Vec<int>();
- //
- // ... should be accepted but we will not treat 'Vec' as a template name
- // here. The right thing to do would be to check if the name is a valid
- // vector component name, and look up a template name if not. And similarly
- // for lookups into Objective-C class and object types, where the same
- // problem can arise.
- if (ObjectType->isObjCObjectOrInterfaceType() ||
- ObjectType->isVectorType()) {
- Found.clear();
- return false;
- }
- } else if (SS.isNotEmpty()) {
- // This nested-name-specifier occurs after another nested-name-specifier,
- // so long into the context associated with the prior nested-name-specifier.
- LookupCtx = computeDeclContext(SS, EnteringContext);
- IsDependent = !LookupCtx && isDependentScopeSpecifier(SS);
-
- // The declaration context must be complete.
- if (LookupCtx && RequireCompleteDeclContext(SS, LookupCtx))
- return true;
- }
-
bool ObjectTypeSearchedInScope = false;
- if (LookupCtx) {
- // Perform "qualified" name lookup into the declaration context we
- // computed, which is either the type of the base of a member access
- // expression or the declaration context associated with a prior
- // nested-name-specifier.
- LookupQualifiedName(Found, LookupCtx);
-
- // FIXME: The C++ standard does not clearly specify what happens in the
- // case where the object type is dependent, and implementations vary. In
- // Clang, we treat a name after a . or -> as a template-name if lookup
- // finds a non-dependent member or member of the current instantiation that
- // is a type template, or finds no such members and lookup in the context
- // of the postfix-expression finds a type template. In the latter case, the
- // name is nonetheless dependent, and we may resolve it to a member of an
- // unknown specialization when we come to instantiate the template.
- IsDependent |= Found.wasNotFoundInCurrentInstantiation();
- }
-#endif
-
-#if 0
- bool ObjectTypeSearchedInScope = false;
- bool LookupFirstQualifierInScope =
- MayBeNNS && Found.empty() && !ObjectType.isNull() && !IsDependent;
- // FIXME: We should still do the lookup if the object expression is dependent,
- // but instead of using them we should store them via
- // setFirstQualifierFoundInScope and pretend we found nothing.
- if (SS.isEmpty() && (ObjectType.isNull() || LookupFirstQualifierInScope)) {
- // C++ [basic.lookup.classref]p1:
- // In a class member access expression (5.2.5), if the . or -> token is
- // immediately followed by an identifier followed by a <, the
- // identifier must be looked up to determine whether the < is the
- // beginning of a template argument list (14.2) or a less-than operator.
- // The identifier is first looked up in the class of the object
- // expression. If the identifier is not found, it is then looked up in
- // the context of the entire postfix-expression and shall name a class
- // template.
- if (S) {
- LookupName(Found, S);
- } else if (LookupFirstQualifierInScope &&
- !SS.getUnqualifiedLookups().empty()) {
- Found.addAllDecls(SS.getUnqualifiedLookups());
- Found.resolveKind();
- }
-
- if (!ObjectType.isNull())
- ObjectTypeSearchedInScope = true;
-
- IsDependent |= Found.wasNotFoundInCurrentInstantiation();
- }
-#endif
- bool ObjectTypeSearchedInScope = false;
- bool LookupFirstQualifierInScope =
- MayBeNNS && Found.empty() && !ObjectType.isNull();
-
- if (LookupFirstQualifierInScope) {
+ // C++ [basic.lookup.qual.general]p2:
+ // A member-qualified name is the (unique) component name, if any, of
+ // - an unqualified-id or
+ // - a nested-name-specifier of the form type-name :: or namespace-name ::
+ // in the id-expression of a class member access expression.
+ //
+ // C++ [basic.lookup.qual.general]p3:
+ // [...] If nothing is found by qualified lookup for a member-qualified
+ // name that is the terminal name of a nested-name-specifier and is not
+ // dependent, it undergoes unqualified lookup.
+ //
+ // In 'x.A::B::y', 'A' will undergo unqualified lookup if qualified lookup
+ // in the type of 'x' finds nothing. If the lookup context is dependent,
+ // we perform the unqualified lookup in the template definition context
+ // and store the results so we can replicate the lookup during instantiation.
+ if (MayBeNNS && Found.empty() && !ObjectType.isNull()) {
if (S) {
LookupName(Found, S);
} else if (!SS.getUnqualifiedLookups().empty()) {
>From a464b45322b5b40c992285d10c7434be7ee8c236 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Mon, 8 Jul 2024 10:36:12 -0400
Subject: [PATCH 25/26] [FOLD] update test
---
clang/test/SemaCXX/cxx0x-noexcept-expression.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang/test/SemaCXX/cxx0x-noexcept-expression.cpp b/clang/test/SemaCXX/cxx0x-noexcept-expression.cpp
index c616a77f36619..b9aeffbf034b2 100644
--- a/clang/test/SemaCXX/cxx0x-noexcept-expression.cpp
+++ b/clang/test/SemaCXX/cxx0x-noexcept-expression.cpp
@@ -127,7 +127,7 @@ void f1() {
// `dependent` should be type-dependent because the noexcept-expression should be value-dependent
// (it is true if T is int*, false if T is Polymorphic<false, false>* for example)
dependent.f<void>(); // This should need to be `.template f` to parse as a template
- // expected-error at -1 {{use 'template' keyword to treat 'f' as a dependent template name}}
+ // expected-warning at -1 {{use 'template' keyword to treat 'f' as a dependent template name}}
}
template<typename... T>
void f2() {
@@ -135,14 +135,14 @@ void f2() {
// X<true> when T...[0] is a type with some operator&& which returns int*
// X<false> when sizeof...(T) == 0
dependent.f<void>();
- // expected-error at -1 {{use 'template' keyword to treat 'f' as a dependent template name}}
+ // expected-warning at -1 {{use 'template' keyword to treat 'f' as a dependent template name}}
}
template<typename T>
void f3() {
X<noexcept(typeid(*static_cast<T*>(nullptr)))> dependent;
// X<true> when T is int, X<false> when T is Polymorphic<false, false>
dependent.f<void>();
- // expected-error at -1 {{use 'template' keyword to treat 'f' as a dependent template name}}
+ // expected-warning at -1 {{use 'template' keyword to treat 'f' as a dependent template name}}
}
template<typename T>
void f4() {
>From 8def09c0a7845bae8346136805c9c37e1a38e47c Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski <sdkrystian at gmail.com>
Date: Tue, 9 Jul 2024 10:00:22 -0400
Subject: [PATCH 26/26] [FOLD] revert whitespace-only changes
---
clang/test/CXX/drs/cwg3xx.cpp | 10 +++++-----
clang/test/CXX/drs/cwg4xx.cpp | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/clang/test/CXX/drs/cwg3xx.cpp b/clang/test/CXX/drs/cwg3xx.cpp
index 54c97d2c7860f..a10ed95941ba4 100644
--- a/clang/test/CXX/drs/cwg3xx.cpp
+++ b/clang/test/CXX/drs/cwg3xx.cpp
@@ -443,7 +443,7 @@ namespace cwg329 { // cwg329: 3.5
// expected-note@#cwg329-b {{in instantiation of template class 'cwg329::A<char>' requested here}}
// expected-note@#cwg329-i {{previous definition is here}}
};
- A<int> a;
+ A<int> a;
A<char> b; // #cwg329-b
void test() {
@@ -684,9 +684,9 @@ namespace cwg341 { // cwg341: sup 1708
namespace B {
extern "C" int &cwg341_a = cwg341_a;
// expected-error at -1 {{redefinition of 'cwg341_a'}}
- // expected-note@#cwg341_a {{previous definition is here}}
+ // expected-note@#cwg341_a {{previous definition is here}}
}
- extern "C" void cwg341_b(); // #cwg341_b
+ extern "C" void cwg341_b(); // #cwg341_b
}
int cwg341_a;
// expected-error at -1 {{declaration of 'cwg341_a' in global scope conflicts with declaration with C language linkage}}
@@ -704,7 +704,7 @@ namespace cwg341 {
// expected-error at -1 {{declaration of 'cwg341_d' with C language linkage conflicts with declaration in global scope}}
// expected-note@#cwg341_d {{declared in global scope here}}
- namespace A { extern "C" int cwg341_e; } // #cwg341_e
+ namespace A { extern "C" int cwg341_e; } // #cwg341_e
namespace B { extern "C" void cwg341_e(); }
// expected-error at -1 {{redefinition of 'cwg341_e' as different kind of symbol}}
// expected-note@#cwg341_e {{previous definition is here}}
@@ -1106,7 +1106,7 @@ namespace cwg364 { // cwg364: yes
}
// cwg366: yes
-#if "foo" // expected-error {{invalid token at start of a preprocessor expression}}
+#if "foo" // expected-error {{invalid token at start of a preprocessor expression}}
#endif
namespace cwg367 { // cwg367: yes
diff --git a/clang/test/CXX/drs/cwg4xx.cpp b/clang/test/CXX/drs/cwg4xx.cpp
index 7598db4acf46a..98ff7553d989b 100644
--- a/clang/test/CXX/drs/cwg4xx.cpp
+++ b/clang/test/CXX/drs/cwg4xx.cpp
@@ -20,7 +20,7 @@ namespace cwg400 { // cwg400: yes
struct A { int a; struct a {}; }; // #cwg400-A
struct B { int a; struct a {}; }; // #cwg400-B
struct C : A, B { using A::a; struct a b; };
- struct D : A, B {
+ struct D : A, B {
using A::a;
// FIXME: we should issue a single diagnostic
using B::a; // #cwg400-using-B-a
More information about the libcxx-commits
mailing list