[libcxx-commits] [libcxxabi] [libc++abi] Use __has_feature check to enable usage of thread_local for exception storage (PR #97591)

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 5 14:43:55 PDT 2024


mstorsjo wrote:

> LGTM. @mstorsjo may want to take a look [#79542 (comment)](https://github.com/llvm/llvm-project/pull/79542#issuecomment-1913361802)

Thanks; I tested this patch in some of my test environments, and it seems to not break anything, so I think it's fine.

As mentioned in https://github.com/llvm/llvm-project/pull/79542#issuecomment-1913361802, this could have an effect on emutls environments; I tried to run a set of tests with emutls enabled as well. With emutls enabled (as in that linked PR), a bunch of my tests hang, both with and without this PR. So that doesn't indicate any reason to hold back this patch either.

So, in short, +1 for this patch from me, and AFAIK this will fix the same issue as https://reviews.llvm.org/D155278 tried to fix.

https://github.com/llvm/llvm-project/pull/97591


More information about the libcxx-commits mailing list