[libcxx-commits] [libcxx] [libcxxabi] [WebAssembly] Upstream misc. EH changes (PR #92990)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 4 09:55:11 PDT 2024


ldionne wrote:

As a matter of process, please do not merge patches to libc++/libc++abi/libunwind unless you have an approval from the relevant review group. Anyone is free to provide a code review, but the final approval must be granted by the review group. I know this wasn't done with a bad intention, I just want to make sure that our policies are understood and followed by folks.

On a different note, we should set up a CI job that builds and tests libc++ on Wasm. Our support policy mentions that we must have CI set up in order to officially support a platform, and what happened here is that patches of increasing intrusiveness were checked in and kinda got under the radar, so we never really discussed about the support policy for wasm. As it stands, wasm is technically not supported by libc++ so we'd be free to remove all the code as dead. Of course, we don't want to do that, but instead we should bring wasm in line with the other supported platforms and then we can officially claim support for it.

https://github.com/llvm/llvm-project/pull/92990


More information about the libcxx-commits mailing list