[libcxx-commits] [libcxx] [libc++] Run the Lit test suite against an installed version of the library (PR #96910)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 2 13:49:16 PDT 2024


ldionne wrote:

> > so I don't understand why that code path is taken. Do you understand what's going on?
> 
> In https://github.com/llvm/llvm-project/blob/main/libcxx/CMakeLists.txt#L279 you have `option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." ON)` - which defaults this variable to `ON`, regardless of whether either `libcxxabi` or `libunwind` even are enabled. In this PR, you're checking `if (LIBCXXABI_USE_LLVM_UNWINDER)` and reference libunwind within that.

I feel a bit dumb. Thanks for pointing out the obvious to me 🙂

https://github.com/llvm/llvm-project/pull/96910


More information about the libcxx-commits mailing list