[libcxx-commits] [libcxx] [libc++][hardening] Add iterator validity checks on unordered containers (PR #80230)

via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 31 18:53:24 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 730f498c961f29691a605028f9b1cd6d9e232460 5f5137d7587634930064bed178dac210ca1abf3e -- libcxx/include/__hash_table libcxx/test/libcxx/containers/unord/unord.map/debug.iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.map/debug.iterator.increment.pass.cpp libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.increment.pass.cpp libcxx/test/libcxx/containers/unord/unord.multimap/debug.iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.multimap/debug.iterator.increment.pass.cpp libcxx/test/libcxx/containers/unord/unord.multimap/debug.local_iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.multimap/debug.local_iterator.increment.pass.cpp libcxx/test/libcxx/containers/unord/unord.multiset/debug.iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.multiset/debug.iterator.increment.pass.cpp libcxx/test/libcxx/containers/unord/unord.multiset/debug.local_iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.multiset/debug.local_iterator.increment.pass.cpp libcxx/test/libcxx/containers/unord/unord.set/debug.iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.set/debug.iterator.increment.pass.cpp libcxx/test/libcxx/containers/unord/unord.set/debug.local_iterator.dereference.pass.cpp libcxx/test/libcxx/containers/unord/unord.set/debug.local_iterator.increment.pass.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.increment.pass.cpp b/libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.increment.pass.cpp
index f0ae410643..9034963571 100644
--- a/libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.increment.pass.cpp
+++ b/libcxx/test/libcxx/containers/unord/unord.map/debug.local_iterator.increment.pass.cpp
@@ -36,7 +36,8 @@ int main(int, char**) {
         assert(i2 != c.cend(b));
         ++i2;
         assert(i2 == c.cend(b));
-        TEST_LIBCPP_ASSERT_FAILURE(++i2, "Attempted to increment a non-incrementable unordered container const_local_iterator");
+        TEST_LIBCPP_ASSERT_FAILURE(
+            ++i2, "Attempted to increment a non-incrementable unordered container const_local_iterator");
     }
 
     {
@@ -53,7 +54,8 @@ int main(int, char**) {
         assert(i2 != c.cend(b));
         ++i2;
         assert(i2 == c.cend(b));
-        TEST_LIBCPP_ASSERT_FAILURE(++i2, "Attempted to increment a non-incrementable unordered container const_local_iterator");
+        TEST_LIBCPP_ASSERT_FAILURE(
+            ++i2, "Attempted to increment a non-incrementable unordered container const_local_iterator");
     }
 
     return 0;

``````````

</details>


https://github.com/llvm/llvm-project/pull/80230


More information about the libcxx-commits mailing list