[libcxx-commits] [flang] [libcxx] [clang] [llvm] [lld] [libcxxabi] [lldb] [libc] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)
Fangrui Song via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jan 30 11:11:44 PST 2024
MaskRay wrote:
> LGTM in general.
>
> But the downside here is that the compiler won't be able to optimize away repeated stores if they are transformed to memset calls. Maybe introduce some threshold and only memset() sizes greater than, say, 64? (IIRC that's what `-ftrivial-auto-var-init` does)
TIL. Changed to keep using StoreInst when size <= 32, similar to `shouldUseBZeroPlusStoresToInitialize` `-ftrivial-auto-var-init`)
https://github.com/llvm/llvm-project/pull/79924
More information about the libcxx-commits
mailing list