[libcxx-commits] [libcxx] [libc++] [NFC] Documentation: Add `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` (PR #79963)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 30 00:20:30 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

<details>
<summary>Changes</summary>

I got tripped twice after: 7b4622514d232ce5f7110dd8b20d90e81127c467 Let's at least mention these in the `Contributing.rst` doc.

---
Full diff: https://github.com/llvm/llvm-project/pull/79963.diff


1 Files Affected:

- (modified) libcxx/docs/Contributing.rst (+1) 


``````````diff
diff --git a/libcxx/docs/Contributing.rst b/libcxx/docs/Contributing.rst
index 3ff8c15a969b0..596d86ef22449 100644
--- a/libcxx/docs/Contributing.rst
+++ b/libcxx/docs/Contributing.rst
@@ -162,6 +162,7 @@ sure you don't forget anything:
 
 - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
 - Did you run the ``libcxx-generate-files`` target and verify its output?
+- If needed, did you add `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` to the relevant headers?
 
 The review process
 ==================

``````````

</details>


https://github.com/llvm/llvm-project/pull/79963


More information about the libcxx-commits mailing list