[libcxx-commits] [libcxx] mark std::make_format_args with clang::lifetimebound attribute (PR #78997)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jan 28 10:56:59 PST 2024


mordante wrote:

> > Thanks for your patch. Can you add a verify test that this warning is show. I expect we should do the same for `make_wformat_args`?
> > Can you please make your e-mail address visible? We like to merge commits with the proper attribution.
> 
> Can you please say what this test (Check libc++ generated files) do? Or where documentation about it?)

It's this command
```
grep -rn '[^ -~]' libcxx/include libcxx/src libcxx/test libcxx/benchmarks --exclude '*.dat' --exclude '*unicode*.cpp' --exclude '*print*.sh.cpp' --exclude 'escaped_output.*.pass.cpp' --exclude format_tests.h --exclude format.functions.tests.h --exclude 'formatter.*.pass.cpp' --exclude grep.pass.cpp --exclude locale-specific_form.pass.cpp --exclude ostream.pass.cpp --exclude transcoding.pass.cpp --exclude underflow.pass.cpp
```

Did you use clang-format?

> About email - dont want to make it public now, i have already commits in llvm and it seem to not be required

This thread talks about hidden addresses
https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223
and it was revived again recently
https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223/26

not being able to contact the author of a patch is an issue for the LLVM project. 


https://github.com/llvm/llvm-project/pull/78997


More information about the libcxx-commits mailing list