[libcxx-commits] [libcxx] [libc++] Add clang-19 to failing tests on Windows (PR #79619)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 26 08:51:54 PST 2024


https://github.com/gulfemsavrun created https://github.com/llvm/llvm-project/pull/79619

After trunk is bumped to version 19, some libc++ tests started failing on Windows. This patch adds clang-19 condition to XFAIL to fix the issue.

>From fa64f0b757c816527f436e17a268d93e9a7f1a91 Mon Sep 17 00:00:00 2001
From: Gulfem Savrun Yeniceri <gulfem at google.com>
Date: Fri, 26 Jan 2024 16:40:13 +0000
Subject: [PATCH] [libc++] Add clang-19 to failing tests on Windows

After trunk is bumped to version 19, some libc++ tests started
failing on Windows. This patch adds clang-19 condition to XFAIL
to fix the issue.
---
 libcxx/test/libcxx/fuzzing/random.pass.cpp          | 2 +-
 libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp | 2 +-
 libcxx/test/std/numerics/c.math/cmath.pass.cpp      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libcxx/test/libcxx/fuzzing/random.pass.cpp b/libcxx/test/libcxx/fuzzing/random.pass.cpp
index 69b496fa3a4e66f..663977696f2df85 100644
--- a/libcxx/test/libcxx/fuzzing/random.pass.cpp
+++ b/libcxx/test/libcxx/fuzzing/random.pass.cpp
@@ -8,7 +8,7 @@
 
 // This test fails because Clang no longer enables -fdelayed-template-parsing
 // by default on Windows with C++20 (#69431).
-// XFAIL: msvc && clang-18
+// XFAIL: msvc && (clang-18 || clang-19)
 
 // UNSUPPORTED: c++03, c++11
 
diff --git a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
index 7a6c71ae68f797c..bbfb0c5548fab69 100644
--- a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
@@ -8,7 +8,7 @@
 
 // This test fails because Clang no longer enables -fdelayed-template-parsing
 // by default on Windows with C++20 (#69431).
-// XFAIL: msvc && clang-18
+// XFAIL: msvc && (clang-18 || clang-19)
 
 // <math.h>
 
diff --git a/libcxx/test/std/numerics/c.math/cmath.pass.cpp b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
index a6a9dad639cdff9..937908449979232 100644
--- a/libcxx/test/std/numerics/c.math/cmath.pass.cpp
+++ b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
@@ -8,7 +8,7 @@
 
 // This test fails because Clang no longer enables -fdelayed-template-parsing
 // by default on Windows with C++20 (#69431).
-// XFAIL: msvc && clang-18
+// XFAIL: msvc && (clang-18 || clang-19)
 
 // <cmath>
 



More information about the libcxx-commits mailing list