[libcxx-commits] [clang-tools-extra] [flang] [clang] [libcxx] [lld] [compiler-rt] [libc] [llvm] [libcxxabi] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 24 14:28:21 PST 2024


================
@@ -2487,29 +2574,42 @@ void SampleProfileMatcher::runOnModule() {
     errs() << "(" << NumMismatchedCallsites << "/" << TotalProfiledCallsites
            << ")"
            << " of callsites' profile are invalid and "
-           << "(" << MismatchedCallsiteSamples << "/" << TotalCallsiteSamples
+           << "(" << MismatchedCallsiteSamples << "/" << TotalFuncHashSamples
----------------
WenleiHe wrote:

Are TotalCallsiteSamples and TotalFuncHashSamples all just refer to the total samples of all functions in the profile? 

The name `TotalFuncHashSamples` is confusing -- when we talk about samples, it should not have hash as entity, instead the entities should be function or call sites? 

https://github.com/llvm/llvm-project/pull/79090


More information about the libcxx-commits mailing list