[libcxx-commits] [libcxx] [pstl] [lld] [llvm] [lldb] [clang] [libc] [compiler-rt] [mlir] [clang-tools-extra] [openmp] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

Artem Belevich via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 24 09:41:56 PST 2024


================
@@ -0,0 +1,5 @@
+/// Some target-specific options are ignored for GPU, so %clang exits with code 0.
+// DEFINE: %{check} = %clang -### -c -mcmodel=medium
----------------
Artem-B wrote:

In this particular case, the changes we test (and the error messages) were originating in the driver, so we're OK with `-###`.

That said, we do have other options that we do need to suppress/ignore and some of that does happen on cc1 level. 

We'll eventually need to add the tests for those here and then enable actual compilation, but it should not hold this patch back.



https://github.com/llvm/llvm-project/pull/79222


More information about the libcxx-commits mailing list