[libcxx-commits] [libcxx] [libc++][NFC] Rewrite function call on two lines for clarity (PR #79141)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

Previously, there was a ternary conditional with a less-than comparison appearing inside a template argument, which was really confusing because of the <...> of the function template. This patch rewrites the same statement on two lines for clarity.

---
Full diff: https://github.com/llvm/llvm-project/pull/79141.diff


1 Files Affected:

- (modified) libcxx/include/string (+2-2) 


``````````diff
diff --git a/libcxx/include/string b/libcxx/include/string
index e97139206d4fa7c..085178fe1a9ed01 100644
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -1948,8 +1948,8 @@ private:
     if (__s < __min_cap) {
       return static_cast<size_type>(__min_cap) - 1;
     }
-    size_type __guess =
-        __align_it < sizeof(value_type) < __alignment ? __alignment / sizeof(value_type) : 1 > (__s + 1) - 1;
+    const size_type __boundary = sizeof(value_type) < __alignment ? __alignment / sizeof(value_type) : 1;
+    size_type __guess          = __align_it<__boundary>(__s + 1) - 1;
     if (__guess == __min_cap)
       ++__guess;
     return __guess;

``````````

</details>


https://github.com/llvm/llvm-project/pull/79141