[libcxx-commits] [libcxx] 123ab34 - [libc++][test] Move format.functions ASCII tests to `libcxx/test/libcxx` (#78661)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 19 16:17:07 PST 2024


Author: Stephan T. Lavavej
Date: 2024-01-19T16:17:03-08:00
New Revision: 123ab34abc68e2e64720f9690aed5cb9e62a035d

URL: https://github.com/llvm/llvm-project/commit/123ab34abc68e2e64720f9690aed5cb9e62a035d
DIFF: https://github.com/llvm/llvm-project/commit/123ab34abc68e2e64720f9690aed5cb9e62a035d.diff

LOG: [libc++][test] Move format.functions ASCII tests to `libcxx/test/libcxx` (#78661)

As @cpplearner explained in microsoft/STL#4328:

> libc++'s "ascii" mode (controlled by the `_LIBCPP_HAS_NO_UNICODE`
> macro) means "every code unit outside ASCII is treated as a valid
> printable character". AFAIK we \[MSVC's STL\] don't support such a mode.

Because these files are testing a non-Standard mode, they should be
moved from `libcxx/test/std` to `libcxx/test/libcxx`.

Added: 
    libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
    libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp

Modified: 
    

Removed: 
    libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp
    libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp


################################################################################
diff  --git a/libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
similarity index 100%
rename from libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp

diff  --git a/libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
similarity index 99%
rename from libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
index 1d92c7c96c2a78..32352774a08f97 100644
--- a/libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
+++ b/libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
@@ -226,7 +226,7 @@ void test_char() {
     static_assert(sizeof(CharT) == 4, "add support for unexpected size");
     // Unicode fitting in a 32-bit wchar_t
 
-    constexpr wchar_t x  = 0x1ffff;
+    constexpr wchar_t x       = 0x1ffff;
     constexpr std::uint32_t y = 0x1ffff;
     static_assert(x == y);
 


        


More information about the libcxx-commits mailing list