[libcxx-commits] [libcxx] [libc++][test] Move format.functions ASCII tests to `libcxx/test/libcxx` (PR #78661)
via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jan 18 18:23:06 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Stephan T. Lavavej (StephanTLavavej)
<details>
<summary>Changes</summary>
As @<!-- -->cpplearner explained in microsoft/STL#<!-- -->4328:
> libc++'s "ascii" mode (controlled by the `_LIBCPP_HAS_NO_UNICODE` macro) means "every code unit outside ASCII is treated as a valid printable character". AFAIK we \[MSVC's STL\] don't support such a mode.
Because these files are testing a non-Standard mode, they should be moved from `libcxx/test/std` to `libcxx/test/libcxx`.
---
Full diff: https://github.com/llvm/llvm-project/pull/78661.diff
2 Files Affected:
- (renamed) libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp ()
- (renamed) libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp ()
``````````diff
diff --git a/libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
similarity index 100%
rename from libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
diff --git a/libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
similarity index 100%
rename from libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
``````````
</details>
https://github.com/llvm/llvm-project/pull/78661
More information about the libcxx-commits
mailing list