[libcxx-commits] [libcxx] [libc++] tests with picolibc: update picolibc (PR #77908)
via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jan 12 03:22:02 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Dominik Wójt (domin144)
<details>
<summary>Changes</summary>
The updated picolibc version has "isblank" function with external linkage. This is required for C++ modules support.[1]
[1] https://github.com/llvm/llvm-project/issues/76980
---
Full diff: https://github.com/llvm/llvm-project/pull/77908.diff
1 Files Affected:
- (modified) libcxx/utils/ci/build-picolibc.sh (+2-1)
``````````diff
diff --git a/libcxx/utils/ci/build-picolibc.sh b/libcxx/utils/ci/build-picolibc.sh
index 078c2bdf5ebccc..713e2773547689 100755
--- a/libcxx/utils/ci/build-picolibc.sh
+++ b/libcxx/utils/ci/build-picolibc.sh
@@ -73,8 +73,9 @@ mkdir -p "${picolibc_build_dir}"
# Following changes are required and were introduced after version 1.8.5:
# - updated semihost arguments handling,
# - added missing macros in stdio.h
+# - external linkage for isblank
# Version following 1.8.5, was not released by the time of writing.
-picolibc_commit="4b9b8ef01d18cf0563348ad4af4ae89a7277e7ca"
+picolibc_commit="04a90c56d7aac61880f205ec29b3dce6a9de0342"
curl -L "https://github.com/picolibc/picolibc/archive/${picolibc_commit}.zip" --output "${picolibc_source_dir}/picolibc.zip"
unzip -q "${picolibc_source_dir}/picolibc.zip" -d "${picolibc_source_dir}"
mv "${picolibc_source_dir}/picolibc-${picolibc_commit}"/* "${picolibc_source_dir}"
``````````
</details>
https://github.com/llvm/llvm-project/pull/77908
More information about the libcxx-commits
mailing list