[libcxx-commits] [libcxx] [libc++] Implement std::gcd using the binary version (PR #77747)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 11 06:56:09 PST 2024


https://github.com/AdvenamTacet requested changes to this pull request.

Looks good to me % testing.
To be sure that we don't change `std::gcd` behavior, let's test (compare with naive gcd) also:
- minimal and maximal values for different types.
- all pairs of numbers around 0.
```cpp
    for(T i = -9; i < 10; ++i)
        for(T j = -9; j < 10; ++j)
```

I don't see a benchmark [requested on Phabricator](https://reviews.llvm.org/D145982#inline-1519289).

@philnik777 do changes in `transitive_includes` look good to you?

https://github.com/llvm/llvm-project/pull/77747


More information about the libcxx-commits mailing list