[libcxx-commits] [libcxx] [libc++] fix condition_variable_any hangs on stop_request (PR #77127)
via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jan 10 23:14:34 PST 2024
https://github.com/sn-rbroker approved this pull request.
This PR looks good to me, I checked through the new test cases and they seem like they cover the hang issues noted already, and the other improvements (using std::move for the internal lock, renaming the user lock, checking stop_requested/predicate before taking the time to create the stop callback) all look good.
(I guess the test failure around noexcept -> _NOEXCEPT with c++03 is something you're already looking at.)
Thanks @huixie90!
https://github.com/llvm/llvm-project/pull/77127
More information about the libcxx-commits
mailing list