[libcxx-commits] [libcxx] [libc++] Make std::filesystem::canonical throw when given empty path (PR #77223)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Jan 7 04:47:50 PST 2024
Yuki-cpp wrote:
Thank you for the review. I'll get to it.
One question though:
> Can you remove the notes below from the commit message, to avoid accidentally merging them in the commit?
Are you referring to this part?
> Since std::filesystem::weakly_canonical uses this function and should not raise an error when given an empty path, it was updated to return an empty path instead of the results of canonical.
Or to are referring to the note I added to the PR description? (Those 2 shouldn't be in the commit message, but I can also remove them from the PR if you think it's best)
https://github.com/llvm/llvm-project/pull/77223
More information about the libcxx-commits
mailing list