[libcxx-commits] [libcxx] [libc++] std::condition_variable_any overloads accepting std::stop_token don't register for stop callbacks (PR #77099)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Jan 6 05:45:48 PST 2024
huixie90 wrote:
I created the same patch yesterday
https://github.com/llvm/llvm-project/pull/77127
It is almost the same except that my patch does not take the internal lock when checks stop requested and only takes the lock before unlock the user lock and wait.
I would keep the existing tests and add new tests ( I added new tests in my patch)
Also I want to point out that taking a copy of shared_ptr no longer works in these overloads. We also need to keep the internal cv alive via a shared_ptr. However, this is not achievable without changing the ABI.
https://github.com/llvm/llvm-project/pull/77099
More information about the libcxx-commits
mailing list