[libcxx-commits] [libcxx] [libc++] Implement LWG3940: std::expected<void, E>::value() also needs E to be copy constructible (PR #71819)

via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 3 18:02:31 PST 2024


PragmaTwice wrote:

> > Hi @mordante @huixie90, I think all review comments have been addressed now. Could you review it again?
> 
> Hi thanks for the update. There 2 expected tests in the CI that seem to be failing. Do you know why it is the case?

Yeah I've seen these failed cases.
But I cannot reproduce on my side, and it seems not related to my changes.

I will try to merge the latest main branch and rerun the CI.

```
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1378: excess elements in struct initializer
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1378: excess elements in struct initializer
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1389: excess elements in struct initializer
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1389: excess elements in struct initializer
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1400: excess elements in struct initializer
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1400: excess elements in struct initializer
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1412: excess elements in struct initializer
# |   File /home/runner/_work/llvm-project/llvm-project/build/generic-modules/include/c++/v1/__expected/expected.h Line 1412: excess elements in struct initializer
```

https://github.com/llvm/llvm-project/pull/71819


More information about the libcxx-commits mailing list