[libcxx-commits] [libcxx] [libc++][ranges] implement `ranges::shift_left` (PR #83231)
Nikolas Klauser via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Feb 29 04:18:41 PST 2024
================
@@ -24,30 +26,40 @@ _LIBCPP_BEGIN_NAMESPACE_STD
#if _LIBCPP_STD_VER >= 20
-template <class _ForwardIterator>
-inline _LIBCPP_HIDE_FROM_ABI constexpr _ForwardIterator
-shift_left(_ForwardIterator __first,
- _ForwardIterator __last,
- typename iterator_traits<_ForwardIterator>::difference_type __n) {
+template <class _AlgPolicy, class _Iter, class _Sent>
+inline _LIBCPP_HIDE_FROM_ABI constexpr pair<_Iter, _Iter>
----------------
philnik777 wrote:
```suggestion
_LIBCPP_HIDE_FROM_ABI inline constexpr pair<_Iter, _Iter>
```
I know it's not this way in any way consistent in the code base, but I'm trying to get it at least somewhat consistent. Since `_LIBCPP_HIDE_FROM_ABI` is essentially an attribute, let's put it in the attribute position.
This also shouldn't need an `inline`, since that's implicit anyways.
https://github.com/llvm/llvm-project/pull/83231
More information about the libcxx-commits
mailing list