[libcxx-commits] [libcxx] 8cd5e67 - [NFC][libc++] Requests PR at GitHub instead of Phabricator.

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 17 07:27:55 PST 2024


Author: Mark de Wever
Date: 2024-02-17T16:27:43+01:00
New Revision: 8cd5e672602676877b9025a750b20f895ca0bc25

URL: https://github.com/llvm/llvm-project/commit/8cd5e672602676877b9025a750b20f895ca0bc25
DIFF: https://github.com/llvm/llvm-project/commit/8cd5e672602676877b9025a750b20f895ca0bc25.diff

LOG: [NFC][libc++] Requests PR at GitHub instead of Phabricator.

Added: 
    

Modified: 
    libcxx/test/support/test_format_context.h
    libcxx/test/support/test_format_string.h

Removed: 
    


################################################################################
diff  --git a/libcxx/test/support/test_format_context.h b/libcxx/test/support/test_format_context.h
index d7d38b5aceca60..38cbc8f74ee4ad 100644
--- a/libcxx/test/support/test_format_context.h
+++ b/libcxx/test/support/test_format_context.h
@@ -19,9 +19,9 @@
  * required object.
  *
  * @note This requires every standard library implementation to write their own
- * helper function. Vendors are encouraged to file a review at
- * https://reviews.llvm.org/ so their specific implementation can be part of
- * this file.
+ * helper function. Vendors are encouraged to file a PR at
+ * https://github.com/llvm/llvm-project so their specific implementation can be
+ * part of this file.
  */
 
 #include "test_macros.h"
@@ -57,7 +57,8 @@ std::basic_format_context<OutIt, CharT> test_format_context_create(
 }
 #  endif // TEST_HAS_NO_LOCALIZATION
 #else    // _LIBCPP_VERSION
-#  error "Please create a vendor specific version of the test functions and file a review at https://reviews.llvm.org/"
+#  error                                                                                                               \
+      "Please create a vendor specific version of the test typedef and file a PR at https://github.com/llvm/llvm-project"
 #endif // _LIBCPP_VERSION
 
 #endif // SUPPORT_TEST_FORMAT_CONTEXT_HPP

diff  --git a/libcxx/test/support/test_format_string.h b/libcxx/test/support/test_format_string.h
index 49e94c7dbfc78f..2efc704e5a8192 100644
--- a/libcxx/test/support/test_format_string.h
+++ b/libcxx/test/support/test_format_string.h
@@ -40,8 +40,8 @@ using test_format_string = std::format_string<Args...>;
 
 #else // TEST_STD_VER > 20 || defined(_LIBCPP_VERSION) || defined( _MSVC_STL_VERSION)
 
-#  error
-"Please create a vendor specific version of the test typedef and file a review at https://reviews.llvm.org/"
+#  error                                                                                                               \
+      "Please create a vendor specific version of the test typedef and file a PR at https://github.com/llvm/llvm-project"
 
 #endif // TEST_STD_VER > 20 || defined(_LIBCPP_VERSION) || defined( _MSVC_STL_VERSION)
 


        


More information about the libcxx-commits mailing list