[libcxx-commits] [libcxx] [libc++][chrono] Loads tzdata.zi in tzdb. (PR #74928)

via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 11 05:06:33 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 803374994602910aae2cb483d03bcbdb294b21bb 965058b93814276cdca3c031d30ec19a40127a58 -- libcxx/include/__chrono/time_zone.h libcxx/include/__chrono/time_zone_link.h libcxx/src/include/tzdb/time_zone_link_private.h libcxx/src/include/tzdb/time_zone_private.h libcxx/src/include/tzdb/types_private.h libcxx/src/include/tzdb/tzdb_list_private.h libcxx/src/include/tzdb/tzdb_private.h libcxx/src/time_zone.cpp libcxx/src/tzdb.cpp libcxx/test/libcxx/time/time.zone/time.zone.db/links.pass.cpp libcxx/test/libcxx/time/time.zone/time.zone.db/rules.pass.cpp libcxx/test/libcxx/time/time.zone/time.zone.db/zones.pass.cpp libcxx/test/std/time/time.zone/time.zone.link/time.zone.link.members/name.pass.cpp libcxx/test/std/time/time.zone/time.zone.link/time.zone.link.members/target.pass.cpp libcxx/test/std/time/time.zone/time.zone.link/time.zone.link.nonmembers/comparison.pass.cpp libcxx/test/std/time/time.zone/time.zone.link/types.compile.pass.cpp libcxx/test/std/time/time.zone/time.zone.timezone/time.zone.members/name.pass.cpp libcxx/test/std/time/time.zone/time.zone.timezone/time.zone.nonmembers/comparison.pass.cpp libcxx/test/std/time/time.zone/time.zone.timezone/types.compile.pass.cpp libcxx/include/__chrono/tzdb.h libcxx/include/__chrono/tzdb_list.h libcxx/include/chrono libcxx/modules/std/chrono.inc libcxx/src/tzdb_list.cpp libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.verify.cpp libcxx/test/std/time/time.zone/time.zone.db/time.zone.db.access/get_tzdb.pass.cpp libcxx/test/std/time/time.zone/time.zone.db/time.zone.db.tzdb/tzdb.members.pass.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/__chrono/time_zone_link.h b/libcxx/include/__chrono/time_zone_link.h
index 884bc635fa..7f35c2c87c 100644
--- a/libcxx/include/__chrono/time_zone_link.h
+++ b/libcxx/include/__chrono/time_zone_link.h
@@ -38,8 +38,8 @@ namespace chrono {
 class time_zone_link {
 public:
   struct __constructor_tag;
-  _LIBCPP_NODISCARD_EXT
-  _LIBCPP_HIDE_FROM_ABI explicit time_zone_link(string_view __name, string_view __target, __constructor_tag&&)
+  _LIBCPP_NODISCARD_EXT _LIBCPP_HIDE_FROM_ABI explicit time_zone_link(
+      string_view __name, string_view __target, __constructor_tag&&)
       : __name_{__name}, __target_{__target} {}
 
   _LIBCPP_HIDE_FROM_ABI time_zone_link(time_zone_link&&)            = default;
diff --git a/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp b/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp
index ec09e4d082..8019824046 100644
--- a/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp
+++ b/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp
@@ -24,8 +24,8 @@
 #include "test_macros.h"
 
 // These types have "private" constructors.
-extern  std::chrono::time_zone tz;
-extern  std::chrono::time_zone_link link;
+extern std::chrono::time_zone tz;
+extern std::chrono::time_zone_link link;
 
 void test() {
   std::chrono::tzdb_list& list = std::chrono::get_tzdb_list();
diff --git a/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.verify.cpp b/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.verify.cpp
index 4ad9b7105f..e9b2755949 100644
--- a/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.verify.cpp
+++ b/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.verify.cpp
@@ -21,8 +21,8 @@
 #include "test_macros.h"
 
 // These types have "private" constructors.
-extern  std::chrono::time_zone tz;
-extern  std::chrono::time_zone_link link;
+extern std::chrono::time_zone tz;
+extern std::chrono::time_zone_link link;
 
 void test() {
   std::chrono::tzdb_list& list = std::chrono::get_tzdb_list();

``````````

</details>


https://github.com/llvm/llvm-project/pull/74928


More information about the libcxx-commits mailing list