[libcxx-commits] [libcxx] f66f44e - [libc++][modules] Regenerates files.

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 10 06:26:53 PST 2024


Author: Mark de Wever
Date: 2024-02-10T15:25:30+01:00
New Revision: f66f44eb0c194f6bd0b6387d778624b303b6edc1

URL: https://github.com/llvm/llvm-project/commit/f66f44eb0c194f6bd0b6387d778624b303b6edc1
DIFF: https://github.com/llvm/llvm-project/commit/f66f44eb0c194f6bd0b6387d778624b303b6edc1.diff

LOG: [libc++][modules] Regenerates files.

After applying the review comments of
https://github.com/llvm/llvm-project/pull/80478
I've forgotten to update the generated files. This fixes the issue and
removes trailing whitespace.

Added: 
    

Modified: 
    libcxx/modules/std.compat.cppm.in
    libcxx/modules/std.cppm.in
    libcxx/utils/generate_libcxx_cppm_in.py

Removed: 
    


################################################################################
diff  --git a/libcxx/modules/std.compat.cppm.in b/libcxx/modules/std.compat.cppm.in
index 16363711ac7627..b44dbab25c74b4 100644
--- a/libcxx/modules/std.compat.cppm.in
+++ b/libcxx/modules/std.compat.cppm.in
@@ -47,11 +47,11 @@ module;
 
 // *** Headers not yet available ***
 //
-// This validation is mainly to aid libc++ developers to add modules for new
-// headers. On Windows the Windows SDK can be in the include path. This SDK
-// contains the MSVC STL headers. This may give false positives when MSVC STL
-// provides a header libc++ has not implemented yet. Therefore this validation
-// is not done on Windows.
+// This validation is mainly to catch when a new header is added but adding the
+// corresponding .inc file is forgotten. However, the check based on __has_include
+// alone doesn't work on Windows because the Windows SDK is on the include path,
+// and that means the MSVC STL headers can be found as well, tricking __has_include
+// into thinking that libc++ provides the header.
 //
 #ifndef _WIN32
 #  if __has_include(<debugging>)

diff  --git a/libcxx/modules/std.cppm.in b/libcxx/modules/std.cppm.in
index 3b59c28482b113..b8d89130aae989 100644
--- a/libcxx/modules/std.cppm.in
+++ b/libcxx/modules/std.cppm.in
@@ -169,11 +169,11 @@ module;
 
 // *** Headers not yet available ***
 //
-// This validation is mainly to aid libc++ developers to add modules for new
-// headers. On Windows the Windows SDK can be in the include path. This SDK
-// contains the MSVC STL headers. This may give false positives when MSVC STL
-// provides a header libc++ has not implemented yet. Therefore this validation
-// is not done on Windows.
+// This validation is mainly to catch when a new header is added but adding the
+// corresponding .inc file is forgotten. However, the check based on __has_include
+// alone doesn't work on Windows because the Windows SDK is on the include path,
+// and that means the MSVC STL headers can be found as well, tricking __has_include
+// into thinking that libc++ provides the header.
 //
 #ifndef _WIN32
 #  if __has_include(<debugging>)

diff  --git a/libcxx/utils/generate_libcxx_cppm_in.py b/libcxx/utils/generate_libcxx_cppm_in.py
index 0390ce5067f402..e98ac1b2433144 100644
--- a/libcxx/utils/generate_libcxx_cppm_in.py
+++ b/libcxx/utils/generate_libcxx_cppm_in.py
@@ -61,7 +61,7 @@ def write_file(module):
             """
 // *** Headers not yet available ***
 //
-// This validation is mainly to catch when a new header is added but adding the 
+// This validation is mainly to catch when a new header is added but adding the
 // corresponding .inc file is forgotten. However, the check based on __has_include
 // alone doesn't work on Windows because the Windows SDK is on the include path,
 // and that means the MSVC STL headers can be found as well, tricking __has_include


        


More information about the libcxx-commits mailing list