[libcxx-commits] [libcxx] linear_congruential_engine: Fixes for __lce_alg_picker (PR #81080)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 8 00:24:52 PST 2024


LRFLEW wrote:

I've pushed some updated regression tests to account for the build failures. I reorganized some of the tests in `rand.eng.lcong` to include more test cases, while commenting out the test cases that are currently unsupported due to the static assert.

I also went ahead and added a specific regression test for the `_OverflowOK` fix, using the example I mentioned in #33554. I simply added it to `rand.eng.lcong/alg.pass.cpp` instead of making a new file because it seems to me like it's all testing the same idea (using the right algorithm to avoid integer overflow breaking the result), and figure it's better to keep like-tests together. If you want me to split this out to a separate file, let me know.

https://github.com/llvm/llvm-project/pull/81080


More information about the libcxx-commits mailing list