[libcxx-commits] [libcxx] [libc++] Allow for hardening in multiple categories (PR #79859)

[Will Hawkins via libcxx-commits]

hawkinsw wrote:

> (@hawkinsw Very sorry about the slow reply, I'm just catching up on the reviews)
> 
> It's an interesting idea, thanks for working on this! Personally, I would postpone this until we have a use case. The current model we have, where assertions are classified across a single axis (even if that axis takes multiple factors into account), while perhaps limited, has the advantage of being simple. That makes understanding which assertion categories go into which modes easier. If we start running into cases where it just feels natural to start essentially tagging assertions, or if we come up with use cases where people want modes grouped around orthogonal criteria, we could revisit this patch and use this mechanism to implement that. Until we have specific use cases, however, I think let's try to keep things as simple as possible. The less modes we support, the easier it is for us to reason about what is the exact effect of each mode and what kind of (best effort) guarantees it provides.

As I mentioned in DM with you, *please* do not apologize! I appreciate and agree with everything that you have said here. I will pull back this PR until such time as we would like to have the capability to harden over multiple categories. I was suggesting it really to get your feedback on its technical merit. So, thank you for validating that the technical would be valid. 

Thank you for all you do!


https://github.com/llvm/llvm-project/pull/79859