[libcxx-commits] [libcxx] [libc++] Fix vector<const T> (PR #80711)
Pranav Kant via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 6 21:35:19 PST 2024
pranavk wrote:
@philnik777 Thanks for explaining. I will just add more details to my previous comment in case I wasn't clear. I understand it may seem little weird to first ask and then merge but we were unaware of your working hours and if you were actively monitoring this. I commented on the PR to ask, then looked at your email ID (berlin.de), assumed you were in Berlin time (it was past midnight in Berlin at that time) and off for the day, and went ahead merging it after noticing this PR was created and approved 7+ hours ago at that time.
The original commit had quite a huge impact on us, and we couldn't afford waiting until normal Berlin office hours. Also, CI being mostly green and our internal testing on similar platforms gave me enough confidence to go ahead with this one. I hope that explains my rationale.
https://github.com/llvm/llvm-project/pull/80711
More information about the libcxx-commits
mailing list