[libcxx-commits] [libcxx] [libc++] Move the locale support headers to __locale_dir/locale_base_api/ (PR #74522)

[via libcxx-commits]

zeroomega wrote:

I see why. Before the patch, https://github.com/llvm/llvm-project/pull/74522/commits/d0ca2ed29ae60f1a2f892e6d6ce5376dc44c07ee#diff-aee5cd6bce30221277f5956d06791a0eb6f1b20db927b7ec71a5b08de44f1dcbL23 includes the `string.h` and https://github.com/llvm/llvm-project/pull/74522/commits/d0ca2ed29ae60f1a2f892e6d6ce5376dc44c07ee#diff-aee5cd6bce30221277f5956d06791a0eb6f1b20db927b7ec71a5b08de44f1dcbL48 includes the Fuchsia's header. 

After this patch, Fuchsia's header was included at https://github.com/llvm/llvm-project/pull/74522/commits/d0ca2ed29ae60f1a2f892e6d6ce5376dc44c07ee#diff-aee5cd6bce30221277f5956d06791a0eb6f1b20db927b7ec71a5b08de44f1dcbR15 before including `string.h`. This causes the issue.

Would it be OK to move `#include <__locale_dir/locale_base_api.h>` after L35 to match its original behavior?

https://github.com/llvm/llvm-project/pull/74522