[libcxx-commits] [libcxx] [libc++][sstream] P2495R3: Interfacing `stringstream`s with `string_view` (PR #80552)

via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 3 09:34:10 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 5ca2777c69f8708d583e230c56ac7f5f6376fb40 ac97d71ab1ae0da07d10d4f3db47b2358f04797b -- libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/string_view.alloc.pass.cpp libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/string_view.mode.alloc.pass.cpp libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/string_view.mode.pass.cpp libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/str.string_view.pass.cpp libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.cons/string_view.alloc.pass.cpp libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.cons/string_view.mode.alloc.pass.cpp libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.cons/string_view.mode.pass.cpp libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.members/str.string_view.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.cons/string_view.alloc.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.cons/string_view.mode.alloc.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.cons/string_view.mode.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.members/str.string_view.pass.cpp libcxx/test/std/input.output/string.streams/stringstream/stringstream.cons/string_view.alloc.pass.cpp libcxx/test/std/input.output/string.streams/stringstream/stringstream.cons/string_view.mode.alloc.pass.cpp libcxx/test/std/input.output/string.streams/stringstream/stringstream.cons/string_view.mode.pass.cpp libcxx/test/std/input.output/string.streams/stringstream/stringstream.members/str.string_view.pass.cpp libcxx/include/sstream libcxx/include/version libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.members/str.move.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.members/str.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.members/view.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/seekoff.pass.cpp libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/seekpos.pass.cpp libcxx/test/std/language.support/support.limits/support.limits.general/sstream.version.compile.pass.cpp libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/seekpos.pass.cpp b/libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/seekpos.pass.cpp
index 8e00ee2784..c1e9f5bb44 100644
--- a/libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/seekpos.pass.cpp
+++ b/libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/seekpos.pass.cpp
@@ -22,42 +22,42 @@
 int main(int, char**)
 {
 #if TEST_STD_VER < 26
-    {
-        std::stringbuf sb("0123456789", std::ios_base::in);
-        assert(sb.pubseekpos(3, std::ios_base::out) == -1);
-        assert(sb.pubseekpos(3, std::ios_base::in | std::ios_base::out) == -1);
-        assert(sb.pubseekpos(3, std::ios_base::in) == 3);
-        assert(sb.sgetc() == '3');
-    }
-    {
-        std::stringbuf sb("0123456789", std::ios_base::out);
-        assert(sb.pubseekpos(3, std::ios_base::in) == -1);
-        assert(sb.pubseekpos(3, std::ios_base::out | std::ios_base::in) == -1);
-        assert(sb.pubseekpos(3, std::ios_base::out) == 3);
-        assert(sb.sputc('a') == 'a');
-        assert(sb.str() == "012a456789");
-    }
+  {
+    std::stringbuf sb("0123456789", std::ios_base::in);
+    assert(sb.pubseekpos(3, std::ios_base::out) == -1);
+    assert(sb.pubseekpos(3, std::ios_base::in | std::ios_base::out) == -1);
+    assert(sb.pubseekpos(3, std::ios_base::in) == 3);
+    assert(sb.sgetc() == '3');
+  }
+  {
+    std::stringbuf sb("0123456789", std::ios_base::out);
+    assert(sb.pubseekpos(3, std::ios_base::in) == -1);
+    assert(sb.pubseekpos(3, std::ios_base::out | std::ios_base::in) == -1);
+    assert(sb.pubseekpos(3, std::ios_base::out) == 3);
+    assert(sb.sputc('a') == 'a');
+    assert(sb.str() == "012a456789");
+  }
 #endif // TEST_STD_VER < 26
-    {
-        std::stringbuf sb("0123456789");
-        assert(sb.pubseekpos(3, std::ios_base::in) == 3);
-        assert(sb.sgetc() == '3');
-        assert(sb.pubseekpos(3, std::ios_base::out | std::ios_base::in) == 3);
-        assert(sb.sgetc() == '3');
-        assert(sb.sputc('a') == 'a');
-        assert(sb.str() == "012a456789");
-        assert(sb.pubseekpos(3, std::ios_base::out) == 3);
-        assert(sb.sputc('3') == '3');
-        assert(sb.str() == "0123456789");
-    }
+  {
+    std::stringbuf sb("0123456789");
+    assert(sb.pubseekpos(3, std::ios_base::in) == 3);
+    assert(sb.sgetc() == '3');
+    assert(sb.pubseekpos(3, std::ios_base::out | std::ios_base::in) == 3);
+    assert(sb.sgetc() == '3');
+    assert(sb.sputc('a') == 'a');
+    assert(sb.str() == "012a456789");
+    assert(sb.pubseekpos(3, std::ios_base::out) == 3);
+    assert(sb.sputc('3') == '3');
+    assert(sb.str() == "0123456789");
+  }
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
 #  if TEST_STD_VER < 26
-    {
-        std::wstringbuf sb(L"0123456789", std::ios_base::in);
-        assert(sb.pubseekpos(3, std::ios_base::out) == -1);
-        assert(sb.pubseekpos(3, std::ios_base::in | std::ios_base::out) == -1);
-        assert(sb.pubseekpos(3, std::ios_base::in) == 3);
-        assert(sb.sgetc() == L'3');
+  {
+    std::wstringbuf sb(L"0123456789", std::ios_base::in);
+    assert(sb.pubseekpos(3, std::ios_base::out) == -1);
+    assert(sb.pubseekpos(3, std::ios_base::in | std::ios_base::out) == -1);
+    assert(sb.pubseekpos(3, std::ios_base::in) == 3);
+    assert(sb.sgetc() == L'3');
     }
     {
         std::wstringbuf sb(L"0123456789", std::ios_base::out);

``````````

</details>


https://github.com/llvm/llvm-project/pull/80552


More information about the libcxx-commits mailing list