[libcxx-commits] [libcxx] [libc++] Explicitly convert to masks in SIMD code (PR #107983)

Vitaly Buka via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 30 11:10:34 PST 2024


vitalybuka wrote:

> @thurstond Please comment on a PR when you revert it. I didn't see the revert until now.

Github UI makes it confusing, some may have an impression that 
![image](https://github.com/user-attachments/assets/51b611b1-94d5-4814-815c-00ee32b33d0b)
on PR will notify the user.

It would be nice to have a policy about that. Sometimes I create a new issue on revert, other times I set personal notifications to check In a day or so if the author acknowledged the revert.

> Also, what's the path forward here? The pre-commit CI passed, so whatever you're seeing is most likely not a supported configuration. 

Pre-commit CI covers only a fraction of officially libc++ supported configurations, e.g. the arm is not covered at all. Also why passing libc++ under sanitizer is not a supported configuration?

> It seems like I can't see the logs anymore, so I don't even know what the failure is.

We know the bot name "sanitizer-aarch64-linux-bootstrap-hwasan", I can re-run  
https://github.com/llvm/llvm-project/pull/121352 on the bot without commit.


https://github.com/llvm/llvm-project/pull/107983


More information about the libcxx-commits mailing list