[libcxx-commits] [libcxx] [libc++] Speed-up vector<bool> range-based operations [3/3] (PR #120134)

[Nikolas Klauser via libcxx-commits]

https://github.com/philnik777 requested changes to this pull request.

Since you're optimizing an algorithm (and nothing specific to `vector<bool>` itself) we should just benchmark that instead. That's significantly less convoluted. I'd also like to see some additional tests, especially with iterators that don't return a bool. I'm pretty sure your current implementation is completely broken with that. Lastly, I think we should move this into `__copy_impl`, since we might be able to unwrap iterators to `__bit_iterator`s. I don't think we do that currently, but I see no reason we couldn't in the future. It would also be nice to improve `std::move` in the same way (and hopefully share the code).

https://github.com/llvm/llvm-project/pull/120134