[libcxx-commits] [libcxx] [libc++] Refactor the Windows and MinGW implementation of the locale base API (PR #115752)

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 16 12:21:39 PST 2024


mstorsjo wrote:

> After thinking about this a bit more, I think your results are not very surprising. I think these symbols are mostly used from within the libc++ dylib, and so perhaps it's not even necessary to export (most of) them in the first place. We could explore that in future patches once we at least have a clear "theoretical" ABI boundary within the libc++ code itself.

Yes, I kinda am getting that feeling as well. (Plus very few things explicitly use locales at all - at most it's implicitly passed somewhere.)

> Thanks to you both for running those experiments! Are you fine with me merging this PR then?

Yes, I'm ok with that - let's not create unnecessary complexity here.

https://github.com/llvm/llvm-project/pull/115752


More information about the libcxx-commits mailing list