[libcxx-commits] [libcxx] [libcxx] Require non-root-user for tests that check permissions (PR #119940)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne requested changes to this pull request.

I have to agree with @philnik777 here. While I think I understand the goal and it may be an OK goal to pursue, landing this patch as-is will lead to these tests being unconditionally disabled without any signal being given to the user, and that's probably not the intent of the patch.

If we want to do something like this, I believe it would be time for us to first implement something we've long talked about doing: We should have a test that lists the expected `XFAIL`s and `UNSUPPORTED` tests in each (or at least most) CI jobs to make sure that tests don't get silently disabled. Basically something that tests the test suite configuration. Given something like that, this patch would fail such tests, we could fix it (by defining the `non-root-user` feature properly) and we'd have significantly more confidence that we're not just removing test coverage "by mistake".

Can I ask what is the underlying motivation for this patch? Is there a reason why you want to be able to run the tests as root in Docker containers?

https://github.com/llvm/llvm-project/pull/119940