[libcxx-commits] [libcxx] [libcxx] Require non-root-user for tests that check permissions (PR #119940)

[Aiden Grossman via libcxx-commits]

boomanaiden154 wrote:

> This patch doesn't ever enable non-root-user, so this is just dead code.

It's enabled within lit. https://github.com/llvm/llvm-project/blob/0ae75eba678a9ab459a382818148ef06afe817b5/llvm/utils/lit/lit/llvm/config.py#L176

>  It's pretty trivial to change the user, at least in Docker. Another problem is that this will just hide that some tests don't run instead of informing the user.

It's not hard to change the user, and this will hide cause some tests to be unsupported, but I don't think that's necessarily a problem.

The precedent across the rest of the monorepo is to disable tests that fail when running under root. See the following PRs:
1. https://github.com/llvm/llvm-project/pull/75285
2. https://github.com/llvm/llvm-project/pull/81339
3. https://github.com/llvm/llvm-project/pull/119816
4. https://github.com/llvm/llvm-project/pull/119604

It would be somewhat annoying if libc++ deviated from what everyone else is doing.

https://github.com/llvm/llvm-project/pull/119940