[libcxx-commits] [libcxxabi] [llvm] [libc++abi] Enable demangling of `cp` expression production (PR #114882)

Hubert Tong via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 10 16:18:59 PST 2024


================
@@ -30371,24 +30372,22 @@ void test_invalid_cases()
     assert(!passed && "demangle did not fail");
 }
 
-const char *xfail_cases[] = {
-    // FIXME: Why does clang generate the "cp" expr?
-    "_ZN5test11bIsEEDTcp3foocvT__EEES1_",
+const char *const xfail_cases[] = {
----------------
hubert-reinterpretcast wrote:

> one caveat with formatting the testcases is that clang-format will split those long strings into multiple lines, which becomes very annoying to work with (e.g., copying out testcases, or even reading them). That's why i put a `clang-format off` around that array

I took a look at the results of running `clang-format`, and it looks like the `clang-format off` should be applied _inside_ the initializer list and for two additional arrays: `fp_literal_cases` and `invalid_cases`. The indentation width for these initializers will then need to be adjusted manually.

https://github.com/llvm/llvm-project/pull/114882


More information about the libcxx-commits mailing list