[libcxx-commits] [libcxx] [libc++] use copy_file_range for fs::copy (PR #109211)

[Jannik Glückert via libcxx-commits]

Jannik2099 wrote:

> > > LGTM once CI is green.
> > 
> > 
> > NACK, see my review above
> 
> Sorry, I don't understand. Are you saying that something still needs to be addressed in this PR?

I am saying that your commit https://github.com/llvm/llvm-project/pull/109211/commits/8f314b977c7a5a986f68a97e9b29b7725770460d completely changes the semantics.

You changed it to two definitions of `copy_file_impl` that attempt `copy_file_range` / `sendfile` first, and `fstream` second. The definition is chosen at compile time.

The intended behaviour is for one `copy_file_impl` that attempts `copy_file_range` (if available for the platform), then `sendfile` (if available for the platform), and finally `fstream`

https://github.com/llvm/llvm-project/pull/109211