[libcxx-commits] [libcxx] [libc++] Put [[gnu::nodebug]] on all internal aliases (PR #118710)

Wed Dec 4 15:08:40 PST 2024

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7b6e0d9fc3993f3e3df596fd16d97e2ed2e1d0aa 17617b8c49c6467c5545e77777dbbb4bdca20b87 --extensions ,h,cpp,hpp -- libcxx/test/tools/clang_tidy_checks/nodebug_on_internal_aliases.cpp libcxx/test/tools/clang_tidy_checks/nodebug_on_internal_aliases.hpp libcxx/test/tools/clang_tidy_checks/utilities.hpp libcxx/include/__algorithm/comp_ref_type.h libcxx/include/__algorithm/copy.h libcxx/include/__algorithm/iterator_operations.h libcxx/include/__algorithm/move.h libcxx/include/__algorithm/ranges_iterator_concept.h libcxx/include/__algorithm/ranges_unique_copy.h libcxx/include/__algorithm/simd_utils.h libcxx/include/__algorithm/sort.h libcxx/include/__algorithm/three_way_comp_ref_type.h libcxx/include/__algorithm/unwrap_iter.h libcxx/include/__atomic/aliases.h libcxx/include/__atomic/atomic.h libcxx/include/__atomic/atomic_ref.h libcxx/include/__atomic/atomic_sync.h libcxx/include/__atomic/contention_t.h libcxx/include/__atomic/memory_order.h libcxx/include/__bit_reference libcxx/include/__chrono/formatter.h libcxx/include/__chrono/hh_mm_ss.h libcxx/include/__chrono/parser_std_format_spec.h libcxx/include/__compare/ordering.h libcxx/include/__compare/synth_three_way.h libcxx/include/__exception/exception_ptr.h libcxx/include/__expected/expected.h libcxx/include/__expected/unexpected.h libcxx/include/__filesystem/path.h libcxx/include/__flat_map/flat_map.h libcxx/include/__format/buffer.h libcxx/include/__format/concepts.h libcxx/include/__format/container_adaptor.h libcxx/include/__format/format_arg.h libcxx/include/__format/format_arg_store.h libcxx/include/__format/format_functions.h libcxx/include/__format/formatter_floating_point.h libcxx/include/__format/formatter_string.h libcxx/include/__format/range_default_formatter.h libcxx/include/__format/unicode.h libcxx/include/__functional/binary_function.h libcxx/include/__functional/bind.h libcxx/include/__functional/boyer_moore_searcher.h libcxx/include/__functional/function.h libcxx/include/__functional/perfect_forward.h libcxx/include/__functional/unary_function.h libcxx/include/__hash_table libcxx/include/__iterator/aliasing_iterator.h libcxx/include/__iterator/concepts.h libcxx/include/__iterator/insert_iterator.h libcxx/include/__iterator/iterator_traits.h libcxx/include/__iterator/projected.h libcxx/include/__iterator/ranges_iterator_traits.h libcxx/include/__iterator/reverse_iterator.h libcxx/include/__iterator/segmented_iterator.h libcxx/include/__locale libcxx/include/__locale_dir/locale_base_api.h libcxx/include/__mdspan/extents.h libcxx/include/__memory/allocation_guard.h libcxx/include/__memory/allocator_traits.h libcxx/include/__memory/pointer_traits.h libcxx/include/__memory/shared_ptr.h libcxx/include/__memory/unique_ptr.h libcxx/include/__memory/unique_temporary_buffer.h libcxx/include/__node_handle libcxx/include/__pstl/backend_fwd.h libcxx/include/__pstl/dispatch.h libcxx/include/__ranges/chunk_by_view.h libcxx/include/__ranges/drop_view.h libcxx/include/__ranges/drop_while_view.h libcxx/include/__ranges/elements_view.h libcxx/include/__ranges/filter_view.h libcxx/include/__ranges/iota_view.h libcxx/include/__ranges/join_view.h libcxx/include/__ranges/lazy_split_view.h libcxx/include/__ranges/repeat_view.h libcxx/include/__ranges/reverse_view.h libcxx/include/__ranges/split_view.h libcxx/include/__ranges/subrange.h libcxx/include/__ranges/take_view.h libcxx/include/__ranges/take_while_view.h libcxx/include/__ranges/transform_view.h libcxx/include/__split_buffer libcxx/include/__stop_token/stop_state.h libcxx/include/__thread/support/pthread.h libcxx/include/__tuple/make_tuple_types.h libcxx/include/__tuple/sfinae_helpers.h libcxx/include/__tuple/tuple_size.h libcxx/include/__type_traits/add_lvalue_reference.h libcxx/include/__type_traits/add_pointer.h libcxx/include/__type_traits/add_rvalue_reference.h libcxx/include/__type_traits/common_reference.h libcxx/include/__type_traits/common_type.h libcxx/include/__type_traits/conjunction.h libcxx/include/__type_traits/copy_cv.h libcxx/include/__type_traits/copy_cvref.h libcxx/include/__type_traits/detected_or.h libcxx/include/__type_traits/disjunction.h libcxx/include/__type_traits/invoke.h libcxx/include/__type_traits/is_always_bitcastable.h libcxx/include/__type_traits/is_char_like_type.h libcxx/include/__type_traits/is_equality_comparable.h libcxx/include/__type_traits/is_execution_policy.h libcxx/include/__type_traits/is_primary_template.h libcxx/include/__type_traits/is_same.h libcxx/include/__type_traits/is_swappable.h libcxx/include/__type_traits/make_32_64_or_128_bit.h libcxx/include/__type_traits/make_const_lvalue_ref.h libcxx/include/__type_traits/make_signed.h libcxx/include/__type_traits/make_unsigned.h libcxx/include/__type_traits/maybe_const.h libcxx/include/__type_traits/remove_all_extents.h libcxx/include/__type_traits/remove_const.h libcxx/include/__type_traits/remove_const_ref.h libcxx/include/__type_traits/remove_cv.h libcxx/include/__type_traits/remove_cvref.h libcxx/include/__type_traits/remove_extent.h libcxx/include/__type_traits/remove_pointer.h libcxx/include/__type_traits/remove_reference.h libcxx/include/__type_traits/remove_volatile.h libcxx/include/__type_traits/void_t.h libcxx/include/__utility/exception_guard.h libcxx/include/__utility/forward_like.h libcxx/include/__utility/in_place.h libcxx/include/__utility/integer_sequence.h libcxx/include/__utility/move.h libcxx/include/__utility/pair.h libcxx/include/__utility/swap.h libcxx/include/__vector/vector.h libcxx/include/any libcxx/include/array libcxx/include/barrier libcxx/include/ccomplex libcxx/include/ciso646 libcxx/include/complex libcxx/include/cstdalign libcxx/include/cstdbool libcxx/include/ctgmath libcxx/include/deque libcxx/include/experimental/__simd/scalar.h libcxx/include/experimental/__simd/simd.h libcxx/include/experimental/__simd/simd_mask.h libcxx/include/experimental/__simd/vec_ext.h libcxx/include/forward_list libcxx/include/ios libcxx/include/optional libcxx/include/ratio libcxx/include/regex libcxx/include/source_location libcxx/include/string libcxx/include/tuple libcxx/include/variant libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff

diff --git a/libcxx/include/__iterator/concepts.h b/libcxx/include/__iterator/concepts.h
index 20ea918002..038b3b912c 100644
--- a/libcxx/include/__iterator/concepts.h
+++ b/libcxx/include/__iterator/concepts.h
@@ -276,9 +276,9 @@ concept indirectly_copyable_storable =
 template <class _Tp>
 using __has_random_access_iterator_category_or_concept [[__gnu__::__nodebug__]]
 #if _LIBCPP_STD_VER >= 20
-    = integral_constant<bool, random_access_iterator<_Tp>>;
+= integral_constant<bool, random_access_iterator<_Tp>>;
 #else  // _LIBCPP_STD_VER < 20
-    = __has_random_access_iterator_category<_Tp>;
+= __has_random_access_iterator_category<_Tp>;
 #endif // _LIBCPP_STD_VER
 
 _LIBCPP_END_NAMESPACE_STD
diff --git a/libcxx/include/__iterator/iterator_traits.h b/libcxx/include/__iterator/iterator_traits.h
index 30d011c3d9..318d16be6d 100644
--- a/libcxx/include/__iterator/iterator_traits.h
+++ b/libcxx/include/__iterator/iterator_traits.h
@@ -168,7 +168,7 @@ concept __cpp17_input_iterator = __cpp17_iterator<_Ip> && equality_comparable<_I
   typename incrementable_traits<_Ip>::difference_type;
   typename indirectly_readable_traits<_Ip>::value_type;
   typename common_reference_t<iter_reference_t<_Ip>&&, typename indirectly_readable_traits<_Ip>::value_type&>;
-  typename common_reference_t<decltype(*__i++) &&, typename indirectly_readable_traits<_Ip>::value_type&>;
+  typename common_reference_t<decltype(*__i++)&&, typename indirectly_readable_traits<_Ip>::value_type&>;
   requires signed_integral<typename incrementable_traits<_Ip>::difference_type>;
 };
 
diff --git a/libcxx/include/__utility/forward_like.h b/libcxx/include/__utility/forward_like.h
index 4f93996162..4216b0b255 100644
--- a/libcxx/include/__utility/forward_like.h
+++ b/libcxx/include/__utility/forward_like.h
@@ -35,8 +35,8 @@ using _ForwardLike [[__gnu__::__nodebug__]] =
     _OverrideRef<_Ap&&, _CopyConst<remove_reference_t<_Ap>, remove_reference_t<_Bp>>>;
 
 template <class _Tp, class _Up>
-[[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto forward_like(_LIBCPP_LIFETIMEBOUND _Up&& __ux) noexcept
-    -> _ForwardLike<_Tp, _Up> {
+[[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto
+forward_like(_LIBCPP_LIFETIMEBOUND _Up&& __ux) noexcept -> _ForwardLike<_Tp, _Up> {
   return static_cast<_ForwardLike<_Tp, _Up>>(__ux);
 }
 
diff --git a/libcxx/test/tools/clang_tidy_checks/utilities.hpp b/libcxx/test/tools/clang_tidy_checks/utilities.hpp
index 5ee234686e..8c90725b22 100644
--- a/libcxx/test/tools/clang_tidy_checks/utilities.hpp
+++ b/libcxx/test/tools/clang_tidy_checks/utilities.hpp
@@ -19,5 +19,4 @@ inline bool isUglyName(std::string_view str) {
   return str.find("__") != std::string_view::npos;
 }
 
-
 #endif // LIBCXX_TEST_TOOLS_CLANG_TIDY_CHECKS_UTILITIES_HPP

``````````

</details>


https://github.com/llvm/llvm-project/pull/118710
