[libcxx-commits] [libcxx] [libc++] Guard ..._REMOVED_UNCAUGHT_EXCEPTION behind ifndef (PR #106719)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 30 06:27:13 PDT 2024


================
@@ -6,7 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
-#define _LIBCPP_ENABLE_CXX20_REMOVED_UNCAUGHT_EXCEPTION
+#ifndef _LIBCPP_ENABLE_CXX20_REMOVED_UNCAUGHT_EXCEPTION
+#  define _LIBCPP_ENABLE_CXX20_REMOVED_UNCAUGHT_EXCEPTION
+#endif
----------------
ldionne wrote:

I understand. Unfortunately my responsibility is to let you know what's good and what's not good to do when building libc++, but I understand that doing the right thing may not be trivial from your side. If you clean this up a bit though, it may pay off in the future by preventing libc++ from being built with unexpected flags (which could go wrong in a number of ways).

https://github.com/llvm/llvm-project/pull/106719


More information about the libcxx-commits mailing list