[libcxx-commits] [libcxx] [libc++][string] Remove potential non-trailing 0-length array (PR #105865)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 27 14:38:26 PDT 2024


https://github.com/ldionne commented:

I have some questions and comments, but this generally LGTM. While I wouldn't go absolutely nuts to avoid using a compiler extension, I think it's better to strive towards using few-ish of those. I also think this is a good opportunity to do a small refactoring of `std::string`'s layout definition that has been on my mind for a while.

@philnik777 Please let me know if you feel strongly that this patch shouldn't move forward. I am weakly favourable to it, but I could also be convinced that the complexity isn't worth it.

https://github.com/llvm/llvm-project/pull/105865


More information about the libcxx-commits mailing list