[libcxx-commits] [libcxx] [libc++][test] Fix `is_always_lock_free` test (PR #105966)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Aug 24 19:07:16 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Stephan T. Lavavej (StephanTLavavej)
<details>
<summary>Changes</summary>
There were a couple of problems with this test added by #<!-- -->99570:
* It was named `is_always_lock_free.cpp` instead of `is_always_lock_free.pass.cpp`.
+ Noticed because the MSVC STL test harness looks for `MEOW.pass.cpp` specifically.
* It was using `std::same_as` without including `<concepts>`.
+ Noticed because MSVC's STL doesn't drag this in via other headers.
---
Full diff: https://github.com/llvm/llvm-project/pull/105966.diff
1 Files Affected:
- (renamed) libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp (+1)
``````````diff
diff --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
similarity index 99%
rename from libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp
rename to libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
index 2dc7f5c7654193..db17221e515d3a 100644
--- a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.cpp
+++ b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
@@ -17,6 +17,7 @@
#include <atomic>
#include <cassert>
+#include <concepts>
#include <cstddef>
#include "test_macros.h"
``````````
</details>
https://github.com/llvm/llvm-project/pull/105966
More information about the libcxx-commits
mailing list