[libcxx-commits] [libcxx] [libc++] Fix CMake cache for the hardening with ABI breaks CI (PR #105864)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 23 10:37:44 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

We were incorrectly only enabling _LIBCPP_ABI_BOUNDED_ITERATORS, without enabling bounded iterators in string and vector.

---
Full diff: https://github.com/llvm/llvm-project/pull/105864.diff


1 Files Affected:

- (modified) libcxx/cmake/caches/Generic-hardening-mode-fast-with-abi-breaks.cmake (+1-3) 


``````````diff
diff --git a/libcxx/cmake/caches/Generic-hardening-mode-fast-with-abi-breaks.cmake b/libcxx/cmake/caches/Generic-hardening-mode-fast-with-abi-breaks.cmake
index 4a9389fdcb41cb..c0f2bad1c95af0 100644
--- a/libcxx/cmake/caches/Generic-hardening-mode-fast-with-abi-breaks.cmake
+++ b/libcxx/cmake/caches/Generic-hardening-mode-fast-with-abi-breaks.cmake
@@ -1,4 +1,2 @@
 set(LIBCXX_HARDENING_MODE "fast" CACHE STRING "")
-set(LIBCXX_ABI_DEFINES "_LIBCPP_ABI_BOUNDED_ITERATORS" CACHE STRING "")
-set(LIBCXX_ABI_DEFINES "_LIBCPP_ABI_BOUNDED_ITERATORS_IN_STRING" CACHE STRING "")
-set(LIBCXX_ABI_DEFINES "_LIBCPP_ABI_BOUNDED_ITERATORS_IN_VECTOR" CACHE STRING "")
+set(LIBCXX_ABI_DEFINES "_LIBCPP_ABI_BOUNDED_ITERATORS;_LIBCPP_ABI_BOUNDED_ITERATORS_IN_STRING;_LIBCPP_ABI_BOUNDED_ITERATORS_IN_VECTOR" CACHE STRING "")

``````````

</details>


https://github.com/llvm/llvm-project/pull/105864


More information about the libcxx-commits mailing list