[libcxx-commits] [libcxx] [libc++] Fix __split_buffer::reserve() (PR #105681)

[Louis Dionne via libcxx-commits]

ldionne wrote:

Is there a way to trigger this bug from a public API? Something like `std::vector::push_back` or something along those lines? If it's possible to trigger from a public API, I think I would favor that approach.

> Do we implement unit tests for internal data structures at all?

We don't typically do that. It doesn't mean that we can't do it, but we generally stick to testing the public APIs.

> Is there another file I should include the tests into?

I don't quite understand the question.

> Is there a more suitable folder to include the newly created test file into?

I think the path you used is reasonable.

https://github.com/llvm/llvm-project/pull/105681