[libcxx-commits] [libcxx] [libcxx] Fix 'transform_error.mandates.verify.cpp' test on msvc (PR #104635)

[via libcxx-commits]

zeroomega wrote:

Emmm, the upstream libcxx bot for msvc has an error that I didn't see when I local test it:

```
FAIL: llvm-libc++-shared-clangcl.cfg.in :: libcxx/utilities/expected/expected.void/transform_error.mandates.verify.cpp (1731 of 9739)
******************** TEST 'llvm-libc++-shared-clangcl.cfg.in :: libcxx/utilities/expected/expected.void/transform_error.mandates.verify.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# COMPILED WITH
'C:/Program Files/LLVM/bin/clang-cl.exe' D:\a\llvm-project\llvm-project\libcxx\test\libcxx\utilities\expected\expected.void\transform_error.mandates.verify.cpp --driver-mode=g++ --target=x86_64-pc-windows-msvc -fms-runtime-lib=dll -nostdinc++ -I D:/a/llvm-project/llvm-project/build/clang-cl-dll/include/c++/v1 -I D:/a/llvm-project/llvm-project/build/clang-cl-dll/include/c++/v1 -I D:/a/llvm-project/llvm-project/libcxx/test/support -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -std=c++26 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-noexcept-type -Wno-atomic-alignment -Wno-reserved-module-identifier -Wdeprecated-copy -Wdeprecated-copy-dtor -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -Wno-local-type-template-args -Wno-c++11-extensions -Wno-unknown-pragmas -Wno-pass-failed -Wno-mismatched-new-delete -Wno-redundant-move -Wno-self-move -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE -Werror=thread-safety -Wuser-defined-warnings -DTEST_WINDOWS_DLL  -fsyntax-only -Wno-error -Xclang -verify -Xclang -verify-ignore-unexpected=note -ferror-limit=0
# executed command: 'C:/Program Files/LLVM/bin/clang-cl.exe' 'D:\a\llvm-project\llvm-project\libcxx\test\libcxx\utilities\expected\expected.void\transform_error.mandates.verify.cpp' --driver-mode=g++ --target=x86_64-pc-windows-msvc -fms-runtime-lib=dll -nostdinc++ -I D:/a/llvm-project/llvm-project/build/clang-cl-dll/include/c++/v1 -I D:/a/llvm-project/llvm-project/build/clang-cl-dll/include/c++/v1 -I D:/a/llvm-project/llvm-project/libcxx/test/support -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -std=c++26 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-noexcept-type -Wno-atomic-alignment -Wno-reserved-module-identifier -Wdeprecated-copy -Wdeprecated-copy-dtor -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -Wno-local-type-template-args -Wno-c++11-extensions -Wno-unknown-pragmas -Wno-pass-failed -Wno-mismatched-new-delete -Wno-redundant-move -Wno-self-move -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE -Werror=thread-safety -Wuser-defined-warnings -DTEST_WINDOWS_DLL -fsyntax-only -Wno-error -Xclang -verify -Xclang -verify-ignore-unexpected=note -ferror-limit=0
# .---command stderr------------
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File D:/a/llvm-project/llvm-project/build/clang-cl-dll/include/c++/v1\__expected/expected.h Line 107: call to deleted constructor of 'std::__expected_void_base<int &>::__repr'
# | 1 error generated.
# `-----------------------------
# error: command failed with exit status: 1
```

Looking into it.
We might have to update the test to add an expected-error string on this. 

https://github.com/llvm/llvm-project/pull/104635