[libcxx-commits] [libcxx] [libcxx] Marks transform_error.mandates.verify.cpp unsupported on msvc (PR #104635)
Paul Kirth via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Aug 16 12:28:02 PDT 2024
================
@@ -10,11 +10,12 @@
// minumum required version these obsolete tests can be removed.
// TODO(LLVM-20) remove spurious clang diagnostic tests.
-// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
-
// With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
-// which break the tests.
-// XFAIL: msvc
+// which break the tests. But #102851 will turn it into an error, making the test pass.
+// However, upstream libcxx buildbots do not build clang from source while testing, so
+// this tests still expected to fail on these bots. Mark msvc as unsupported to mitigate
+// this issue.
+// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, msvc
----------------
ilovepi wrote:
We should probably split the msvc bit out into its own `UNSUPPORTED:` group w/ this comment and a tracking issue on github, since once libcxx CI builds with a new enough clang, this could go back to being supported. Same for the other test.
https://github.com/llvm/llvm-project/pull/104635
More information about the libcxx-commits
mailing list