[libcxx-commits] [libcxx] [libcxx] Add `LIBCXX_HAS_TERMINAL_AVAILABLE` CMake option to disable `print` terminal checks (PR #99259)

[Louis Dionne via libcxx-commits]

================
@@ -199,7 +199,7 @@ _LIBCPP_HIDE_FROM_ABI inline bool __is_terminal([[maybe_unused]] FILE* __stream)
   // the behavior in the test. This is not part of the public API.
 #  ifdef _LIBCPP_TESTING_PRINT_IS_TERMINAL
   return _LIBCPP_TESTING_PRINT_IS_TERMINAL(__stream);
-#  elif _LIBCPP_AVAILABILITY_HAS_PRINT == 0
+#  elif _LIBCPP_AVAILABILITY_HAS_PRINT == 0 || defined(_LIBCPP_HAS_NO_TERMINAL)
----------------
ldionne wrote:

@mordante We should have a test that exercises how we print to a stream (based on whether it's a terminal), and that test should fail (or at least have to be conditionalized) when terminal support is disabled. Do you agree that we're missing coverage right now?

https://github.com/llvm/llvm-project/pull/99259