[libcxx-commits] [libcxx] [libcxxabi] [libcxx][test] Disable large_tests for picolib builds (PR #103930)

David Spickett via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 14 08:21:13 PDT 2024


DavidSpickett wrote:

> FWIW, the question usually is, what is the threshold for “large”?

Yeah, this could get into "large for normal machines" and "large for embedded", and then even split again from there. We have 16MB of ram in the emulated machine in upstream CI, but down to 1MB and even 16k in downstream simulations.

> But the runners did get an increase in size earlier this year, so it’s also possible, is these tests are new, that these tests never ran on the very limited GHA runners.

I didn't consider that consequence, I think it's best we keep the feature meaning large by desktop PC standards. I'll come up with another approach for embedded concerns.

https://github.com/llvm/llvm-project/pull/103930


More information about the libcxx-commits mailing list