[libcxx-commits] [libcxx] [libcxxabi] [libcxx][test] Disable large_tests for picolib builds (PR #103930)

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 14 07:53:00 PDT 2024


mstorsjo wrote:

FWIW, the question usually is, what is the threshold for “large”?

I added the feature/flag as public github actions runners used to have very little memory, and this got the tests running there. The two tests you’re changing here did use to work there though. But the runners did get an increase in size earlier this year, so it’s also possible, is these tests are new, that these tests never ran on the very limited GHA runners. And I think the tests can run there without disabling large tests entirely, nowadays.

So all in all, I think this change is fine.

https://github.com/llvm/llvm-project/pull/103930


More information about the libcxx-commits mailing list