[libcxx-commits] [libcxx] [libcxx] [test] Enable gdb_pretty_printer_test.sh.cpp for clang (PR #102893)

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 12 13:20:54 PDT 2024


mstorsjo wrote:

> > Does this also work for older clang versions?
> 
> Actually, yes, it seems to run fine in the current CI environments with all clang versions. I guess it can easily fail in users' own local checkouts though, but in that case we should probably add a more finegrained `REQUIRES` for the test. There doesn't seem to be anything related to the clang version itself here at least.

This change seems to run fine in all our CI configs, except for the `generic-optimized-speed` config, which seems to lack the relevant symbols or something like that: https://github.com/llvm/llvm-project/actions/runs/10352053007/job/28662445559

So we can't merge this as is. I guess that optimized builds of the tests don't work with this test... Anyway, this PR was only a side quest for me, so I'll leave this up to someone else to pick up and finish...

https://github.com/llvm/llvm-project/pull/102893


More information about the libcxx-commits mailing list