[libcxx-commits] [libcxx] [libcxx] Handle windows system error code mapping in std::error_code. (PR #93101)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne requested changes to this pull request.

This generally looks sensible to me, but I have some questions and a few comments. I would also like to confirm that this is an ABI break because we'll return different error codes from the dylib before/after this patch, right? But that's only on Windows where we're not ABI stable anyways, so that shouldn't be an issue.

Is there a possibility that this would break user code that is relying on the previous mapping, or does that previous mapping never escape out of libc++ implementation details?

https://github.com/llvm/llvm-project/pull/93101