[libcxx-commits] [libcxx] [libcxx] Use `aligned_alloc` for testing instead of `posix_memalign` (PR #101748)

[Joseph Huber via libcxx-commits]

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/101748

Summary:
The `aligned_alloc` function is the C11 replacement for
`posix_memalign`. We should favor the C standard over the POSIX standard
so more C library implementations can run the tests.


>From 275813980e531591f1787ff47f8a65f49ff018fa Mon Sep 17 00:00:00 2001
From: Joseph Huber <huberjn at outlook.com>
Date: Fri, 2 Aug 2024 13:49:58 -0500
Subject: [PATCH] [libcxx] Use `aligned_alloc` for testing instead of
 `posix_memalign`

Summary:
The `aligned_alloc` function is the C11 replacement for
`posix_memalign`. We should favor the C standard over the POSIX standard
so more C library implementations can run the tests.
---
 .../support.dynamic/new_faligned_allocation.pass.cpp            | 2 +-
 libcxx/test/support/count_new.h                                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libcxx/test/libcxx/language.support/support.dynamic/new_faligned_allocation.pass.cpp b/libcxx/test/libcxx/language.support/support.dynamic/new_faligned_allocation.pass.cpp
index 69c46f00fb65d..87f4783e12973 100644
--- a/libcxx/test/libcxx/language.support/support.dynamic/new_faligned_allocation.pass.cpp
+++ b/libcxx/test/libcxx/language.support/support.dynamic/new_faligned_allocation.pass.cpp
@@ -76,7 +76,7 @@ int main(int, char**) {
   test_allocations(64, 64);
   // Size being a multiple of alignment also needs to be supported.
   test_allocations(64, 32);
-  // When aligned allocation is implemented using posix_memalign,
+  // When aligned allocation is implemented using aligned_alloc,
   // that function requires a minimum alignment of sizeof(void*).
   // Check that we can also create overaligned allocations with
   // an alignment argument less than sizeof(void*).
diff --git a/libcxx/test/support/count_new.h b/libcxx/test/support/count_new.h
index 0a95e05b72421..dc9fe2bcc610e 100644
--- a/libcxx/test/support/count_new.h
+++ b/libcxx/test/support/count_new.h
@@ -461,7 +461,7 @@ inline void* alocate_aligned_impl(std::size_t size, std::align_val_t align) {
 #    ifdef USE_ALIGNED_ALLOC
   ret = _aligned_malloc(size, alignment);
 #    else
-  assert(posix_memalign(&ret, std::max(alignment, sizeof(void*)), size) != EINVAL);
+  ret = aligned_alloc(alignment, size);
 #    endif
   return ret;
 }